Re: protect pg_stat_statements_info() for being used without the library loaded

2021-01-27 Thread Michael Paquier
On Thu, Jan 28, 2021 at 03:53:54PM +0900, Fujii Masao wrote: > Thanks! No problem. Applied as of bca96dd. -- Michael signature.asc Description: PGP signature

Re: protect pg_stat_statements_info() for being used without the library loaded

2021-01-27 Thread Fujii Masao
On 2021/01/28 15:42, Michael Paquier wrote: On Thu, Jan 28, 2021 at 08:49:54AM +0800, Julien Rouhaud wrote: Good catch, and patch looks good to me. This crashes the server, cash. Looking at all the other modules in the tree, I am not seeing any other hole. This is new as of 9fbc3f3, and I

Re: protect pg_stat_statements_info() for being used without the library loaded

2021-01-27 Thread Michael Paquier
On Thu, Jan 28, 2021 at 08:49:54AM +0800, Julien Rouhaud wrote: > Good catch, and patch looks good to me. This crashes the server, cash. Looking at all the other modules in the tree, I am not seeing any other hole. This is new as of 9fbc3f3, and I will apply it on HEAD. -- Michael signature.as

Re: protect pg_stat_statements_info() for being used without the library loaded

2021-01-27 Thread Julien Rouhaud
On Thu, Jan 28, 2021 at 3:53 AM Jaime Casanova wrote: > > Hi, > > Attached is a small patch for ${subject} Good catch, and patch looks good to me.

protect pg_stat_statements_info() for being used without the library loaded

2021-01-27 Thread Jaime Casanova
Hi, Attached is a small patch for ${subject} -- Jaime Casanova Director de Servicios Profesionales SystemGuards - Consultores de PostgreSQL diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c index 72a117fc19..62cccbfa44 100644 --- a/cont