Re: psql: fix variable existence tab completion

2024-05-07 Thread Anton A. Melnikov
Hi, Alexander! On 06.05.2024 13:19, Alexander Korotkov wrote: The patch attached fix the 010_tab_completion.pl test in the same way like [1]. Thank you for the fix. As I get, the fix teaches 010_tab_completion.pl to tolerate the invalid result of tab completion. Do you think we could fix it

Re: psql: fix variable existence tab completion

2024-05-06 Thread Alexander Korotkov
Hi, Anton! On Mon, May 6, 2024 at 9:05 AM Anton A. Melnikov wrote: > On 14.03.2024 17:57, Alexander Korotkov wrote: > > On Sun, Mar 3, 2024 at 5:37 PM Erik Wienhold wrote: > >> On 2024-03-03 03:00 +0100, Steve Chavez wrote: > >>> psql has the :{?name} syntax for testing a psql variable

Re: psql: fix variable existence tab completion

2024-05-06 Thread Anton A. Melnikov
Hello! On 14.03.2024 17:57, Alexander Korotkov wrote: On Sun, Mar 3, 2024 at 5:37 PM Erik Wienhold wrote: On 2024-03-03 03:00 +0100, Steve Chavez wrote: psql has the :{?name} syntax for testing a psql variable existence. But currently doing \echo :{?VERB doesn't trigger tab completion.

Re: psql: fix variable existence tab completion

2024-03-14 Thread Alexander Korotkov
On Sun, Mar 3, 2024 at 5:37 PM Erik Wienhold wrote: > On 2024-03-03 03:00 +0100, Steve Chavez wrote: > > psql has the :{?name} syntax for testing a psql variable existence. > > > > But currently doing \echo :{?VERB doesn't trigger tab completion. > > > > This patch fixes it. I've also included a

Re: psql: fix variable existence tab completion

2024-03-03 Thread Erik Wienhold
On 2024-03-03 03:00 +0100, Steve Chavez wrote: > psql has the :{?name} syntax for testing a psql variable existence. > > But currently doing \echo :{?VERB doesn't trigger tab completion. > > This patch fixes it. I've also included a TAP test. Thanks. The code looks good, all tests pass, and

psql: fix variable existence tab completion

2024-03-02 Thread Steve Chavez
2001 From: steve-chavez Date: Sat, 2 Mar 2024 19:06:13 -0500 Subject: [PATCH 1/1] psql: fix variable existence tab completion --- src/bin/psql/t/010_tab_completion.pl | 8 src/bin/psql/tab-complete.c | 4 +++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src