Re: psql tab completion versus Debian's libedit

2022-02-02 Thread Tom Lane
Andres Freund writes: > On 2022-02-02 22:28:31 -0500, Tom Lane wrote: >> I conclude that there are no extant versions of readline/libedit >> that don't have rl_completion_append_character, so we could >> drop that configure test and save a cycle or two. > Sounds good to me! On it now.

Re: psql tab completion versus Debian's libedit

2022-02-02 Thread Andres Freund
On 2022-02-02 22:28:31 -0500, Tom Lane wrote: > I conclude that there are no extant versions of readline/libedit > that don't have rl_completion_append_character, so we could > drop that configure test and save a cycle or two. Sounds good to me!

Re: psql tab completion versus Debian's libedit

2022-02-02 Thread Tom Lane
Andres Freund writes: > I think this is caused by the feature flag detection being broken in the meson > branch - unrelated to your commit - ending up with falsely believing that none > of the rl_* variables exist (below for more on that aspect). > Do we care that the tests would fail when using

Re: psql tab completion versus Debian's libedit

2022-02-02 Thread Andres Freund
Hi, On 2022-02-01 16:30:11 -0500, Tom Lane wrote: > I chased down the failure that kittiwake has been showing since > 02b8048ba [1]. I just rebased my meson branch across the commit d33a81203e9. And on freebsd the meson based build failed in the expanded tests, while autoconf succeeded. The

psql tab completion versus Debian's libedit

2022-02-01 Thread Tom Lane
I chased down the failure that kittiwake has been showing since 02b8048ba [1]. It's not hard to reproduce if you have an older Debian release and you build --with-libedit-preferred. Manual experimentation shows that when these versions of libedit complete a string containing double quotes, they