Re: refactor some protocol message sending in walsender and basebackup

2022-07-05 Thread Peter Eisentraut
On 01.07.22 23:36, Nathan Bossart wrote: On Thu, Jun 23, 2022 at 04:36:36PM +0200, Peter Eisentraut wrote: Some places in walsender.c and basebackup_copy.c open-code the sending of RowDescription and DataRow protocol messages. But there are already more compact and robust solutions available fo

Re: refactor some protocol message sending in walsender and basebackup

2022-07-01 Thread Nathan Bossart
On Thu, Jun 23, 2022 at 04:36:36PM +0200, Peter Eisentraut wrote: > Some places in walsender.c and basebackup_copy.c open-code the sending of > RowDescription and DataRow protocol messages. But there are already more > compact and robust solutions available for this, using DestRemoteSimple and > a

refactor some protocol message sending in walsender and basebackup

2022-06-23 Thread Peter Eisentraut
Some places in walsender.c and basebackup_copy.c open-code the sending of RowDescription and DataRow protocol messages. But there are already more compact and robust solutions available for this, using DestRemoteSimple and associated machinery, already in use in walsender.c. The attached patc