Re: reorganizing partitioning code (was: Re: [HACKERS] path toward faster partition pruning)

2018-02-14 Thread Alvaro Herrera
This is looking attractive. Please don't #include postgres.h in partcache.h. That's per policy. Why do you need to #include parsenodes.h in partcache.h? I think rewriteManip.h can do with just relcache.h rather than rel.h (probably partition.h can do likewise) thanks -- Álvaro Herrera

Re: reorganizing partitioning code (was: Re: [HACKERS] path toward faster partition pruning)

2018-02-13 Thread Amit Langote
On 2018/02/13 23:08, Ashutosh Bapat wrote: > On Tue, Feb 13, 2018 at 2:17 PM, Amit Langote > wrote: >> >> Agree with the proposed reorganizing and adding a partcache.c, which I >> tried to do in the attached patch. >> >> * The new src/backend/utils/cache/partcache.c