On Tue, Apr 25, 2023 at 3:12 PM Tom Lane wrote:
> Kyotaro Horiguchi writes:
> > While working on a patch, I noticed that a rcent commit (d4e71df6d75)
> > added an apparently unnecessary inclusion of guc.h in smgr.h.
>
> Yes, that seems quite awful, and I also wonder why it changed fd.h.
> Adding
Kyotaro Horiguchi writes:
> While working on a patch, I noticed that a rcent commit (d4e71df6d75)
> added an apparently unnecessary inclusion of guc.h in smgr.h.
Yes, that seems quite awful, and I also wonder why it changed fd.h.
Adding #include's to header files is generally not the first choice
Hello.
While working on a patch, I noticed that a rcent commit (d4e71df6d75)
added an apparently unnecessary inclusion of guc.h in smgr.h.
The only change made by the commit to the file is the added #include
directive, which doesn't seem to be functioning, and the build
actually suceeds without i
