Re: select limit error in file_fdw

2018-12-16 Thread Tom Lane
Erik Rijkers writes: > Thank you very much. I've now also tested with the original, much larger > file, which gives no problem anymore. I am really glad this works again, > we use this stuff a lot. We appreciate you noticing the problem before 11.2 got out ... regards,

Re: select limit error in file_fdw

2018-12-16 Thread Erik Rijkers
On 2018-12-16 19:10, Tom Lane wrote: Anyway, we know what to do, so I'll go do it. Thank you very much. I've now also tested with the original, much larger file, which gives no problem anymore. I am really glad this works again, we use this stuff a lot. Erik Rijkers

Re: select limit error in file_fdw

2018-12-16 Thread Tom Lane
Erik Rijkers writes: > On 2018-12-16 16:52, Tom Lane wrote: >> However, something else occurred to me this morning, and a bit >> later I can reproduce the problem! I did it by changing the >> table's definition to use a shell pipeline: > /bin/sh seems to be dash, here. Hm. That must be the rel

Re: select limit error in file_fdw

2018-12-16 Thread Erik Rijkers
On 2018-12-16 16:52, Tom Lane wrote: Erik Rijkers writes: On 2018-12-16 07:03, Tom Lane wrote: Um ... this example works for me, in both HEAD and v11 branch tip. Moreover, the behavior you describe is exactly what ffa4cbd623 was intended to fix. Is there any chance that you got 11.1 and v11 b

Re: select limit error in file_fdw

2018-12-16 Thread Tom Lane
I wrote: > It remains unclear why you had an intervening shell process when > I didn't, but perhaps that can be chalked up to use of a different > shell? To provide some data on that: popen() is presumably invoking /bin/sh, which on my box is $ /bin/sh --version GNU bash, version 4.1.2(1)-release

Re: select limit error in file_fdw

2018-12-16 Thread Tom Lane
Erik Rijkers writes: > On 2018-12-16 07:03, Tom Lane wrote: >> Um ... this example works for me, in both HEAD and v11 branch tip. >> Moreover, the behavior you describe is exactly what ffa4cbd623 was >> intended to fix. Is there any chance that you got 11.1 and v11 >> branch tip mixed up? > [ no

Re: select limit error in file_fdw

2018-12-16 Thread Erik Rijkers
On 2018-12-16 11:19, Erik Rijkers wrote: On 2018-12-16 07:03, Tom Lane wrote: Erik Rijkers writes: I have noticed that since ffa4cbd623, a foreign table that pulls data from a PROGRAM (in this case an unzip call) will fail if there is a LIMIT on the SELECT (while succeeding without LIMIT). Bel

Re: select limit error in file_fdw

2018-12-16 Thread Erik Rijkers
On 2018-12-16 07:03, Tom Lane wrote: Erik Rijkers writes: I have noticed that since ffa4cbd623, a foreign table that pulls data from a PROGRAM (in this case an unzip call) will fail if there is a LIMIT on the SELECT (while succeeding without LIMIT). Below is an example. Um ... this example wo

Re: select limit error in file_fdw

2018-12-15 Thread Tom Lane
Erik Rijkers writes: > I have noticed that since ffa4cbd623, a foreign table that pulls data > from a PROGRAM (in this case an unzip call) will fail if there is a > LIMIT on the SELECT > (while succeeding without LIMIT). Below is an example. Um ... this example works for me, in both HEAD and v11

select limit error in file_fdw

2018-12-15 Thread Erik Rijkers
Hello, I have noticed that since ffa4cbd623, a foreign table that pulls data from a PROGRAM (in this case an unzip call) will fail if there is a LIMIT on the SELECT (while succeeding without LIMIT). Below is an example. (Table size matters, so larger machines than mine may need more than those