>
>
> On Sun, Oct 4, 2020 at 4:20 PM Tom Lane wrote:
> > I didn't try very hard to trace the commit history, but I did note that
> > almost all of the removed #includes dated to 1996 or so. I'm surprised
> > they survived Bruce's occasional attempts at removing unused #includes;
> > maybe his scr
John Naylor writes:
> On Thu, Oct 1, 2020 at 11:19 AM Tom Lane wrote:
>> In short: maybe instead of what you have here, leave GUC_scanstr()
>> alone except for a possible rename; make bootscanner.l use that;
>> and drop the now-unused scanstr().
> v2 done that way.
Pushed with very minor adjust
On Thu, Oct 1, 2020 at 11:19 AM Tom Lane wrote:
> I'm unsure this topic is worth messing with. But if we do so, I'd kind
> of like to move scanstr() out of parser/scansup.c. Since it's not used
> by the core scanner, only bootstrap, it seems out of place there; and
> it's confusing because someb
John Naylor writes:
> In the attached, the GUC_scanstr() function body is moved to scansup.c
> to replace scanstr(), but with a different order of if-statements to
> make the diff smaller. Since we have control over what goes in the BKI
> file, we can use single-quoted escape strings there, allowi
Hi,
Looking at the guc file code, GUC_scanstr() is almost the same as the
exported function scanstr(), except the latter requires finicky extra
coding around double quotes both in its callers and while creating the
input.
In the attached, the GUC_scanstr() function body is moved to scansup.c
to r
