On Thu, Apr 25, 2024 at 2:03 PM Daniel Gustafsson wrote:
> LGTM, only one small error in the commitmessage: s/Gustaffson/Gustafsson/
Oh no! You're in danger of becoming the second person on this project
whose name I chronically misspell. Fixed (I hope) and committed.
--
Robert Haas
EDB:
> On 25 Apr 2024, at 17:48, Robert Haas wrote:
>
> On Wed, Apr 24, 2024 at 3:20 PM Daniel Gustafsson wrote:
>> Patch LGTM.
>
> Thanks. Here's an updated version with fixes for the other issues you
> mentioned.
LGTM, only one small error in the commitmessage: s/Gustaffson/Gustafsson/
--
On Wed, Apr 24, 2024 at 3:20 PM Daniel Gustafsson wrote:
> Patch LGTM.
Thanks. Here's an updated version with fixes for the other issues you mentioned.
--
Robert Haas
EDB: http://www.enterprisedb.com
v2-0001-Minor-fixes-to-pg_combinebackup-and-its-documenta.patch
Description: Binary data
> On 24 Apr 2024, at 19:59, Robert Haas wrote:
> Here is a very small patch correcting these regrettable errors.
Patch LGTM.
In addition to those, unless I'm reading it wrong the current coding seems to
include a "-P" short option which is missing in the command parsing switch
statement (or in
Tomas Vondra pointed out to me a couple of mistakes that I made with
regard to pg_combinebackup and tablespaces.
One is that I screwed up the long_options array by specifying
tablespace-mapping as no_argument rather than required_argument. That
doesn't break the tests I just committed because, in
