On Wed, Aug 10, 2022 at 2:06 PM Andrey Borodin wrote:
> > On 10 Aug 2022, at 19:49, Robert Haas wrote:
> > After a bit of further looking around I noticed that there's another
> > check for an invalid auxtype in this function which uses a slightly
> > different message text and also PANIC rather
> On 10 Aug 2022, at 19:49, Robert Haas wrote:
>
> After a bit of further looking around I noticed that there's another
> check for an invalid auxtype in this function which uses a slightly
> different message text and also PANIC rather than ERROR.
Is there a reason to do
MyBackendType =
Hi,
On 2022-08-10 10:49:59 -0400, Robert Haas wrote:
> On Wed, Aug 10, 2022 at 9:53 AM Tom Lane wrote:
> > Robert Haas writes:
> >
> > - elog(ERROR, "something has gone wrong");
> > + elog(ERROR, "unrecognized AuxProcType: %d", (int)
> > auxtype);
>
On Wed, Aug 10, 2022 at 9:53 AM Tom Lane wrote:
> Robert Haas writes:
>
> - elog(ERROR, "something has gone wrong");
> + elog(ERROR, "unrecognized AuxProcType: %d", (int)
> auxtype);
>
> +1 ... the existing message is clearly not up to project
Robert Haas writes:
- elog(ERROR, "something has gone wrong");
+ elog(ERROR, "unrecognized AuxProcType: %d", (int)
auxtype);
+1 ... the existing message is clearly not up to project standard.
regards, tom lane
> On 10 Aug 2022, at 15:41, Robert Haas wrote:
> I feel we could do better still, as in the attached.
+1, LGTM.
--
Daniel Gustafsson https://vmware.com/
Hi,
Today while hacking I encountered this delight:
2022-08-10 09:30:29.025 EDT [27126] FATAL: something has gone wrong
I actually already knew that something had gone wrong, because the
code I was writing was incomplete. And if I hadn't known that, the
word FATAL would have been a real good
