Re: src/test/perl/TestLib.pm: check_pg_config needs /usr/include/postgresql/pg_config.h

2020-05-08 Thread Christoph Berg
Re: Tom Lane > But during "make check", that should be executing pg_config from the > the temporary installation, so we should get the right answer no? > > Conversely, in "make installcheck" scenarios, we definitely do want > the value from the installed file, or so I should think. > > Do you hav

Re: src/test/perl/TestLib.pm: check_pg_config needs /usr/include/postgresql/pg_config.h

2020-05-08 Thread Tom Lane
Christoph Berg writes: > I believe check_pg_config as used by src/test/ssl/t/002_scram.pl > shouldn't rely on /usr/include/postgresql/pg_config.h but use the file > from the build tree instead: But during "make check", that should be executing pg_config from the the temporary installation, so we

src/test/perl/TestLib.pm: check_pg_config needs /usr/include/postgresql/pg_config.h

2020-05-08 Thread Christoph Berg
I believe check_pg_config as used by src/test/ssl/t/002_scram.pl shouldn't rely on /usr/include/postgresql/pg_config.h but use the file from the build tree instead: src/test/perl/TestLib.pm: Return the number of matches of the given regular expression within the installation's C. =cu