Re: test/isolation/expected/stats_1.out broken for me

2022-04-07 Thread Andres Freund
Hi, On 2022-04-07 18:31:35 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2022-04-07 09:57:09 -0700, Andres Freund wrote: > >> Yea :(. I tested debug_discard_caches, but not -DRELCACHE_FORCE_RELEASE > >> -DCATCACHE_FORCE_RELEASE. > >> > >> Not quite sure what to do about it - it's intentio

Re: test/isolation/expected/stats_1.out broken for me

2022-04-07 Thread Tom Lane
Andres Freund writes: > On 2022-04-07 09:57:09 -0700, Andres Freund wrote: >> Yea :(. I tested debug_discard_caches, but not -DRELCACHE_FORCE_RELEASE >> -DCATCACHE_FORCE_RELEASE. >> >> Not quite sure what to do about it - it's intentionally trying to test the >> case of no invalidations being pro

Re: test/isolation/expected/stats_1.out broken for me

2022-04-07 Thread Andres Freund
Hi, On 2022-04-07 09:57:09 -0700, Andres Freund wrote: > Yea :(. I tested debug_discard_caches, but not -DRELCACHE_FORCE_RELEASE > -DCATCACHE_FORCE_RELEASE. > > Not quite sure what to do about it - it's intentionally trying to test the > case of no invalidations being processed, as that's an anno

Re: test/isolation/expected/stats_1.out broken for me

2022-04-07 Thread chap
On 2022-04-07 15:04, Andres Freund wrote: And done. Chap, could you confirm this fixes the issue for you? Looks good from here. One installcheck-world with no failures; previously, it failed for me every time. Regards, -Chap

Re: test/isolation/expected/stats_1.out broken for me

2022-04-07 Thread Andres Freund
Hi, On 2022-04-07 11:54:08 -0700, Andres Freund wrote: > I'll change it to use distinct payloads.. And done. Chap, could you confirm this fixes the issue for you? Greetings, Andres Freund

Re: test/isolation/expected/stats_1.out broken for me

2022-04-07 Thread Andres Freund
Hi, On 2022-04-07 11:02:41 -0700, Andres Freund wrote: > I've now reproduced this, albeit not reliably yet. Looking. Caused by me misremembering when deduplication happens - somehow recalled that deduplication didn't happen when payloads. So the statement that was supposed to guarantee needing mo

Re: test/isolation/expected/stats_1.out broken for me

2022-04-07 Thread Andres Freund
Hi, On 2022-04-07 10:29:10 -0700, Andres Freund wrote: > On 2022-04-07 13:16:53 -0400, c...@anastigmatix.net wrote: > > The command that I've just been reusing from my bash_history without > > thinking about it for some years is: > > > > configure --enable-cassert --enable-tap-tests \ > > --with

Re: test/isolation/expected/stats_1.out broken for me

2022-04-07 Thread Andres Freund
Hi, On 2022-04-07 13:16:53 -0400, c...@anastigmatix.net wrote: > The command that I've just been reusing from my bash_history without > thinking about it for some years is: > > configure --enable-cassert --enable-tap-tests \ > --with-libxml --enable-debug \ > CFLAGS='-ggdb -Og -g3 -fno-omit-fra

Re: test/isolation/expected/stats_1.out broken for me

2022-04-07 Thread chap
On 2022-04-07 12:49, Tom Lane wrote: So what non-default build options are you using? The command that I've just been reusing from my bash_history without thinking about it for some years is: configure --enable-cassert --enable-tap-tests \ --with-libxml --enable-debug \ CFLAGS='-ggdb -Og -g3

Re: test/isolation/expected/stats_1.out broken for me

2022-04-07 Thread Andres Freund
Hi, On 2022-04-07 12:49:07 -0400, Tom Lane wrote: > c...@anastigmatix.net writes: > > Running installcheck-world on an unrelated patch, I noticed a failure > > here in test/isolation/expected/stats_1.out (this is line 3102): > > So what non-default build options are you using? > > The only isola

Re: test/isolation/expected/stats_1.out broken for me

2022-04-07 Thread Tom Lane
c...@anastigmatix.net writes: > Running installcheck-world on an unrelated patch, I noticed a failure > here in test/isolation/expected/stats_1.out (this is line 3102): So what non-default build options are you using? The only isolationcheck failure remaining in the buildfarm is prion's, which I

test/isolation/expected/stats_1.out broken for me

2022-04-07 Thread chap
Running installcheck-world on an unrelated patch, I noticed a failure here in test/isolation/expected/stats_1.out (this is line 3102): step s1_slru_check_stats: SELECT current.blks_zeroed > before.value FROM test_slru_stats before INNER JOIN pg_stat_slru current ON before.slru = cur