Re: test_pg_dump missing cleanup actions

2018-11-30 Thread Stephen Frost
Michael, * Michael Paquier (mich...@paquier.xyz) wrote: > On Tue, Sep 04, 2018 at 04:14:15PM -0700, Michael Paquier wrote: > > On Tue, Sep 04, 2018 at 06:02:51PM -0400, Stephen Frost wrote: > >> * Tom Lane (t...@sss.pgh.pa.us) wrote: > >>> I'm confused. Isn't the point of that script exactly to c

Re: test_pg_dump missing cleanup actions

2018-11-28 Thread Michael Paquier
Hi Stephen, On Thu, Sep 27, 2018 at 06:49:26PM -0400, Stephen Frost wrote: > * Michael Paquier (mich...@paquier.xyz) wrote: >> On Thu, Sep 06, 2018 at 09:20:15AM -0700, Michael Paquier wrote: >>> Attached is a patch with more comments about the intents of the test >>> suite, and the separate issue

Re: test_pg_dump missing cleanup actions

2018-09-27 Thread Stephen Frost
Michael, * Michael Paquier (mich...@paquier.xyz) wrote: > On Thu, Sep 06, 2018 at 09:20:15AM -0700, Michael Paquier wrote: > > Attached is a patch with more comments about the intents of the test > > suite, and the separate issue pointed out by Tom fixed. It seems to me > > that actually checking

Re: test_pg_dump missing cleanup actions

2018-09-27 Thread Michael Paquier
On Thu, Sep 06, 2018 at 09:20:15AM -0700, Michael Paquier wrote: > Attached is a patch with more comments about the intents of the test > suite, and the separate issue pointed out by Tom fixed. It seems to me > that actually checking the contents of pg_init_privs would improve the > reason why the

Re: test_pg_dump missing cleanup actions

2018-09-06 Thread Michael Paquier
Hi Stephen, On Tue, Sep 04, 2018 at 04:14:15PM -0700, Michael Paquier wrote: > On Tue, Sep 04, 2018 at 06:02:51PM -0400, Stephen Frost wrote: >> * Tom Lane (t...@sss.pgh.pa.us) wrote: >>> I'm confused. Isn't the point of that script exactly to create a modified >>> extension for testing pg_dump w

Re: test_pg_dump missing cleanup actions

2018-09-04 Thread Michael Paquier
On Tue, Sep 04, 2018 at 06:02:51PM -0400, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> Michael Paquier writes: >>> While hacking another patch, I have noticed that triggerring multiple >>> times in a row installcheck on test_pg_dump results in a failure because >>> it is missin

Re: test_pg_dump missing cleanup actions

2018-09-04 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Michael Paquier writes: > > While hacking another patch, I have noticed that triggerring multiple > > times in a row installcheck on test_pg_dump results in a failure because > > it is missing clean up actions on the role regress_dump_test_role.

Re: test_pg_dump missing cleanup actions

2018-09-04 Thread Tom Lane
Michael Paquier writes: > While hacking another patch, I have noticed that triggerring multiple > times in a row installcheck on test_pg_dump results in a failure because > it is missing clean up actions on the role regress_dump_test_role. > Roles are shared objects, so I think that we ought to no

test_pg_dump missing cleanup actions

2018-09-04 Thread Michael Paquier
Hi Stephen, While hacking another patch, I have noticed that triggerring multiple times in a row installcheck on test_pg_dump results in a failure because it is missing clean up actions on the role regress_dump_test_role. Roles are shared objects, so I think that we ought to not let traces of it w