Re: time for catalog/pg_cast.c?

2020-03-10 Thread Alvaro Herrera
On 2020-Mar-09, Alvaro Herrera wrote: > I extracted from the latest multirange patch a bit that creates a new > routine CastCreate() in src/backend/catalog/pg_cast.c. It contains the > catalog-accessing bits to create a new cast. It seems harmless, so I > thought I'd apply it to get rid of a

Re: time for catalog/pg_cast.c?

2020-03-10 Thread Alvaro Herrera
I would even say that DropCastById belongs in the new file, which is just the attached. However, none of the Drop.*ById or Remove.*ById functions seem to be in backend/catalog/ at all, and moving just a single one seems to make things even more inconsistent. I think all these catalog-accessing

Re: time for catalog/pg_cast.c?

2020-03-09 Thread Alvaro Herrera
On 2020-Mar-09, Alvaro Herrera wrote: > I extracted from the latest multirange patch a bit that creates a new > routine CastCreate() in src/backend/catalog/pg_cast.c. It contains the > catalog-accessing bits to create a new cast. It seems harmless, so I > thought I'd apply it to get rid of a

time for catalog/pg_cast.c?

2020-03-09 Thread Alvaro Herrera
I extracted from the latest multirange patch a bit that creates a new routine CastCreate() in src/backend/catalog/pg_cast.c. It contains the catalog-accessing bits to create a new cast. It seems harmless, so I thought I'd apply it to get rid of a couple of hunks in the large patch. (I also