Re: ts_locale.c: why no t_isalnum() test?

2022-10-19 Thread Tom Lane
Corey Huinker writes: > I see this is already committed, but I'm curious, why do t_isalpha and > t_isdigit have the pair of /* TODO */ comments? This unfinished business > isn't explained anywhere in the file. We really ought to be consulting the locale/collation passed to the SQL-level operator

Re: ts_locale.c: why no t_isalnum() test?

2022-10-19 Thread Corey Huinker
On Wed, Oct 5, 2022 at 3:53 PM Tom Lane wrote: > I happened to wonder why various places are testing things like > > #define ISWORDCHR(c)(t_isalpha(c) || t_isdigit(c)) > > rather than using an isalnum-equivalent test. The direct answer > is that ts_locale.c/.h provides no such test

ts_locale.c: why no t_isalnum() test?

2022-10-05 Thread Tom Lane
I happened to wonder why various places are testing things like #define ISWORDCHR(c)(t_isalpha(c) || t_isdigit(c)) rather than using an isalnum-equivalent test. The direct answer is that ts_locale.c/.h provides no such test function, which apparently is because there's not a lot of