Andres Freund writes:
> On 2019-12-12 09:27:04 -0500, Tom Lane wrote:
>> What seems like a simpler and more reliable fix is to make
>> test_mark_restore a temp table, thus keeping autovac away from it.
>> Is there a reason in terms of the test's goals not to do that?
> I can't see any reason. The
Hi,
On 2019-12-12 09:27:04 -0500, Tom Lane wrote:
> Andres Freund writes:
> > I pushed this now. We'll see what the slower buildfarm animals say. I'll
> > try to see how long they took in a few days.
>
> friarbird (a CLOBBER_CACHE_ALWAYS animal) just showed a failure in this:
>
> https://buildf
Andres Freund writes:
> I pushed this now. We'll see what the slower buildfarm animals say. I'll
> try to see how long they took in a few days.
friarbird (a CLOBBER_CACHE_ALWAYS animal) just showed a failure in this:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=friarbird&dt=2019-12-12
Hi,
On 2019-10-25 12:37:38 +0100, Peter Geoghegan wrote:
> On Thu, Oct 24, 2019 at 10:10 PM Andres Freund wrote:
> > Here's a first stab at getting the coverage of tuplesort.c to a
> > satisfying level. There's still bits uncovered, but that's largely
> > either a) trace_sort related b) hopefull
On Thu, Oct 24, 2019 at 10:10 PM Andres Freund wrote:
> Here's a first stab at getting the coverage of tuplesort.c to a
> satisfying level. There's still bits uncovered, but that's largely
> either a) trace_sort related b) hopefully unreachable stuff c) explain
> related. The largest actually mis
On Thu, Oct 24, 2019 at 7:10 PM Andres Freund wrote:
> I really don't think it's ok to have as many abbrev abort related paths
> without any coverage - the relevant code isn't that trivial. And
> something like amcheck really doesn't strike me as sufficient. For one,
> it doesn't provide any cover
Hi,
On 2019-10-24 11:10:34 -0700, Andres Freund wrote:
> On 2019-10-15 13:05:32 +0100, Peter Geoghegan wrote:
> > > - aborted abbreviated keys (lines 1522, 1608, 1774, 3620, 3739, 3867,
> > > 4266)
> >
> > Also hard to test -- there was a bug here when abbreviated keys first
> > went in -- that
Hi,
On 2019-10-15 13:05:32 +0100, Peter Geoghegan wrote:
> > - aborted abbreviated keys (lines 1522, 1608, 1774, 3620, 3739, 3867, 4266)
>
> Also hard to test -- there was a bug here when abbreviated keys first
> went in -- that was detected by amcheck.
>
> All of the places where we abort are e
On Sun, Oct 13, 2019 at 3:41 PM Andres Freund wrote:
> - cluster for expression indexes (line 935)
We've never had coverage of this, but perhaps that can be added now.
> - sorts exceeding INT_MAX / 2 memory (line 1337), but that seems hard to
> test realistically
I don't think that that can b
Hi,
[1] made me look at tuplesorts test coverage at
https://coverage.postgresql.org/src/backend/utils/sort/tuplesort.c.gcov.html
We don't have coverage for a quite a number of things:
- cluster for expression indexes (line 935)
- sorts exceeding INT_MAX / 2 memory (line 1337), but that seems hard
10 matches
Mail list logo
