Re: wal_sync_method=fsync_writethrough

2022-08-29 Thread Thomas Munro
On Tue, Aug 30, 2022 at 3:44 AM Magnus Hagander wrote: > On Fri, Aug 26, 2022 at 11:29 PM Thomas Munro wrote: > > Now it looks strange: we have both "fsync" and "fsync_writethrough" > > doing exactly the same thing while vaguely implying otherwise, and the > > contrast with other operating system

Re: wal_sync_method=fsync_writethrough

2022-08-29 Thread Magnus Hagander
On Fri, Aug 26, 2022 at 11:29 PM Thomas Munro wrote: > > On Sat, Aug 27, 2022 at 12:17 AM Magnus Hagander wrote: > > So, I don't know how it works now, but the history at least was this: > > it was not about the disk caches, it was about raid controller caches. > > Basically, we determined that w

Re: wal_sync_method=fsync_writethrough

2022-08-26 Thread Thomas Munro
On Sat, Aug 27, 2022 at 12:17 AM Magnus Hagander wrote: > So, I don't know how it works now, but the history at least was this: > it was not about the disk caches, it was about raid controller caches. > Basically, we determined that windows didn't fsync it all the way. But > it would with But if

Re: wal_sync_method=fsync_writethrough

2022-08-26 Thread Magnus Hagander
On Fri, Aug 26, 2022 at 6:55 AM Thomas Munro wrote: > > Hi, > > We allow $SUBJECT on Windows. I'm not sure exactly how we finished up > with that, maybe a historical mistake, but I find it misleading today. > Modern Windows flushes drive write caches for fsync (= _commit()) and > fdatasync (= FLU

wal_sync_method=fsync_writethrough

2022-08-25 Thread Thomas Munro
om: Thomas Munro Date: Fri, 26 Aug 2022 14:27:43 +1200 Subject: [PATCH 1/3] Remove wal_sync_method=fsync_writethrough on Windows. The fsync and fdatasync levels already flush drive write caches on Windows, so it only confuses matters to have an apparently higher level that isn't actually h