Re: wrong shell trap

2022-09-13 Thread Peter Geoghegan
On Tue, Sep 13, 2022 at 2:01 PM Tom Lane wrote: > > AFAICT almost all of our shell scripts contain the same mistake. I > > propose to fix them all as in the attached demo patch, which makes > > headerscheck exit properly (no silly noise) when interrupted. > > Sounds like a good idea. Might not b

Re: wrong shell trap

2022-09-13 Thread Tom Lane
Alvaro Herrera writes: > While messing with the new guc.h stuff I happened run headerscheck and > wanted to abort it right away, and in doing so I realized that its > 'trap' line is incorrect: it only removes its temp dir, but it doesn't > exit the program; so after you C-c it, it will spew a ton

wrong shell trap

2022-09-13 Thread Alvaro Herrera
While messing with the new guc.h stuff I happened run headerscheck and wanted to abort it right away, and in doing so I realized that its 'trap' line is incorrect: it only removes its temp dir, but it doesn't exit the program; so after you C-c it, it will spew a ton of complaints about its temp dir