Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

On 1/23/18 16:18, Daniel Gustafsson wrote: >> The change is >> >> - 'psql', '-X', '-A', '-t', '-c', "SELECT 'connected with $connstr'", >> + 'psql', '-X', '-A', '-t', '-c', "SELECT \$\$connected with $connstr\$\$", >> >> So the problem must have been a single quote in the connstr. > Right, looking

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

On 25 January 2018 at 18:40, Alexander Korotkov wrote: > On Wed, Jan 10, 2018 at 9:55 PM, Shubham Barai > wrote: > >> The previous patch couldn't be applied cleanly because there were some >> modifications to isolation_schedule. I have

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

On 1/23/18 13:39, Robert Haas wrote: > On Tue, Jan 23, 2018 at 12:03 PM, Peter Eisentraut > wrote: >> It might also be useful to set these reloptions before you add a new >> column to a table. > > I don't understand. AAUI, it is currently the case that if you

Re: [HACKERS] GSoC 2017: weekly progress reports (week 4) and patch for hash index

On Sat, Jan 20, 2018 at 4:24 PM, Amit Kapila wrote: > On Fri, Sep 29, 2017 at 8:20 PM, Alexander Korotkov > wrote: > > On Fri, Sep 8, 2017 at 4:07 AM, Thomas Munro < > thomas.mu...@enterprisedb.com> > > wrote: > >> > >> Hi Shubham, > >> > >>

Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem

On Thu, Jan 25, 2018 at 4:11 AM, Thomas Munro wrote: > On Thu, Jan 18, 2018 at 9:17 AM, Claudio Freire > wrote: >> Huh. That was simpler than I thought. >> >> Attached rebased versions. > > Hi Claudio, > > FYI the regression test seems to

Re: [PATCH] Logical decoding of TRUNCATE

Il 25/01/18 13:18, Petr Jelinek ha scritto: > On 25/01/18 08:26, Thomas Munro wrote: >> On Wed, Jan 24, 2018 at 6:47 AM, Marco Nenciarini >> wrote: >>> Version 16 attached. >> >> Hi Marco, >> >> FYI this version doesn't compile: >> >> worker.c: In function

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

On Wed, Jan 10, 2018 at 9:55 PM, Shubham Barai wrote: > The previous patch couldn't be applied cleanly because there were some > modifications to isolation_schedule. I have updated the patch now. > In the attached patch indentation is still looking strange. I've

Re: [HACKERS] Custom compression methods

Hello Ildus, On 23.01.2018 16:04, Ildus Kurbangaliev wrote: On Mon, 22 Jan 2018 23:26:31 +0300 Ildar Musin wrote: Thanks for review! Attached new version of the patch. Fixed few bugs, added more documentation and rebased to current master. You need to rebase to the

Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath

I've attached an updated patch which takes care of the build failure caused by the new call to create_append_path added in bb94ce4. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

Michael, all, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Wed, Jan 24, 2018 at 12:43:51PM -0500, Stephen Frost wrote: > > * chenhj (chjis...@163.com) wrote: > >> At 2018-01-23 09:56:48, "Stephen Frost" wrote: > >>> I've only read through the thread to try and

Re: [Patch] Make block and file size for WAL and relations defined at cluster creation

On Wed, Jan 3, 2018 at 12:26 AM, Robert Haas wrote: > On Sun, Dec 31, 2017 at 12:00 PM, Remi Colinet > wrote: > > Below patch makes block and file sizes defined at cluster creation for > both > > the WAL and the relations. This avoids having

Re: [PROPOSAL] Shared Ispell dictionaries

On Wed, 24 Jan 2018 20:20:41 +0300 Arthur Zakirov wrote: Hi, I did some review of the patch. In 0001 there are few lines where is only indentation has changed. 0002: - TsearchShmemSize - calculating size using hash_estimate_size seems redundant since you use DSA hash

Re: [PATCH] Logical decoding of TRUNCATE

On 25/01/18 08:26, Thomas Munro wrote: > On Wed, Jan 24, 2018 at 6:47 AM, Marco Nenciarini > wrote: >> Version 16 attached. > > Hi Marco, > > FYI this version doesn't compile: > > worker.c: In function ‘apply_handle_truncate’: > worker.c:888:39: error:

Re: list partition constraint shape

(2018/01/25 18:44), Amit Langote wrote: On 2018/01/23 20:13, Etsuro Fujita wrote: Here are review comments that I have for now: * I think it's a good idea to generate an OR expression tree for the case where the type of the partitioning key is an array, but I'm not sure we should handle other

Re: CONSTANT/NOT NULL/initializer properties for plpgsql record variables

> On 25 Jan 2018, at 00:32, Tom Lane wrote: > > I wrote: >> I said a couple of times in recent threads that it wouldn't be too hard >> to implement $SUBJECT given the other patches I've been working on. > > Here's a version rebased up to HEAD, with a trivial merge conflict

Re: Temporary tables prevent autovacuum, leading to XID wraparound

On Thu, Jan 25, 2018 at 3:14 PM, Tsunakawa, Takayuki wrote: > > FIX > > > I have the following questions. Along which line should I proceed to fix the > problem? > > * Why does autovacuum launcher always choose only one

Re: non-bulk inserts and tuple routing

(2018/01/25 18:52), Amit Langote wrote: On 2018/01/25 18:30, Etsuro Fujita wrote: The patches apply cleanly and compile successfully, but make check fails in an assert-enabled build. Hmm, I can't seem to reproduce the failure with v4 patches I posted earlier today. ===

Reorder C includes in partition.c

Here is a small patch for $SUBJECT. Best regards, Etsuro Fujita diff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c index 8adc4ee..e69bbc0 100644 --- a/src/backend/catalog/partition.c +++ b/src/backend/catalog/partition.c @@ -46,11 +46,11 @@ #include "utils/array.h"

Re: non-bulk inserts and tuple routing

Fujita-san, Thanks for the review. On 2018/01/25 18:30, Etsuro Fujita wrote: > (2018/01/25 11:11), Amit Langote wrote: >> Rebased again. > > Thanks for the rebased patch! > > The patches apply cleanly and compile successfully, but make check fails > in an assert-enabled build. Hmm, I can't

Re: list partition constraint shape

Fujita-san, Thanks for the review. On 2018/01/23 20:13, Etsuro Fujita wrote: > (2017/12/13 16:38), Amit Langote wrote: >> Attached patch is an attempt at that.  With the patch, instead of >> internally generating an ANY/ALL expression, generate an OR expression >> instead.  So: >> >> \d+ p1 >>

Re: General purpose hashing func in pgbench

Hello Fabien, On 18.01.2018 12:06, Fabien COELHO wrote: My intention was to introduce seed variable which potentially could be used in different contexts, not only for hash functions. Yes, good point. I'd need it for the pseudo-random permutation function. I renamed it to 'hash_seed' for

Re: non-bulk inserts and tuple routing

(2018/01/25 11:11), Amit Langote wrote: Rebased again. Thanks for the rebased patch! The patches apply cleanly and compile successfully, but make check fails in an assert-enabled build. Best regards, Etsuro Fujita

Re: JIT compiling with LLVM v9.0

On Thursday, January 25, 2018 7:38:16 AM CET Andres Freund wrote: > Hi, > > On 2018-01-24 22:33:30 -0800, Jeff Davis wrote: > > On Wed, Jan 24, 2018 at 1:35 PM, Pierre Ducroquet wrote: > > > In LLVM 5.0, it looks like DebugInfo.h is not available in llvm-c, only > > > as a

Re: Regarding ambulkdelete, amvacuumcleanup index methods

Thanks for your response. Hope those stats will be used by Query Planner. So, just for my understanding, if i don't return stats (returning NULL from index_bulk_delete and index_vacuum_cleanup functions), Query Planner will not consider my Index as part of Query Path, beyond that i don't expect

Re: WIP Patch: Precalculate stable functions, infrastructure v1

Hello! On 24-01-2018 23:36, Andres Freund wrote: On 2018-01-24 15:10:56 -0500, Tom Lane wrote: ... Keeping the stored value of a CachedExpr in a Param slot is an interesting idea indeed. We keep coming back to this, IIRC we had a pretty similar discussion around redesigning

RE: Temporary tables prevent autovacuum, leading to XID wraparound

From: Michael Paquier [mailto:michael.paqu...@gmail.com] > On Thu, Jan 25, 2018 at 08:10:00AM +, Tsunakawa, Takayuki wrote: > > I understood you suggested a new session which recycle the temp schema > > should erase the zombie metadata of old temp tables or recreate the > > temp schema. That

Re: Temporary tables prevent autovacuum, leading to XID wraparound

On Thu, Jan 25, 2018 at 08:10:00AM +, Tsunakawa, Takayuki wrote: >>> * In this incident, autovacuum worker misjudged that >>> pg_temp_3.fetchchunks can't be deleted, although the creator >>> (pg_rewind) is no longer active. How can we delete orphan temporary >>> tables safely? >> >> As long

<    1   2