Hi!
I found prepare statement are not jumbled.
Fro example PREPARE 't1'; and PREPARE 't2' are counted separately in
pg_stat_statements.
I think it needs to be fixed.
What do you think?
Regards,
Kotaro Kawamoto
Hi,
On Wed, Sep 14, 2022 at 05:14:06PM +0900, bt22kawamotok wrote:
>
> I found prepare statement are not jumbled.
> Fro example PREPARE 't1'; and PREPARE 't2' are counted separately in
> pg_stat_statements.
Are you talking about PREPARE TRANSACTION? If yes I already suggested that a
few days
On 2022-Sep-14, Peter Smith wrote:
> PSA a new patch for the "Column Lists" page. AFAIK this is the same as
> everything that you suggested
I don't get it. You send me my patch back, and claim it is a new patch?
I kindly request that when you review a patch, you do not hijack the
submitter's
On Fri, Sep 9, 2022 at 6:18 AM Masahiko Sawada wrote:
>
> Updated the patch accordingly.
>
I have created two xacts each with savepoints and after your patch,
the record will show xacts/subxacts information as below:
rmgr: Standby len (rec/tot): 74/74, tx: 0, lsn:
I still wonder, if assert doesn't catch why that place is marked as
covered here?
https://coverage.postgresql.org/src/backend/access/gin/ginvacuum.c.gcov.html
a.kozhemya...@postgrespro.ru писал 2022-09-12 15:47:
Hi,
The commit 4fb5c794e5 eliminates the ginbulkdelete() test coverage
provided
On Wed, Sep 14, 2022 at 12:16 PM wrote:
>
> I still wonder, if assert doesn't catch why that place is marked as
> covered here?
> https://coverage.postgresql.org/src/backend/access/gin/ginvacuum.c.gcov.html
>
Probably other tests cover that.
Regards,
Amul
> On 13 Sep 2022, at 23:38, Tom Lane wrote:
> The $tempdir is some temporary subdirectory of tmp_check that will get nuked
> at
> the end of the TAP test no matter what. So these rmtrees are merely making
> the
> evidence disappear a bit faster; it will anyway.
Maybe the creation of
+ else if (TailMatches("MERGE", "INTO", MatchAny, "USING") ||
+TailMatches("MERGE", "INTO", MatchAny, MatchAny,
"USING") ||
+TailMatches("MERGE", "INTO", MatchAny, "AS", MatchAny,
"USING"))
2022-09-14 17:18 に Julien Rouhaud さんは書きました:
Hi,
On Wed, Sep 14, 2022 at 05:14:06PM +0900, bt22kawamotok wrote:
I found prepare statement are not jumbled.
Fro example PREPARE 't1'; and PREPARE 't2' are counted separately in
pg_stat_statements.
Are you talking about PREPARE TRANSACTION? If
On Wed, 14 Sep 2022 at 13:52, Tom Lane wrote:
> Japin Li writes:
>> Why should we set s->state to TRANS_START and then TRANS_INPROGRESS?
>
> I believe it's so that if an error gets thrown somewhere in that
> area, we'll recover properly. I'd be the first to say that this
> stuff isn't
On 2022/09/14 14:08, bt22kawamotok wrote:
When I tried to apply this patch, I got the following warning, please fix it.
Other than that, I think everything is fine.
$ git apply fix_tab_completion_merge_v4.patch
fix_tab_completion_merge_v4.patch:38: trailing whitespace.
else if
On Mon, Sep 12, 2022 at 5:09 PM Bharath Rupireddy
wrote:
>
> Please review the attached v3 patch after removing the above macro changes.
I'm attaching the v4 patch that's rebased on to the latest HEAD.
Please consider this for review.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open
I miss UUID, which indexes very strangely, is more and more popular and
people want to search for it.
See: https://www.postgresql.org/docs/current/textsearch-parsers.html
UUID is fairly easy to parse:
The hexadecimal digits are grouped as 32 hexadecimal characters with
four hyphens:
On Wed, Sep 14, 2022 at 7:45 AM Kyotaro Horiguchi
wrote:
>
> I saw the following message recently modified.
>
> > This controls the maximum distance we can read ahead in the WAL to prefetch
> > referenced data blocks.
>
> Maybe the "we" means "PostgreSQL program and you" but I see it
> somewhat
On Wed, Sep 14, 2022 at 12:53 AM Peter Geoghegan wrote:
> This is still only scratching the surface of what is possible with
> dead_items. The visibility map snapshot concept can enable a far more
> sophisticated approach to resource management in vacuumlazy.c. It
> could help us to replace a
On Wed, Sep 14, 2022 at 5:01 PM Ekaterina Kiryanova
wrote:
>
> Hi,
>
> When translating error messages, Alexander Lakhin
> () noticed some inconsistencies so I prepared a
> small patch to fix those.
+1
This one
- errmsg("background worker \"%s\": background worker without shared
memory access
Hi,
When translating error messages, Alexander Lakhin
() noticed some inconsistencies so I prepared a
small patch to fix those.
Please see attached.
--
Ekaterina Kiryanova
Technical Writer
Postgres Professional
the Russian PostgreSQL Companydiff --git
On 2022-Sep-14, John Naylor wrote:
> This one
>
> + errmsg("background worker \"%s\": background workers without shared
> memory access are not supported",
>
> is a grammar error so worth backpatching, but the rest are cosmetic.
>
> Will commit this way unless there are objections.
+1
--
Hi,
> >
> > Oh, I haven't considered inherited tables. That seems right, the
> statistics of the children are not updated when the parent is analyzed.
> >
> >>
> >> Now, the point I was worried about was what if the changes in child
> >> tables (*_part1, *_part2) are much more than in tbl1? In
Hi,
Sorry for noise but I found another bug.
When the 032_apply_delay.pl is modified like following,
the test will be always failed even if my patch is applied.
```
# Disable subscription. worker should die immediately.
-$node_subscriber->safe_psql('postgres',
- "ALTER SUBSCRIPTION tap_sub
+1 for overall idea of load balancing via random host selection.
For the patch itself, I think it is better to use a more precise time
function in libpq_prng_init or call it only once.
Thought it is a special corner case, imagine all the connection attempts at
first second will be seeded with the
=?UTF-8?Q?Przemys=c5=82aw_Sztoch?= writes:
> I miss UUID, which indexes very strangely, is more and more popular and
> people want to search for it.
Really? UUIDs in running text seem like an extremely uncommon
use-case to me. URLs in running text are common nowadays, which is
why the text
Hello!
I was surprised that it is allowed to create clusters/databases where
the default ICU collations do not actually work due to unsupported
encodings:
$ initdb --encoding SQL_ASCII --locale-provider icu --icu-locale en-US
-D data &&
pg_ctl -D data -l logfile start &&
psql -c "SELECT
On 2022/09/05 15:17, Etsuro Fujita wrote:
+1 for that refactoring. Here are a few comments about the 0001 patch:
Thanks for reviewing the patch!
I'm not sure it's a good idea to change the function's name, because
that would make backpatching hard. To avoid that, how about
introducing
In 29f45e29 we added support for executing NOT IN(values) with a
hashtable, however this comment still claims that we only do so for
cases where the ScalarArrayOpExpr's useOr flag is true.
See attached for fix.
Thanks,
James Coleman
v1-0001-Fix-convert_saop_to_hashed_saop-comment.patch
On 2022-Aug-30, Simon Riggs wrote:
> 001_new_isolation_tests_for_subxids.v3.patch
> Adds new test cases to master without adding any new code, specifically
> addressing the two areas of code that are not tested by existing tests.
> This gives us a baseline from which we can do test driven
On 2022-Sep-13, Ranier Vilela wrote:
> Yeah, as per Julien's answer, there is really no memory leak, but just
> unnecessary double execution of pstrdup.
> But for Postgres 15, I believe it's worth avoiding this, because it's
> wasted cycles.
Yeah, this is a merge mistake. Fix applied, thanks.
> On 2 Sep 2022, at 10:00, Michael Paquier wrote:
>
> On Fri, Aug 26, 2022 at 09:51:26AM +0900, Michael Paquier wrote:
>> Fine by me if both you and Daniel want to be more careful with this
>> change. We could always argue about a backpatch later if there is
>> more ask for it, as well.
>
>
Hi hackers,
Recently in one discussion a user complained [1] about
counterintuitive behavior of toast_tuple_target. Here is a quote:
"""
Table size 177.74 GB
Toast table size 12 GB
Indexes size 33.49 GB
This table is composed of small columns "id", "hash", "size", and a
mid~big (2~512kb) jsonb.
Hi hackers,
> 1. Forbid setting toast_tuple_target < TOAST_TUPLE_THRESHOLD
Reading my own email I realized that this of course was stupid. For
sure this is not an option. It's getting late in my timezone, sorry :)
--
Best regards,
Aleksander Alekseev
On Wed, Sep 14, 2022 at 3:18 AM John Naylor
wrote:
> On Wed, Sep 14, 2022 at 12:53 AM Peter Geoghegan wrote:
> > This is still only scratching the surface of what is possible with
> > dead_items. The visibility map snapshot concept can enable a far more
> > sophisticated approach to resource
On 14.09.22 22:03, Nathan Bossart wrote:
On Wed, Sep 14, 2022 at 09:33:46PM +0200, Peter Eisentraut wrote:
Another question on this feature: Currently, if archive_library is set,
archive_command is ignored. I think if both are set, it should be an error.
Compare for example what happens if you
On Wed, Sep 14, 2022 at 04:47:23PM -0400, Tom Lane wrote:
> Peter Eisentraut writes:
>> On 14.09.22 22:03, Nathan Bossart wrote:
>>> I originally did it this way, but changed it based on this feedback [0]. I
>>> have no problem with the general idea, but the recovery_target_* logic does
>>> have
On Thu, 15 Sept 2022 at 04:08, James Coleman wrote:
> In 29f45e29 we added support for executing NOT IN(values) with a
> hashtable, however this comment still claims that we only do so for
> cases where the ScalarArrayOpExpr's useOr flag is true.
>
> See attached for fix.
Thank you. Pushed.
Nathan Bossart writes:
> On Wed, Sep 14, 2022 at 04:47:23PM -0400, Tom Lane wrote:
>> Yeah, the objection there is only to trying to enforce such
>> interrelationships in GUC hooks. In this case it seems to me that
>> we could easily check and complain at the point where we're about
>> to use
On Wed, Sep 14, 2022 at 06:12:09PM -0400, Tom Lane wrote:
> Nathan Bossart writes:
>> On Wed, Sep 14, 2022 at 04:47:23PM -0400, Tom Lane wrote:
>>> Yeah, the objection there is only to trying to enforce such
>>> interrelationships in GUC hooks. In this case it seems to me that
>>> we could
Bharath Rupireddy writes:
> Merged. PSA v8 patch set.
Pushed, thanks.
regards, tom lane
On Wed, Sep 14, 2022 at 09:31:04PM +0200, Peter Eisentraut wrote:
> Here is a patch that addresses this.
My intent was to present archive_command as the built-in archive library,
but I can see how this might cause confusion, so this change seems
reasonable to me.
> +
> +It is important
Jelte Fennema writes:
> [ non-blocking PQcancel ]
I pushed the 0001 patch (libpq_pipeline documentation) with a bit
of further wordsmithing.
As for 0002, I'm not sure that's anywhere near ready. I doubt it's
a great idea to un-deprecate PQrequestCancel with a major change
in its behavior. If
And now with the actual patch attached ... (sorry)
--strk;
On Thu, Sep 15, 2022 at 12:01:04AM +0200, Sandro Santilli wrote:
> I'm attaching an updated version of the patch. This time the patch
> is tested. Nothing changes unless the .control file for the subject
> extension doesn't have a
On 2022-08-17 We 17:12, Israel Barth Rubio wrote:
> Hello Andrew,
>
> Thanks for reviewing this patch
[...]
>
> I am attaching the new patch, containing the above test in the regress
> suite.
>
Thanks, this looks good but there are some things that need attention:
. There needs to be a check
On 09.09.22 19:58, Alvaro Herrera wrote:
There were a lot more problems in that submission than I at first
realized, and I had to rewrite a lot of code in order to fix them. I
have fixed all the user-visible problems I found in this version, and
reviewed the tests results more carefully so I am
On Wed, Sep 14, 2022 at 09:33:46PM +0200, Peter Eisentraut wrote:
> Another question on this feature: Currently, if archive_library is set,
> archive_command is ignored. I think if both are set, it should be an error.
> Compare for example what happens if you set multiple recovery_target_xxx
>
Peter Eisentraut writes:
> On 14.09.22 22:03, Nathan Bossart wrote:
>> I originally did it this way, but changed it based on this feedback [0]. I
>> have no problem with the general idea, but the recovery_target_* logic does
>> have the following note:
>>
>> * XXX this code is broken by design.
I'm attaching an updated version of the patch. This time the patch
is tested. Nothing changes unless the .control file for the subject
extension doesn't have a "wildcard_upgrades = true" statement.
When wildcard upgrades are enabled, a file with a "%" symbol as
the "source" part of the upgrade
On 08.09.22 09:42, Alvaro Herrera wrote:
On 2022-Sep-07, Peter Eisentraut wrote:
A possible drawback is that the intermediate postgres-full.xml file is
10MB, but I guess we're past the point where we are worrying about that
kind of thing.
I think we are, but maybe mark it .PRECIOUS? IIUC
On 07.09.22 09:53, Peter Eisentraut wrote:
On 07.09.22 09:19, Peter Eisentraut wrote:
This could also be combined with the idea of the postgres.sgml.valid
thing you have in the meson patch set.
I'll finish this up and produce a proper patch.
Something like this.
This does make the rules
Hi!
I've noticed this behavior half a year ago during experiments with TOAST,
and
TOAST_TUPLE_THRESHOLD really works NOT the way it is thought to.
I propose something like FORCE_TOAST flag/option as column option (stored
in attoptions), because we already encountered multiple cases where data
Another question on this feature: Currently, if archive_library is set,
archive_command is ignored. I think if both are set, it should be an
error. Compare for example what happens if you set multiple
recovery_target_xxx settings. I don't think silently turning off one
setting by setting
On 14.09.22 07:10, houzj.f...@fujitsu.com wrote:
After applying the patch, we support adding a table with column list along with
the table's schema[1], and it will directly apply the column list in the
logical replication after applying the patch.
[1]--
CREATE PUBLICATION pub FOR TABLE
On 14.09.22 07:25, Michael Paquier wrote:
removed or recycled until they are archived. If WAL archiving cannot keep
up
- with the pace that WAL is generated, or if
archive_command
+ with the pace that WAL is generated, or if
archive_library
fails repeatedly, old WAL files will
Hi hackers,
I just wanted to gently ping to hear what you all think about this patch.
Appreciate any feedback/thougths.
Thanks,
Melih
On Thu, 15 Sept 2022 at 04:04, Aleksander Alekseev
wrote:
> 1. Forbid setting toast_tuple_target < TOAST_TUPLE_THRESHOLD
> 2. Consider using something like RelationGetToastTupleTarget(rel,
> TOAST_TUPLE_THRESHOLD) in heapam.c:2250, heapam.c:3625 and
> rewriteheap.c:636 and modify the
Hi.
According to:
https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-localalloc
"Note The local functions have greater overhead and provide fewer features
than other memory management functions. New applications should use the
heap functions unless documentation states that a
On 2022-09-14 18:12, bt22kawamotok wrote:
I fixed it in v6.
Thanks for updating.
+ COMPLETE_WITH("UPDATE", "DELETE", "DO NOTHING");
"UPDATE" is always followed by "SET", so why not complement it with
"UPDATE SET"?
--
Regards,
--
Shinya Kato
Advanced Computing Technology
On Wed, Sep 14, 2022 at 7:40 PM Alvaro Herrera wrote:
>
> On 2022-Sep-14, Peter Smith wrote:
>
> > PSA a new patch for the "Column Lists" page. AFAIK this is the same as
> > everything that you suggested
>
> I don't get it. You send me my patch back, and claim it is a new patch?
>
> I kindly
On Thursday, September 15, 2022 3:37 AM Peter Eisentraut
wrote:
Hi,
>
> On 14.09.22 07:10, houzj.f...@fujitsu.com wrote:
> > After applying the patch, we support adding a table with column list
> > along with the table's schema[1], and it will directly apply the
> > column list in the logical
On Mon, Sep 12, 2022 at 11:56 AM Bharath Rupireddy
wrote:
>
> Please review the attached v5 patch.
I'm attaching the v6 patch that's rebased on to the latest HEAD.
Please consider this for review.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services:
Andres Freund writes:
> I'm inclined to build the static lib on windows as long as we do it on other
> platforms.
Maybe I spent too much time working for Red Hat, but I'm kind of
unhappy that we build static libraries at all. They are maintenance
hazards and therefore security hazards by
On Mon, Jul 25, 2022 at 6:31 PM Bharath Rupireddy
wrote:
>
> Here's the v6 patch, a much simpler one - no changes to any of the
> existing function APIs. Please see the sample logs at [1]. There's a
> bit of duplicate code in the v6 patch, if the overall approach looks
> okay, I can remove that
On Mon, Sep 12, 2022 at 18:58 PM Kuroda, Hayato/黒田 隼人
wrote:
> Dear Hou-san,
>
> Thank you for updating the patch! Followings are comments for v28-0001.
> I will dig your patch more, but I send partially to keep the activity of the
> thread.
Thanks for your comments.
> ===
> For
On Tues, Sep 13, 2022 at 17:49 PM Amit Kapila wrote:
>
Thanks for your comments.
> On Fri, Sep 9, 2022 at 2:31 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Friday, September 9, 2022 3:02 PM Peter Smith
> wrote:
> > >
> >
> > > 3.
> > >
> > > max_logical_replication_workers (integer)
> > >
On Wed, Sep 13, 2022 at 18:26 PM Amit Kapila wrote:
>
Thanks for your comments.
> On Fri, Sep 9, 2022 at 12:32 PM Peter Smith wrote:
> >
> > 29. src/backend/replication/logical/worker.c - TransactionApplyAction
> >
> > /*
> > * What action to take for the transaction.
> > *
> > *
On Wed, Sep 14, 2022 at 4:34 PM Justin Pryzby wrote:
> On Wed, Sep 14, 2022 at 03:08:06PM +1200, Thomas Munro wrote:
> > On Wed, Sep 14, 2022 at 10:23 AM Thomas Munro
> > wrote:
> > > Given the simplicity of this case, though, I suppose we could
> > > have a little not-very-general
Hi,
On 2022-09-15 01:10:16 -0400, Tom Lane wrote:
> Andres Freund writes:
> > I'm inclined to build the static lib on windows as long as we do it on other
> > platforms.
>
> Maybe I spent too much time working for Red Hat, but I'm kind of
> unhappy that we build static libraries at all.
Yea, I
On Fri, Sep 9, 2022 at 15:02 PM Peter Smith wrote:
> Here are my review comments for the v28-0001 patch:
>
> (There may be some overlap with other people's review comments and/or
> some fixes already made).
Thanks for your comments.
> 5. src/backend/libpq/pqmq.c
>
> + {
> + if
On Thur, Sep 8, 2022 at 19:25 PM Amit Kapila wrote:
> On Thu, Sep 8, 2022 at 12:21 PM Amit Kapila wrote:
> >
> > On Mon, Sep 5, 2022 at 6:34 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > Attach the correct patch set this time.
> > >
> >
> > Few comments on v28-0001*:
> >
On Tues, Sep 13, 2022 at 20:02 PM Kuroda, Hayato/黒田 隼人
wrote:
> Dear Hou-san,
>
> > I will dig your patch more, but I send partially to keep the activity of
> > the thread.
>
> More minor comments about v28.
Thanks for your comments.
> ===
> About 0002
>
> For 015_stream.pl
>
> 14.
68 matches
Mail list logo
