On 2022-Dec-06, Andres Freund wrote:
> Hi,
>
> On 2022-11-25 02:45:01 +0500, Hamid Akhtar wrote:
> > Rebasing the patch to the tip of the master branch.
>
> This doesn't pass tests on cfbot. Looks like possibly some files are missing?
The .sql file is there all right, but meson.build is not alt
Hello!
On 06.12.2022 21:44, Andres Freund wrote:
Hi,
On 2022-09-19 01:29:21 +0300, Anton A. Melnikov wrote:
Corrected patch is attached (v2-0001-Fix-burst-checkpoint_req-growth.patch).
This patch doesn't pass the main regression tests tests successfully:
https://cirrus-ci.com/task/550270001
On Wed, Dec 7, 2022 at 4:01 PM Amit Langote wrote:
> On Wed, Dec 7, 2022 at 12:19 AM Alvaro Herrera
> wrote:
> > I have pushed this finally.
>>
> > I'll mark this commitfest entry as committed soon; please post the other
> > two patches you had in this series in a new thread.
>
> Will do, thanks
Hi,
vignesh C , 6 Ara 2022 Sal, 22:12 tarihinde şunu yazdı:
> I did not make it as a macro for alter function options as it is used
> only in one place whereas the others were required in more than one
> place.
>
Okay, makes sense.
I tested the patch and it worked for me.
Best,
--
Melih Mutlu
On Tue, Dec 6, 2022 at 4:57 AM David G. Johnston
wrote:
...
>
>
> I'm referring to the query:
>
> select any_value(v order by v) from (values (2),(1),(3)) as vals (v);
> // produces 1, per the documented implementation-defined behavior.
>
> Someone writing:
>
> select any_value(v) from (values (2)
Hi,
Hi,
Please find attached a new patch series:
v27-0001-Add-info-in-WAL-records-in-preparation-for-logic.patch
v27-0002-Handle-logical-slot-conflicts-on-standby.patch
v27-0003-Allow-logical-decoding-on-standby.patch
v27-0004-New-TAP-test-for-logical-decoding-on-standby.patch
v27-0005-Doc-chan
Per Alvaro's advice, forking this from [1].
In light of my proposed changes to decouple permission checking from
the range table on that thread (now committed as a61b1f7482), I had
also been posting a patch there to rethink commands/view.c's
editorializing of a view rule action query' range table
On Wed, Dec 7, 2022 at 6:42 PM Amit Langote wrote:
> Per Alvaro's advice, forking this from [1].
Forgot to add Alvaro.
> In light of my proposed changes to decouple permission checking from
> the range table on that thread (now committed as a61b1f7482), I had
> also been posting a patch there to
On Wed, 7 Dec 2022 at 13:01, Alvaro Herrera wrote:
> On 2022-Dec-06, Andres Freund wrote:
>
> > Hi,
> >
> > On 2022-11-25 02:45:01 +0500, Hamid Akhtar wrote:
> > > Rebasing the patch to the tip of the master branch.
> >
> > This doesn't pass tests on cfbot. Looks like possibly some files are
> mi
On 2022-Dec-06, Alvaro Herrera wrote:
> I have pushed this finally.
>
> I made two further changes:
Actually, I made one further change that I forgot to mention -- I
changed the API of CombineRangeTables once again; the committed patch
has it this way:
+/*
+ * CombineRangeTables
+ * Add
On Wed, Dec 7, 2022 at 8:28 AM houzj.f...@fujitsu.com
wrote:
>
> Besides, I fixed a bug where there could still be messages left in memory
> queue and the PA has started to apply spooled message.
>
Few comments on the recent changes in the patch:
1. It see
On Wed, Dec 7, 2022 at 7:43 PM Alvaro Herrera wrote:
> On 2022-Dec-06, Alvaro Herrera wrote:
> > I have pushed this finally.
> >
> > I made two further changes:
>
> Actually, I made one further change that I forgot to mention -- I
> changed the API of CombineRangeTables once again; the committed p
Hi,
> Actually, that's not quite right. The sync worker will wake up the apply
> worker to change the state from SYNCDONE to READY. AllTablesyncsReady()
> checks that all tables are READY, so we need to wake up all the workers
> when an apply worker changes the state to READY. Each worker will
Hi Damir!
Your work looks like a very promising feature for production systems,
where data often needs to be loaded from external sources.
I've looked over the discussion and want to make a proposal -
when we load a bunch of records in database it does not make sense
to output errors to command o
On Tue, 2022-12-06 at 10:17 -0800, Andres Freund wrote:
> On 2022-10-29 10:35:26 +0200, Laurenz Albe wrote:
> > > > Here is a patch that
> > > > implements it with an EXPLAIN option named GENERIC_PLAN.
>
> This fails to build the docs:
>
> https://cirrus-ci.com/task/5609301511766016
>
> [17:47:0
On 2022-Dec-07, Amit Langote wrote:
> While doing that, I noticed that I had missed updating at least one
> comment which still says that permission checking is done off of the
> range table. Attached patch fixes that.
Pushed, thanks.
--
Álvaro HerreraBreisgau, Deutschland — https://
On Mon, Dec 5, 2022 at 1:29 PM houzj.f...@fujitsu.com
wrote:
>
> On Sunday, December 4, 2022 7:17 PM houzj.f...@fujitsu.com
>
> >
> > Thursday, December 1, 2022 8:40 PM Amit Kapila
> > wrote:
> > > Some other comments:
> > ...
> > Attach the new version patch set which addressed most of the com
Per Alvaro's advice, forking this from [1].
In that thread, Tom had asked if it wouldn't be better to find a new
place to put extraUpdatedCols [2] instead of RangeTblEntry, along with
the permission-checking fields are now no longer stored in
RangeTblEntry.
In [3] of the same thread, I proposed t
Hi all!
PG by default always creates the primary key in the default tablespace
unless you specify it to use an index that is defined in a user-defined
tablespace.
We can create indexes in user-defined tablespaces, why can't we create
a primary key in a user-defined tablespace without having
On Wed, Dec 7, 2022 at 8:54 PM Amit Langote wrote:
> Per Alvaro's advice, forking this from [1].
>
> In that thread, Tom had asked if it wouldn't be better to find a new
> place to put extraUpdatedCols [2] instead of RangeTblEntry, along with
> the permission-checking fields are now no longer stor
I think this patch is split badly.
You have:
0001 an enormous patch including some required infrastructure, plus the
DDL deparsing bits themselves.
0002 another enormous (though not as much) patch, this time for
DDL replication using the above.
0003 a bugfix for 0001, which includes changes in
On Wed, Dec 7, 2022 at 4:31 PM Amit Kapila wrote:
>
> On Wed, Dec 7, 2022 at 10:10 AM Masahiko Sawada wrote:
> >
> > On Wed, Dec 7, 2022 at 1:29 PM Amit Kapila wrote:
> > >
> > > Right, but the leader will anyway exit at some point either due to an
> > > ERROR like "lost connection ... to parall
On Wednesday, December 7, 2022 7:51 PM Masahiko Sawada
wrote:
>
> On Mon, Dec 5, 2022 at 1:29 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Sunday, December 4, 2022 7:17 PM houzj.f...@fujitsu.com
>
> > >
> > > Thursday, December 1, 2022 8:40 PM Amit Kapila
>
> > > wrote:
> > > > Some other co
On Wednesday, December 7, 2022 7:51 PM Masahiko Sawada
wrote:
>
> On Mon, Dec 5, 2022 at 1:29 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Sunday, December 4, 2022 7:17 PM houzj.f...@fujitsu.com
>
> > >
> > > Thursday, December 1, 2022 8:40 PM Amit Kapila
>
> > > wrote:
> > > > Some other co
On Wed, Dec 7, 2022 at 1:28 AM Pavel Borisov wrote:
> On Tue, 6 Dec 2022 at 19:01, Alexander Korotkov wrote:
> >
> > On Mon, Dec 5, 2022 at 10:32 PM Alexander Korotkov
> > wrote:
> > > On Mon, Dec 5, 2022 at 8:18 PM Tom Lane wrote:
> > > > Alvaro Herrera writes:
> > > > > I couldn't find any
On Wed, Dec 7, 2022 at 1:58 AM Pantelis Theodosiou
wrote:
> On Tue, Dec 6, 2022 at 4:57 AM David G. Johnston
> wrote:
> ...
> >
> >
> > I'm referring to the query:
> >
> > select any_value(v order by v) from (values (2),(1),(3)) as vals (v);
> > // produces 1, per the documented implementation-d
On 2022-12-06 Tu 15:21, Tom Lane wrote:
> OK, here's a v3 responding to the comments from Andres.
Looks pretty good to me.
>
> is preliminary refactoring of elog.c, with (I trust) no
> functional effect. It gets rid of some pre-existing code duplication
> as well as setting up to let 00
On 13.10.22 12:26, Peter Eisentraut wrote:
I think that the other md5() computations done in the main regression
test suite could just be switched to use one of the sha*() functions
as they just want to put their hands on text values. It looks like a
few of them have some expections with the out
Andrew Dunstan writes:
> Perhaps we should add a type in the regress library that will never have
> a safe input function, so we can test that the mechanism works as
> expected in that case even after we adjust all the core data types'
> input functions.
I was intending that the existing "widget"
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Looks good to me
The new status of this patch is: Ready for Comm
On Wed, Dec 7, 2022 at 7:20 AM Tom Lane wrote:
>
> Returning to the naming quagmire -- it occurred to me just now that
> it might be helpful to call this style of error reporting "soft"
> errors rather than "safe" errors, which'd provide a nice contrast
> with "hard" errors thrown by longjmp'ing.
On 2022-12-07 We 09:20, Tom Lane wrote:
> Andrew Dunstan writes:
>> Perhaps we should add a type in the regress library that will never have
>> a safe input function, so we can test that the mechanism works as
>> expected in that case even after we adjust all the core data types'
>> input functi
Hi hackers,
A colleague of mine reported a slight inconvenience with pg_dump.
He is dumping the data from a remote server. There are several
thousands of tables in the database. Making a dump locally and/or
using pg_basebackup and/or logical replication is not an option. So
what pg_dump currently
Andrew Dunstan writes:
> On 2022-12-07 We 09:20, Tom Lane wrote:
>> Returning to the naming quagmire -- it occurred to me just now that
>> it might be helpful to call this style of error reporting "soft"
>> errors rather than "safe" errors, which'd provide a nice contrast
>> with "hard" errors thr
On Wed, Dec 7, 2022 at 12:09 PM Aleksander Alekseev <
aleksan...@timescale.com> wrote:
>
> Hi hackers,
>
> A colleague of mine reported a slight inconvenience with pg_dump.
>
> He is dumping the data from a remote server. There are several
> thousands of tables in the database. Making a dump locall
On Wed, Dec 7, 2022 at 8:04 AM Andrew Dunstan wrote:
>
> On 2022-12-07 We 09:20, Tom Lane wrote:
> > Andrew Dunstan writes:
> >> Perhaps we should add a type in the regress library that will never have
> >> a safe input function, so we can test that the mechanism works as
> >> expected in that c
Aleksander Alekseev writes:
> What he proposes is taking the locks in batches.
I have a strong sense of deja vu here. I'm pretty sure I experimented
with this idea last year and gave up on it. I don't recall exactly
why, but either it didn't show any meaningful performance improvement
for me or
On Wed, Dec 7, 2022 at 8:23 AM Tom Lane wrote:
> Andrew Dunstan writes:
> > On 2022-12-07 We 09:20, Tom Lane wrote:
> >> Returning to the naming quagmire -- it occurred to me just now that
> >> it might be helpful to call this style of error reporting "soft"
> >> errors rather than "safe" errors
"David G. Johnston" writes:
> Why not do away with two separate functions and define a composite type
> (boolean, text) for is_valid to return?
I don't see any advantage to that. It would be harder to use in both
use-cases.
>> BTW, does anyone else agree that 9.26 is desperately in need of some
On 03.12.22 05:59, Ian Lawrence Barwick wrote:
2022年12月3日(土) 7:19 Paul Jungwirth :
I noticed a few places in the new foreign key code where a comment says
"the ON DELETE SET NULL/DELETE clause". I believe it should say "ON
DELETE SET NULL/DEFAULT".
These comments were added in d6f96ed94e7, "All
On Wed, Dec 7, 2022 at 9:06 AM Tom Lane wrote:
> "David G. Johnston" writes:
> > Why not do away with two separate functions and define a composite type
> > (boolean, text) for is_valid to return?
>
> I don't see any advantage to that. It would be harder to use in both
> use-cases.
>
I don't r
On Tue, Dec 6, 2022 at 7:57 PM David G. Johnston
wrote:
> On Tue, Dec 6, 2022 at 6:36 PM Peter Smith wrote:
>
>> I'd like to "fix" this but IIUC there is no consensus yet about what
>> order is best for patch 0001, right?
>>
>>
> I'm planning on performing a more thorough review of 0003 and 0004
On 02.12.22 01:56, Kyotaro Horiguchi wrote:
also thought about something like a "mode" option with an argument,
but given that we already have --link and --clone, this seemed the
most sensible.)
Thoughts?
When I read up to the point of the --copy option, what came to my mind
was the --mode= op
On 02.12.22 13:04, Daniel Gustafsson wrote:
Wouldn't it be possible, and less change-code-manual, to accept this via an
extension to PROVE_FLAGS? Any options after :: to prove are passed to the
test(s) [0] so we could perhaps inspect @ARGV for the mode if we invent a new
way to pass arguments.
"David G. Johnston" writes:
> On Wed, Dec 7, 2022 at 9:06 AM Tom Lane wrote:
>> "David G. Johnston" writes:
>>> Why not do away with two separate functions and define a composite type
>>> (boolean, text) for is_valid to return?
>> I don't see any advantage to that. It would be harder to use in
On Wed, Dec 7, 2022 at 9:20 AM Tom Lane wrote:
> Andrew Dunstan writes:
> > Perhaps we should add a type in the regress library that will never have
> > a safe input function, so we can test that the mechanism works as
> > expected in that case even after we adjust all the core data types'
> > i
On Wed, Dec 7, 2022 at 9:59 AM Tom Lane wrote:
> "David G. Johnston" writes:
>
> > Are you suggesting we should not go down the path that v8-0003 does in
> the
> > monitoring section cleanup thread? I find the usability of Chapter 54
> > System Views to be superior to these two run-on chapters
Hi,
On 2022-12-07 10:44:33 -0500, Tom Lane wrote:
> Aleksander Alekseev writes:
> > What he proposes is taking the locks in batches.
>
> I have a strong sense of deja vu here. I'm pretty sure I experimented
> with this idea last year and gave up on it. I don't recall exactly
> why, but either
On 2022-12-07 09:20:33 -0500, Tom Lane wrote:
> Returning to the naming quagmire -- it occurred to me just now that
> it might be helpful to call this style of error reporting "soft"
> errors rather than "safe" errors, which'd provide a nice contrast
> with "hard" errors thrown by longjmp'ing.
+1
Corey Huinker writes:
> In my attempt to implement CAST...DEFAULT, I noticed that I immediately
> needed an
> OidInputFunctionCallSafe, which was trivial but maybe something we want to
> add to the infra patch, but the comments around that function also somewhat
> indicate that we might want to ju
"David G. Johnston" writes:
> So long as you aren't opposed to the idea if someone else does the work,
> adding sect2 is better than nothing even if it is just a stop-gap measure.
OK, we can agree on that.
As for the other point --- not sure why I didn't remember this right off,
but the point o
Andres Freund writes:
> On 2022-12-07 10:44:33 -0500, Tom Lane wrote:
>> I have a strong sense of deja vu here. I'm pretty sure I experimented
>> with this idea last year and gave up on it. I don't recall exactly
>> why, but either it didn't show any meaningful performance improvement
>> for me
Hi,
On 2022-12-06 15:21:09 -0500, Tom Lane wrote:
> +{ oid => '8050', descr => 'test whether string is valid input for data type',
> + proname => 'pg_input_is_valid', provolatile => 's', prorettype => 'bool',
> + proargtypes => 'text regtype', prosrc => 'pg_input_is_valid' },
> +{ oid => '8051',
Hi,
On 2022-12-07 12:28:03 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2022-12-07 10:44:33 -0500, Tom Lane wrote:
> >> I have a strong sense of deja vu here. I'm pretty sure I experimented
> >> with this idea last year and gave up on it. I don't recall exactly
> >> why, but either it
On Wed, Dec 7, 2022 at 10:34 AM Andres Freund wrote:
> > +{ oid => '8053',
> > + descr => 'get error message if string is not valid input for data
> type',
> > + proname => 'pg_input_invalid_message', provolatile => 's',
> > + prorettype => 'text', proargtypes => 'text regtype int4',
> > + pr
Hi,
On 2022-12-07 11:40:08 +0300, Aleksander Alekseev wrote:
> Hi Michael,
>
> > The CF bot is showing some failures here. You may want to
> > double-check.
>
> Thanks! PFA v48.
This causes a lot of failures with ubsan:
https://cirrus-ci.com/task/6035600772431872
performing post-bootstrap init
Andres Freund writes:
> Is there a guarantee that input functions are stable or immutable?
There's a project policy that that should be true. That justifies
marking things like record_in as stable --- if the per-column input
functions could be volatile, record_in would need to be as well.
There
On Wed, Dec 7, 2022 at 9:50 AM Andres Freund wrote:
> performing post-bootstrap initialization ...
> ../src/backend/access/transam/slru.c:1520:9: runtime error: load of
> misaligned address 0x7fff6362db8c for type 'int64', which requires 8 byte
> alignment
> 0x7fff6362db8c: note: pointer points
Hi,
On 2022-12-07 10:00:25 +0100, Drouvot, Bertrand wrote:
> > Please find attached a new patch series:
> >
> > v27-0001-Add-info-in-WAL-records-in-preparation-for-logic.patch
> > v27-0002-Handle-logical-slot-conflicts-on-standby.patch
> > v27-0003-Allow-logical-decoding-on-standby.patch
> > v27-
I wrote:
> Andres Freund writes:
>> Is there a guarantee that input functions are stable or immutable?
> There's a project policy that that should be true. That justifies
> marking things like record_in as stable --- if the per-column input
> functions could be volatile, record_in would need to
Hi,
On 2022-11-16 17:52:50 +0300, Anton A. Melnikov wrote:
> Sorry, i didn't fully understand what is required and
> added some functions to the test that spend extra cpu time. But i found
> that it is possible to make a test according to previous remarks by adding
> only a few extra queries to an
On Wed, Dec 07, 2022 at 02:07:11PM +0300, Melih Mutlu wrote:
> Do we also need to wake up all sync workers too? Even if not, I'm not
> actually sure whether doing that would harm anything though.
> Just asking since currently the patch wakes up all workers including sync
> workers if any still exis
Hi,
On 2022-12-03 09:41:04 -0800, Andrey Borodin wrote:
> Fixed. Added test for this.
The tests don't pass: https://cirrus-ci.com/build/4811553145356288
[00:54:35.337](1.251s) not ok 1 - no parameters missing from
postgresql.conf.sample
[00:54:35.338](0.000s) # Failed test 'no parameters miss
Hi,
On 2022-02-03 15:27:32 +0100, Dag Lem wrote:
> Just some minor adjustments to the patch:
>
> * Removed call to locale-dependent toupper()
> * Cleaned up input normalization
This patch currently fails in cfbot, likely because meson.build needs to be
adjusted (this didn't exist at the time you
Hi,
On 2022-12-05 02:03:49 +, fujii.y...@df.mitsubishielectric.co.jp wrote:
> > Attaching minor fixes. I haven't proof-read all comments (but perhaps, they
> > need attention from some native speaker).
> Thank you. I fixed according to your patch.
> And I fixed have proof-read all comments and
Hi,
On 2022-11-04 09:25:52 +0100, Drouvot, Bertrand wrote:
> Please find attached a rebase in v7.
cfbot complains that the docs don't build:
https://cirrus-ci.com/task/6694349031866368?logs=docs_build#L296
[03:24:27.317] ref/checkpoint.sgml:66: element para: validity error : Element
para is not
On Mon, Dec 5, 2022 at 4:15 PM Andrey Chudnovsky wrote:
> I think we can focus on the roles and responsibilities of the components
> first.
> Details of the patch can be elaborated. Like "flow type code" is a
> mistake on our side, and we will use the term "grant_type" which is
> defined by OIDC
Hi All,
I am trying to create HeapTuple data structure.
First, I create a tuple descriptor:
TupleDesc *td=CreateTemplateTupleDesc(colCount);
Then, for each variable, I do:
TupleDescInitEntry(*td,v->varattno,NULL,v->vartype,v->vartypmod,0);
Then, I assign values:
if int32: values[v
Hi all!
This adds tab-complete for optional parameters (as can be specified
using WITH) for views, similarly to how it works for storage parameters
of tables.
Thanks,
Christoph HeissFrom bd12c08a80b5973fdcac59def213216d06f150b0 Mon Sep 17 00:00:00 2001
From: Christoph Heiss
Date: Wed, 7 Dec
"David G. Johnston" writes:
> On Wed, Dec 7, 2022 at 8:04 AM Andrew Dunstan wrote:
>> I'm not sure InputFunctionCallSoft would be an improvement. Maybe
>> InputFunctionCallSoftError would be clearer, but I don't know that it's
>> much of an improvement either. The same goes for the other visible
On Wed, Dec 7, 2022 at 2:28 PM Tom Lane wrote:
>
> Andres Freund writes:
> > On 2022-12-07 10:44:33 -0500, Tom Lane wrote:
> >> I have a strong sense of deja vu here. I'm pretty sure I experimented
> >> with this idea last year and gave up on it. I don't recall exactly
> >> why, but either it d
On Wed, Dec 7, 2022 at 10:23 AM Andres Freund wrote:
>
> On 2022-12-03 09:41:04 -0800, Andrey Borodin wrote:
> > Fixed. Added test for this.
>
> The tests don't pass: https://cirrus-ci.com/build/4811553145356288
>
oops, sorry. Here's the fix. I hope to address other feedback on the
weekend. Thank
Hi,
On 2022-12-07 18:14:01 -0300, Fabrízio de Royes Mello wrote:
> Here we have some numbers about the Aleksander's patch:
Hm. Were they taken in an assertion enabled build or such? Just testing the
t1 case on HEAD, I get 0:01.23 elapsed for an unpatched pg_dump in an
optimized build. And tha
On Thu, 1 Dec 2022 at 14:18, Andres Freund wrote:
>
> I find it problematic that ResetVacStats() bypasses tableam. Normal vacuums
> etc go through tableam but you put a ResetVacStats() besides each call to
> table_relation_nontransactional_truncate(). Seems like this should just be in
> heapam_re
OK, here's a v4 that I think is possibly committable.
I've changed all the comments and docs to use the "soft error"
terminology, but since using "soft" in the actual function names
didn't seem that appealing, they still use "safe".
I already pushed the elog-refactoring patch, since that see
Hi hackers,
While looking into other opportunities for per-table permissions, I noticed
a weird discrepancy in CLUSTER. When evaluating whether the current user
has permission to CLUSTER a table, we ordinarily just check for ownership.
However, the database owner is also allowed to CLUSTER all pa
On Wed, Dec 07, 2022 at 10:48:49AM +0300, Pavel Luzanov wrote:
> There is a very similar command to VACUUM FULL with a different name -
> CLUSTER.
> The VACUUM privilege does not apply to the CLUSTER command. This is probably
> correct.
> However, the documentation for the CLUSTER command does not
Hi,
On 2022-12-07 13:32:42 -0800, Andres Freund wrote:
> On 2022-12-07 18:14:01 -0300, Fabrízio de Royes Mello wrote:
> > Here we have some numbers about the Aleksander's patch:
>
> Hm. Were they taken in an assertion enabled build or such? Just testing the
> t1 case on HEAD, I get 0:01.23 el
On 2022-12-07 We 17:32, Tom Lane wrote:
> OK, here's a v4 that I think is possibly committable.
>
> I've changed all the comments and docs to use the "soft error"
> terminology, but since using "soft" in the actual function names
> didn't seem that appealing, they still use "safe".
>
> I already
Andres Freund writes:
> With an artificial delay of 100ms, the perf difference between the batching
> patch and not using the batching patch is huge. Huge enough that I don't have
> the patience to wait for the non-batched case to complete.
Clearly, if you insert a sufficiently large artificial r
Andrew Dunstan writes:
> On 2022-12-07 We 17:32, Tom Lane wrote:
>> Does it make sense to break 0003 into 4 separate commits, or is
>> that overkill?)
> No strong opinion about 0001 and 0002. I'm happy enough with them as
> they are, but if you want to squash them that's ok. I wouldn't break up
>
On Wed, Dec 7, 2022 at 2:53 PM Tom Lane wrote:
> Is "-s" mode actually a relevant criterion here? With per-table COPY
> commands added into the mix you could not possibly get better than 2x
> improvement, and likely a good deal less.
Don't we hit this code path in pg_upgrade? You won't see huge
> I think it's okay to have the extension and HBA collaborate to provide
> discovery information. Your proposal goes further than that, though,
> and makes the server aware of the chosen client flow. That appears to
> be an architectural violation: why does an OAuth resource server need
> to know t
Hi,
On 2022-12-07 17:32:21 -0500, Tom Lane wrote:
> I already pushed the elog-refactoring patch, since that seemed
> uncontroversial. 0001 attached covers the same territory as before,
> but I regrouped the rest so that 0002 installs the new test support
> functions, then 0003 adds both the
Hi,
On 2022-12-07 17:53:05 -0500, Tom Lane wrote:
> Andres Freund writes:
> > With an artificial delay of 100ms, the perf difference between the batching
> > patch and not using the batching patch is huge. Huge enough that I don't
> > have
> > the patience to wait for the non-batched case to com
Hi,
On Tue, Dec 6, 2022 at 11:12 PM Peter Smith wrote:
> On Tue, Dec 6, 2022 at 5:57 AM samay sharma
> wrote:
> >
> > Hi,
> >
> > On Mon, Oct 24, 2022 at 12:45 AM Peter Smith
> wrote:
> >>
> >> Hi hackers.
> >>
> >> There is a docs Logical Replication section "31.10 Configuration
> >> Settings
Andres Freund writes:
> I wonder if there are potential use-cases for levels other than ERROR. I can
> potentially see us wanting to defer some FATALs, e.g. when they occur in
> process exit hooks.
I thought about that early on, and concluded not. The whole thing is
moot for levels less than ERR
Andres Freund writes:
> On 2022-12-07 17:53:05 -0500, Tom Lane wrote:
>> Is "-s" mode actually a relevant criterion here? With per-table COPY
>> commands added into the mix you could not possibly get better than 2x
>> improvement, and likely a good deal less.
> Well, -s isn't something used all
On Wed, Dec 07, 2022 at 02:39:24PM -0800, Nathan Bossart wrote:
> Hi hackers,
>
> While looking into other opportunities for per-table permissions, I noticed
> a weird discrepancy in CLUSTER. When evaluating whether the current user
> has permission to CLUSTER a table, we ordinarily just check fo
Thanks for the ongoing feedback.
PSA patches for v9*
v9-0001 - Now the table rows are ordered per PeterE's suggestions [1]
v9-0002 - All the review comments from DavidJ [2] are addressed
v9-0003 - Unchanged since v8.
--
[1]
https://www.postgresql.org/message-id/cfdb0030-8f62-ed6d-4246-8d9
On Wed, Dec 07, 2022 at 10:48:49AM +0300, Pavel Luzanov wrote:
> Furthermore. The VACUUM privilege allows you to also execute VACUUM FULL.
> VACUUM and VACUUM FULL are commands with similar names, but work completely
> differently.
> It may be worth clarifying on this page:
> https://www.postgresql
On Mon, Nov 21, 2022 at 4:31 PM Amit Kapila wrote:
>
> On Sat, Nov 19, 2022 at 6:35 AM Andres Freund wrote:
> >
> > On 2022-11-18 11:20:36 +0530, Amit Kapila wrote:
> > > Okay, updated the patch accordingly.
> >
> > Assuming it passes tests etc, this'd work for me.
> >
>
> Thanks, Pushed.
The sa
On Wed, Dec 7, 2022 at 8:54 PM Amit Langote wrote:
> Per Alvaro's advice, forking this from [1].
>
> In that thread, Tom had asked if it wouldn't be better to find a new
> place to put extraUpdatedCols [2] instead of RangeTblEntry, along with
> the permission-checking fields are now no longer stor
On Wed, Dec 7, 2022 at 12:17 PM Tom Lane wrote:
> Corey Huinker writes:
> > In my attempt to implement CAST...DEFAULT, I noticed that I immediately
> > needed an
> > OidInputFunctionCallSafe, which was trivial but maybe something we want
> to
> > add to the infra patch, but the comments around t
Hi,
On 2022-11-09 12:25:09 -0800, Andres Freund wrote:
> Updated patch attached.
I pushed it now.
> I made one autoconf and one meson CI task use a small block size, but just to
> ensure it work on both. I'd probably leave it set on one, so we keep the
> coverage for cfbot?
It doesn't seem to
On Wed, Dec 07, 2022 at 08:25:59PM -0600, Justin Pryzby wrote:
> Your patch makes it inconsistent with vacuum full, which is strange
> because vacuum full calls cluster.
>
> postgres=> VACUUM FULL t;
> VACUUM
> postgres=> CLUSTER t;
> ERROR: must be owner of table t
This is the existing behavior
On Wed, Dec 07, 2022 at 08:39:30PM -0600, Justin Pryzby wrote:
> I think if vacuum privilege allows vacuum full, then it ought to also
> allow cluster. But I suggest that it'd be even better if it doesn't
> allow either, and there was a separate privilege for those.
>
> Disclaimer: I have not bee
That being said, the Diagram 2 would look like this with our proposal:
+--+ +--+
| +---+ | Postgres |
| PQconnect ->| | |
Nathan Bossart writes:
> I haven't formed an opinion on whether VACUUM FULL should get its own bit,
> but FWIW І just finished writing the first draft of a patch set to add bits
> for CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX. I plan to post that
> tomorrow.
The fact that we just doubled t
On Wed, Dec 07, 2022 at 11:25:32PM -0500, Tom Lane wrote:
> The fact that we just doubled the number of available bits doesn't
> mean we should immediately strive to use them up. Perhaps it'd
> be better to subsume these retail privileges under some generic
> "maintenance action" privilege?
That'
1 - 100 of 117 matches
Mail list logo
