Re: SerializeParamList vs machines with strict alignment

2018-09-09 Thread Amit Kapila
On Mon, Sep 10, 2018 at 8:58 AM Tom Lane wrote: > > I wondered why buildfarm member chipmunk has been failing hard > for the last little while. Fortunately, it's supplying us with > a handy backtrace: > > Program terminated with signal 7, Bus error. > #0 EA_flatten_into (allocated_size=, result=

Re: stat() on Windows might cause error if target file is larger than 4GB

2018-09-09 Thread Michael Paquier
On Mon, Sep 10, 2018 at 02:01:53AM +, Higuchi, Daisuke wrote: > This mail is about following bug report post: > https://www.postgresql.org/message-id/flat/153442391458.1505.9181095584291689853%40wrigleys.postgresql.org Thanks for following up on this thread. I marked that as one of my TODOs

Re: How to find local logical replication origin?

2018-09-09 Thread Michael Paquier
On Sat, Sep 08, 2018 at 05:41:06PM +0800, Jinhua Luo wrote: > What's the local logical replication origin, which could be used to > filter local changes in the replication slot? You are looking for that perhaps? https://www.postgresql.org/docs/devel/static/replication-origins.html After that ther

Re: Problem while setting the fpw with SIGHUP

2018-09-09 Thread Amit Kapila
On Tue, Aug 28, 2018 at 4:05 PM Kyotaro HORIGUCHI wrote: > > Hello. > > At Sat, 25 Aug 2018 14:50:53 +0530, Amit Kapila > wrote in > > On Wed, Aug 1, 2018 at 12:56 PM Kyotaro HORIGUCHI > > wrote: > > > > > > Thank you, Amit, Michael. > > > > > > > Can you verify the first patch that I have pos

Re: Add extension options to control TAP and isolation tests

2018-09-09 Thread Michael Paquier
On Wed, Sep 05, 2018 at 06:48:49PM -0700, Michael Paquier wrote: > On a recent thread of pgsql-committers has been discussed the fact that > we lacked a bit of infrastructure to allow extensions to control > isolation and TAP tests: > https://www.postgresql.org/message-id/20180905174527.ga2...@paqu

Re: executor relation handling

2018-09-09 Thread David Rowley
On 4 September 2018 at 20:53, Amit Langote wrote: > Updated patches attached; 0001-0003 are same as v1. I've looked at these. Here's my review so far: 0001: 1. The following does not seem to be true any longer: + /* + * If you change the conditions under which rel locks are acquired + * here,

Re: How to find local logical replication origin?

2018-09-09 Thread Jinhua Luo
Because I found in the source codes that if not explicitly set (e.g. via pg_replication_origin_session_setup), the replorigin_session_origin included in the wal is InvalidRepOriginId, correct? Jinhua Luo 于2018年9月9日周日 下午10:16写道: > > Could I assume all local originated changes is with InvalidRepOrig

SerializeParamList vs machines with strict alignment

2018-09-09 Thread Tom Lane
I wondered why buildfarm member chipmunk has been failing hard for the last little while. Fortunately, it's supplying us with a handy backtrace: Program terminated with signal 7, Bus error. #0 EA_flatten_into (allocated_size=, result=0xb55ff30e, eohptr=0x188f440) at array_expanded.c:329 329

stat() on Windows might cause error if target file is larger than 4GB

2018-09-09 Thread Higuchi, Daisuke
Hi, This mail is about following bug report post: https://www.postgresql.org/message-id/flat/153442391458.1505.9181095584291689853%40wrigleys.postgresql.org When pg_dump has '--format=directory' option and the dump file size become 4GB over, the strange error message 'Unknown error' will be ou

Re: pgbench - add pseudo-random permutation function

2018-09-09 Thread Hironobu SUZUKI
Hi Fabian, I reviewed `pgbench-prp-func-1.patch` and found an incomplete implementation. In the pseudorandom_perm function, I confirmed that the scramble and scatter operations are mathematically bijections. Therefore, this function is mathematically correct. However, the implementation o

Re: [HACKERS] PATCH: multivariate histograms and MCV lists

2018-09-09 Thread Tomas Vondra
Hi, On 09/04/2018 04:16 PM, Dean Rasheed wrote: > On 3 September 2018 at 00:17, Tomas Vondra > wrote: >> Hi, >> >> Attached is an updated version of the patch series, adopting a couple of >> improvements - both for MCV lists and histograms. >> >> >> MCV >> --- >> >> For the MCV list part, I've a

Re: Bug in ginRedoRecompress that causes opaque data on page to be overrun

2018-09-09 Thread Alexander Korotkov
On Thu, Sep 6, 2018 at 9:02 PM R, Siva wrote: > I'm also running into this assert with the workload, I think my patch is > not handling the case where the action is add items on the last segment > of the page correctly. I'm still investigating the issue further to find > the > source of the bug.

Re: [HACKERS] Bug in to_timestamp().

2018-09-09 Thread Alexander Korotkov
On Thu, Sep 6, 2018 at 3:58 PM Alexander Korotkov wrote: > On Thu, Sep 6, 2018 at 2:40 PM Alexander Korotkov > wrote: > > > > On Wed, Sep 5, 2018 at 7:28 PM amul sul wrote: > > > On Wed, Sep 5, 2018, 6:35 PM Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > > >> On Wed, Sep 5, 2018 at

Re: WIP: "More fair" LWLocks

2018-09-09 Thread Dmitry Dolgov
> On Mon, 13 Aug 2018 at 17:36, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > > 2) lwlock-far-2.patch > New flag LW_FLAG_FAIR is introduced. This flag is set when first > shared locker in the row releases the lock. When LW_FLAG_FAIR is set > and there is already somebody in the queue,

Re: How to find local logical replication origin?

2018-09-09 Thread Jinhua Luo
Could I assume all local originated changes is with InvalidRepOriginId? Jinhua Luo 于2018年9月8日周六 下午5:41写道: > > Hi All, > > What's the local logical replication origin, which could be used to > filter local changes in the replication slot? > > In other words, I'm curious that what's the default repl

Re: remove duplicated words in comments .. across lines

2018-09-09 Thread Antonin Houska
Justin Pryzby wrote: > Resending to -hackers as I realized this isn't a documentation issue so not > appropriate or apparently interesting to readers of -doc. > > Inspired by David's patch [0], find attached fixing words duplicated, across > line boundaries. > > I should probably just call the

Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

2018-09-09 Thread John Naylor
On 8/1/18, Paul Guo wrote: > Thanks. I updated the patch as attached. > > Double-checked those tests passed. I've verified make check-world passes. I've marked it Ready for Committer. -John Naylor

Re: libpq stricter integer parsing

2018-09-09 Thread Fabien COELHO
Hello Michael, On Fri, Sep 07, 2018 at 11:22:14PM +0200, Fabien COELHO wrote: Weird indeed. However, even if the patch applied cleanly for me, it was not compiling anymore. Attached an updated version, in which I also tried to improve the error message on trailing garbage. At least now it a