Re: This seems like very unfriendly behaviour

2019-05-25 Thread Jaime Casanova
On Sat, 25 May 2019 at 08:35, Dave Cramer wrote: > > How do I get rid of this slot ? > > select pg_drop_replication_slot('mysub'); > ERROR: replication slot "mysub" is active for PID 13065 > test_database=# select * from pg_subscription; > subdbid | subname | subowner | subenabled | subconninfo

Re: Cleaning up and speeding up string functions

2019-05-25 Thread David Rowley
On Sun, 26 May 2019 at 04:50, Tom Lane wrote: > > David Rowley writes: > > 0003: Adds a new function named appendStringInfoStringInfo() which > > appends one StringInfo onto another. Various places did this using > > appendStringInfoString(), but that required a needless strlen() call. > > I

Fix inconsistencies for v12

2019-05-25 Thread Alexander Lakhin
Hello hackers, Please also consider fixing the following inconsistencies found in new v12 code: 1. AT_AddOids - remove (orphaned after 578b2297) 2. BeingModified ->TM_BeingModified (for consistency) 3. copy_relation_data -> remove (orphaned after d25f5191) 4. endblock -> endblk (an internal

GSoD Introductory Resources and Tutorial Projects

2019-05-25 Thread sharon clark
Hello PostgreSQL Mentors, Hello, my name is Sharon Clark and I’m a technical writer interested in the Google Season of Docs (GSoD) project for PostgreSQL. My interest stems from working with developers and moving toward software documentation. The GSoD project is a great opportunity for me to

Re: Cleaning up and speeding up string functions

2019-05-25 Thread Tom Lane
David Rowley writes: > Here's a small patch series aimed to both clean up a few misuses of > string functions and also to optimise a few things along the way. > 0001: Converts various call that use appendPQExpBuffer() that really > should use appendPQExrBufferStr(). If there's no formatting

Re: POC: converting Lists into arrays

2019-05-25 Thread Tom Lane
David Rowley writes: > If we're doing an API break for this, wouldn't it be better to come up > with something that didn't have to shuffle list elements around every > time one is deleted? Agreed that as long as there's an API break anyway, we could consider more extensive changes for this

Re: POC: converting Lists into arrays

2019-05-25 Thread Tom Lane
I wrote: > Here's a new version of the Lists-as-arrays patch. The cfbot noticed a set-but-not-used variable that my compiler hadn't whined about. Here's a v5 to pacify it. No other changes. regards, tom lane reimplement-List-as-array-5.patch.gz Description:

Re: Fix typos for v12

2019-05-25 Thread Tom Lane
Amit Kapila writes: > I have taken one pass over it and all fixes seem to be correct and got > introduced in v12. I will re-verify them once again and then commit > your patch if I don't found any problem. In the meantime, if anyone > else wants to look at it, that would be great. FWIW, I'd

Re: Fix typos for v12

2019-05-25 Thread Amit Kapila
On Sat, May 25, 2019 at 4:23 PM Alexander Lakhin wrote: > > Hello Amit, > > 25.05.2019 13:42, Amit Kapila wrote: > > I think it is good to fix these. I haven't verified all but I can > > review them. Isn't it better to fix them as one patch instead of > > multiple patches? > > If a single patch

This seems like very unfriendly behaviour

2019-05-25 Thread Dave Cramer
How do I get rid of this slot ? select pg_drop_replication_slot('mysub'); ERROR: replication slot "mysub" is active for PID 13065 test_database=# select * from pg_subscription; subdbid | subname | subowner | subenabled | subconninfo | subslotname | subsynccommit | subpublications

Re: Fix typos for v12

2019-05-25 Thread Alexander Lakhin
Hello Amit, 25.05.2019 13:42, Amit Kapila wrote: > I think it is good to fix these. I haven't verified all but I can > review them. Isn't it better to fix them as one patch instead of > multiple patches? If a single patch is more convenient, then here it is. I thought that separate patches

Re: Fix typos for v12

2019-05-25 Thread Amit Kapila
On Sat, May 25, 2019 at 3:56 PM Alexander Lakhin wrote: > > Hello hackers, > > I've done another round of cross-checking the master branch for new > unique identifiers/words. As my previous attempt to fix things was not > noticed, now I'm focusing on distinct typos. > 1. authenticaion

Fix typos for v12

2019-05-25 Thread Alexander Lakhin
Hello hackers, I've done another round of cross-checking the master branch for new unique identifiers/words. As my previous attempt to fix things was not noticed, now I'm focusing on distinct typos. 1. authenticaion (user-visible string) 2. becuase 3. checkinunique 4. cheep 5. comparion

Re: Fix link for v12

2019-05-25 Thread Amit Kapila
On Sat, May 25, 2019 at 8:43 AM Amit Kapila wrote: > > On Thu, May 23, 2019 at 10:56 PM Euler Taveira wrote: > > > > Hi, > > > > I noticed that v12 release notes is referencing the wrong GUC. It > > should be recovery_target_timeline instead of recovery_target_time. > > Patch attached. > > > >

Cleaning up and speeding up string functions

2019-05-25 Thread David Rowley
Here's a small patch series aimed to both clean up a few misuses of string functions and also to optimise a few things along the way. 0001: Converts various call that use appendPQExpBuffer() that really should use appendPQExrBufferStr(). If there's no formatting then using the former function is

Re: Runtime pruning problem

2019-05-25 Thread David Rowley
On Wed, 24 Apr 2019 at 11:42, David Rowley wrote: > I've added this to the July commitfest so that I don't forget about it. > > https://commitfest.postgresql.org/23/2102/ and an updated patch, rebased after the pgindent run. Hopefully, this will make the CF bot happy again. -- David Rowley