Re: Minimal logical decoding on standbys

2019-06-30 Thread Amit Khandekar
On Tue, 25 Jun 2019 at 19:14, Robert Haas wrote: > > On Fri, Jun 21, 2019 at 11:50 AM Amit Khandekar > wrote: > > > This definitely needs to be expanded, and follow the message style > > > guideline. > > > > This message , with the v8 patch, looks like this : > > ereport(LOG, > >

RE: Zedstore - compressed in-core columnar storage

2019-06-30 Thread Tsunakawa, Takayuki
From: Ashwin Agrawal [mailto:aagra...@pivotal.io] > The objective is to gather feedback on design and approach to the same. > The implementation has core basic pieces working but not close to complete. Thank you for proposing a very interesting topic. Are you thinking of including this in

Re: Fix typos and inconsistencies for HEAD

2019-06-30 Thread Michael Paquier
On Sun, Jun 30, 2019 at 04:06:47PM +0300, Alexander Lakhin wrote: > 4.33. close_ - > closept_ This one is incorrect as it refers to the various close_* routines below. > 4.36. combinedproj -> remove (orphaned after 69c3936a) This looks intentional? > I've split proposed patch to make the fixes

Re: mcvstats serialization code is still shy of a load

2019-06-30 Thread Tom Lane
Tomas Vondra writes: > Attached is a slightly improved version of the serialization patch. I reviewed this patch, and tested it on hppa and ppc. I found one serious bug: in the deserialization varlena case, you need - dataptr += MAXALIGN(len); +

RE: Commitfest 2019-07, the first of five* for PostgreSQL 13

2019-06-30 Thread Tsunakawa, Takayuki
From: Stephen Frost [mailto:sfr...@snowman.net] > sh, don't look now, but there might be a "Resend email" button in the > archives now that you can click to have an email sent to you... > > Note that you have to be logged in, and the email will go to the email address > that you're logging

RE: [bug fix] Produce a crash dump before main() on Windows

2019-06-30 Thread Tsunakawa, Takayuki
From: Amit Kapila [mailto:amit.kapil...@gmail.com] > Tsunakawa/Haribabu - By reading this thread briefly, it seems we need > some more inputs from other developers on whether to fix this or not, > so ideally the status of this patch should be 'Needs Review'. Why it > is in 'Waiting on Author'

Re: Fix up grouping sets reorder

2019-06-30 Thread Andrew Gierth
> "Richard" == Richard Guo writes: Richard> Hi all, Richard> During the reorder of grouping sets into correct prefix order, Richard> if only one aggregation pass is needed, we follow the order of Richard> the ORDER BY clause to the extent possible, to minimize the Richard> chance that

Re: Dead encoding conversion functions

2019-06-30 Thread Tom Lane
Peter Eisentraut writes: > On 2019-05-29 21:03, Tom Lane wrote: >> If we do delete them as useless, it might also be advisable to change >> CreateConversionCommand() to refuse creation of conversions to/from >> SQL_ASCII, to prevent future confusion. > It seems nonsensical by definition to allow

Re: [PATCH] Implement uuid_version()

2019-06-30 Thread Tomas Vondra
On Fri, Jun 28, 2019 at 03:24:03PM -0700, Peter Geoghegan wrote: On Mon, Apr 8, 2019 at 11:04 PM Peter Eisentraut wrote: Yeah, I think implementing a v4 generator in core would be trivial and address almost everyone's requirements. FWIW, I think that we could do better with nbtree page

Re: Where is SSPI auth username determined for TAP tests?

2019-06-30 Thread Tom Lane
Michael Paquier writes: > On Sat, Jun 29, 2019 at 04:36:51PM -0400, Tom Lane wrote: >> I think this is likely a consequence of ca129e58c0 having modified >> 010_dump_connstr.pl to use "regress_postgres" not "postgres" as the >> bootstrap superuser name in the source cluster. I suppose I

Re: [PATCH] Implement uuid_version()

2019-06-30 Thread Fabien COELHO
Hello Peter, Yeah, I think implementing a v4 generator in core would be trivial and address almost everyone's requirements. Here is a proposed patch for this. I did a fair bit of looking around in other systems for a naming pattern but didn't find anything consistent. So I ended up just

Fix typos and inconsistencies for HEAD

2019-06-30 Thread Alexander Lakhin
Hello hackers, Please consider fixing the next bunch of typos and inconsistencies in the tree: 4.1. AccesShareLock -> AccessShareLock 4.2. AdjustTimestampForTypemod -> AdjustTimestampForTypmod 4.3. AExprConst -> AexprConst 4.4. AlterExtensionOwner_oid - remove (orphaned after 994c36e0) 4.5.

Re: check_recovery_target_lsn() does a PG_CATCH without a throw

2019-06-30 Thread Michael Paquier
On Sun, Jun 30, 2019 at 11:06:58AM +0200, Peter Eisentraut wrote: > I ended up rewriting this by extracting the parsing code into > pg_lsn_in_internal() and having both pg_lsn_in() and > check_recovery_target_lsn() calling it. This mirrors similar > arrangements in float.c The refactoring looks

Add parallelism and glibc dependent only options to reindexdb

2019-06-30 Thread Julien Rouhaud
Hi, With the glibc 2.28 coming, all users will have to reindex almost every indexes after a glibc upgrade to guarantee the lack of corruption. Unfortunately, reindexdb is not ideal for that as it's processing everything using a single connexion and isn't able to discard indexes that doesn't

Re: check_recovery_target_lsn() does a PG_CATCH without a throw

2019-06-30 Thread Peter Eisentraut
This has been committed. On 2019-06-24 06:06, Michael Paquier wrote: > I have been looking at this patch set. Patch 0001 looks good to me. > You are removing all traces of a set of timestamp keywords not > supported anymore, and no objections from my side for this cleanup. > > +#define

Re: proposal - patch: psql - sort_by_size

2019-06-30 Thread Pavel Stehule
Hi so 29. 6. 2019 v 10:19 odesílatel Pavel Stehule napsal: > > > so 29. 6. 2019 v 9:32 odesílatel Fabien COELHO > napsal: > >> >> Hello Pavel, >> >> > \set SORT_BY_SIZE on >> > \dt -- sorted by schema, name (size is not calculated and is not >> visible) >> > \dt+ -- sorted by size >> >> Patch

Re: make \d pg_toast.foo show its indices ; and, \d toast show its main table ; and \d relkind=I show its partitions (and tablespace)

2019-06-30 Thread Fabien COELHO
There are 3 independent patches associated to one thread and one CF entry. *** About toast table v3: Patch applies cleanly, compiles, works for me. ISTM that the he query should be unambiguous: pg_catalog.pg_class instead of pg_class, add an alias (eg c), use c.FIELD to access an

Re: Multivariate MCV list vs. statistics target

2019-06-30 Thread David Rowley
On Fri, 21 Jun 2019 at 19:09, Dean Rasheed wrote: > Hmm, maybe. I can certainly understand your dislike of using text[]. > I'm not sure that we can confidently say that multivariate statistics > won't ever need additional tuning knobs, but I have no idea at the > moment what they might be, and