Re: Fix around conn_duration in pgbench

2021-07-31 Thread Yugo NAGATA
On Fri, 30 Jul 2021 15:26:51 +0900 Fujii Masao wrote: > > > On 2021/07/30 14:43, Yugo NAGATA wrote: > > This patch fixes three issues of connection time measurement: > > > > 1. The initial connection time is measured and stored into conn_duration > > but the result is never used. > > 2.

Re: Split xlog.c

2021-07-31 Thread Alvaro Herrera
After applying 0001 and 0002 I got a bunch of compile problems: In file included from /pgsql/source/master/src/include/postgres.h:46, from /pgsql/source/master/src/backend/access/transam/xlog.c:39: /pgsql/source/master/src/backend/access/transam/xlog.c: In function

Re: archive status ".ready" files may be created too early

2021-07-31 Thread Bossart, Nathan
On 7/31/21, 9:12 AM, "Alvaro Herrera" wrote: > On 2021-Jul-31, Bossart, Nathan wrote: > >> On 7/30/21, 4:52 PM, "Alvaro Herrera" wrote: > >> > I noticed that XLogCtl->lastNotifiedSeg is protected by both the >> > info_lck and ArchNotifyLock. I think it it's going to be protected by >> > the

Re: [HACKERS] logical decoding of two-phase transactions

2021-07-31 Thread vignesh C
On Sat, Jul 31, 2021 at 11:12 AM Ajin Cherian wrote: > > On Sat, Jul 31, 2021 at 2:39 PM Amit Kapila wrote: > > > Here, the test is expecting 2 prepared transactions corresponding to > > two subscriptions but it waits for just one subscription via > > appname_copy. It should wait for the second

Re: archive status ".ready" files may be created too early

2021-07-31 Thread Alvaro Herrera
On 2021-Jul-31, Bossart, Nathan wrote: > On 7/30/21, 4:52 PM, "Alvaro Herrera" wrote: > > I noticed that XLogCtl->lastNotifiedSeg is protected by both the > > info_lck and ArchNotifyLock. I think it it's going to be protected by > > the lwlock, then we should drop the use of the spinlock. > >

Re: Replace l337sp34k in comments.

2021-07-31 Thread David G. Johnston
On Saturday, July 31, 2021, Peter Geoghegan wrote: > On Sat, Jul 31, 2021 at 11:22 AM Andrey Borodin > wrote: > > FWIW, my 2 cents. > > I do not see much difference between up2date, up-to-date, up to date, > current, recent, actual, last, newest, correct, fresh etc. > > +1. > > To me it seems

Re: Detecting File Damage & Inconsistencies

2021-07-31 Thread Amit Kapila
On Thu, Jul 22, 2021 at 7:10 PM Simon Riggs wrote: > > On Wed, 14 Jul 2021 at 05:01, Amit Kapila wrote: > > But I do understand the overall request, so I propose adding > * pg_waldump output for wal_sessioninfo data, if it exists > * pg_waldump --user=USERNAME as a filter on username > to

Re: [HACKERS] logical decoding of two-phase transactions

2021-07-31 Thread Amit Kapila
On Fri, Jul 30, 2021 at 9:32 AM Peter Smith wrote: > > Please find attached the latest patch set v100* > Few minor comments: 1. CREATE SUBSCRIPTION regress_testsub CONNECTION 'dbname=regress_doesnotexist' PUBLICATION testpub WITH (connect = false, two_phase = true); \dRs+ + --fail - alter of

Re: [HACKERS] logical decoding of two-phase transactions

2021-07-31 Thread Amit Kapila
On Sat, Jul 31, 2021 at 11:12 AM Ajin Cherian wrote: > > On Sat, Jul 31, 2021 at 2:39 PM Amit Kapila wrote: > > > Here, the test is expecting 2 prepared transactions corresponding to > > two subscriptions but it waits for just one subscription via > > appname_copy. It should wait for the second

Re: Replace l337sp34k in comments.

2021-07-31 Thread Peter Geoghegan
On Sat, Jul 31, 2021 at 11:22 AM Andrey Borodin wrote: > FWIW, my 2 cents. > I do not see much difference between up2date, up-to-date, up to date, > current, recent, actual, last, newest, correct, fresh etc. +1. To me it seems normal to debate wording/terminology with new code comments, but

Re: Replace l337sp34k in comments.

2021-07-31 Thread Andrey Borodin
> 28 июля 2021 г., в 04:39, Peter Smith написал(а): > > IMO the PG code comments are not an appropriate place for leetspeak > creativity. > > PSA a patch to replace a few examples that I recently noticed. > > "up2date" --> "up-to-date" FWIW, my 2 cents. I do not see much difference