On Thu, Aug 18, 2022 at 09:03:57AM -0700, Andres Freund wrote:
> My point is that we currently, across most of the other platforms, support
> building a "proper" static library, and install it too. But on AIX (and I
> think mingw), we don't, but without an explicit comment about not doing so. In
>
On Sun, Aug 14, 2022 at 6:07 AM Tom Lane wrote:
> Thomas Munro writes:
> > I tried to figure out how to get rid of
> > PGAC_STRUCT_SOCKADDR_STORAGE_MEMBERS, but there we're into genuine
> > non-standard cross-platform differences.
>
> Right. I don't think it's worth sweating over.
I managed to
Here are my review comments for the patch v23-0003:
==
3.1. src/backend/replication/logical/applybgworker.c -
apply_bgworker_relation_check
+ * Although the commit order is maintained by only allowing one process to
+ * commit at a time, the access order to the relation has changed. This
On Fri, Aug 19, 2022 at 03:37:52PM +1200, David Rowley wrote:
> I'm happy for you to take that. I'd just rather not be batting such trivial
> patches over the fence at each other for days or weeks.
Yes, thanks for that.
I read through your patch, which looks fine.
Let me know what I can do when
On Fri, 19 Aug 2022 at 11:21, Justin Pryzby wrote:
>
> On Thu, Aug 18, 2022 at 07:27:09PM +1200, David Rowley wrote:
> > Any objections to pushing this to master only?
>
> I won't object, but some of your changes are what makes backpatching this less
> reasonable (foreach_current_index and
On Tue, Aug 16, 2022 at 4:14 PM Thomas Munro wrote:
> On Tue, Aug 16, 2022 at 1:16 PM Andres Freund wrote:
> > > But let's suppose we want to play by a timid interpretation of that page's
> > > "do not issue low-level or STDIO.H I/O routines". It also says that
> > > SIGINT
> > > is special
On Fri, Aug 19, 2022 at 4:36 AM Peter Smith wrote:
>
> Hi Wang-san,
>
> Here is some more information about my v21-0001 review [2] posted yesterday.
>
> ~~
>
> If the streaming=parallel will be disallowed for publishers not using
> protocol 4 (see Amit's post [1]), then please ignore all my
Inline notes about changes since the last version.
On Thu, Jul 28, 2022 at 05:44:28PM -0500, Justin Pryzby wrote:
> I think the "only_if" should allow separately running one but not both of the
> windows instances, like:
>
> + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' ||
>
Hi,
On 2022-08-18 20:17:09 -0500, Justin Pryzby wrote:
> On Thu, Aug 18, 2022 at 06:09:39PM -0700, Andres Freund wrote:
> > > But look: https://cirrus-ci.com/task/4953593575899136
> >
> > Why is the build phase so slow in that image? 12min? That's way slower than
> > the windows builds normally.
On Thu, Aug 18, 2022 at 06:09:39PM -0700, Andres Freund wrote:
> > But look: https://cirrus-ci.com/task/4953593575899136
>
> Why is the build phase so slow in that image? 12min? That's way slower than
> the windows builds normally.
Because I'd just rebased it, and it's using ccache, which I
Hi,
On 2022-08-18 19:56:56 -0500, Justin Pryzby wrote:
> Note that there's now a cirrusci image with visual studio 2022, which allows
> building postgres. I tried it here.
In the past there were repeated issues with the cirrus install of visual
studio missing some things, and modifying the
On Sun, Jul 31, 2022 at 01:31:58PM -0700, Andres Freund wrote:
> > But it failed like:
> >
> > https://cirrus-ci.com/task/5622728425209856?logs=push#L16
> > [00:09:53.675] unauthorized: You don't have the needed permissions to
> > perform this operation, and you may have invalid credentials. To
On Thu, Aug 18, 2022 at 7:25 AM Masahiko Sawada wrote:
> Justin, if it's reproducible in your environment, could you please try
> it again with the attached patch?
Pushed, thanks.
I wonder how this issue could have been caught earlier, or even
avoided in the first place. Would the bug have been
On Fri, Aug 19, 2022 at 9:21 AM Justin Pryzby wrote:
>
> On Thu, Aug 18, 2022 at 07:27:09PM +1200, David Rowley wrote:
> > 0001. I'd also rather see these 4 renamed:
> ..
> > 0002. I don't really like the "my" name. I also see you've added the
> ..
> > How about just "tinfo"?
> ..
> > 0005. How
On Thu, Aug 11, 2022 at 1:48 AM Matthias van de Meent
wrote:
> I think I understand your reasoning, but I don't agree with the
> conclusion. The attached patch 0002 does fix that skew too, at what I
> consider negligible cost. 0001 is your patch with a new version
> number.
Your patch added
On Thu, Aug 18, 2022 at 07:27:09PM +1200, David Rowley wrote:
> 0001. I'd also rather see these 4 renamed:
..
> 0002. I don't really like the "my" name. I also see you've added the
..
> How about just "tinfo"?
..
> 0005. How about just "tslot". I'm not a fan of "this".
..
> Since I'm not a fan of
Hi Wang-san,
Here is some more information about my v21-0001 review [2] posted yesterday.
~~
If the streaming=parallel will be disallowed for publishers not using
protocol 4 (see Amit's post [1]), then please ignore all my previous
review comments about the protocol descriptions (see [2]
On Thu, Aug 18, 2022 at 09:52:36AM -0500, Justin Pryzby wrote:
> On Thu, Aug 18, 2022 at 11:24:22PM +0900, Masahiko Sawada wrote:
> > The status = 11 is invalid value. Probably because indstats was not
> > initialized to 0 as I mentioned.
> >
> > Justin, if it's reproducible in your environment,
On Fri, Aug 19, 2022 at 8:12 AM Vivian Kong wrote:
> From: Andres Freund
>> Does IBM provide any AIX instances to open source projects? We have access to
>> some via the gcc compile farm, but they're a bit outdated, often very
>> overloaded, and seem to have some other issues (system perl
Hi Andres,
Sorry I don’t have any connections in AIX. I couldn’t find info related to
this. Sorry I couldn’t help.
Regards,
Vivian Kong
Linux on IBM Z Open Source Ecosystem
IBM Canada Toronto Lab
From: Andres Freund
Date: Wednesday, August 17, 2022 at 7:19 PM
To: Vivian Kong
Cc:
Hi,
On 2022-08-18 15:26:31 -0400, Greg Stark wrote:
> And indexes of course. It's a bit frustrating since without the
> catalog you won't know what table the index actually is for... But
> they're pretty important stats.
FWIW, I think we should split relation stats into table and index
stats.
On Thu, 18 Aug 2022 at 02:27, Drouvot, Bertrand wrote:
>
> What I had in mind is to provide an API to retrieve stats for those that
> would need to connect to each database individually otherwise.
>
> That's why I focused on PGSTAT_KIND_RELATION that has
>
Andres Freund writes:
> On 2022-08-18 13:00:28 -0400, Tom Lane wrote:
>> I wondered about that, but we do need TCL_SHARED_BUILD in configure
>> itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it.
>> We could remove the line in Makefile.global but I don't think that
>> buys much,
On Mon, Aug 8, 2022 at 2:53 PM vignesh C wrote:
>
> On Mon, Aug 8, 2022 at 12:46 PM vignesh C wrote:
> >
> > On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
> > >
> > > On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> > > wrote:
> > > >
> > > > On Monday, May 23, 2022 2:13 PM
On Wed, Aug 10, 2022 at 4:28 PM Robert Haas wrote:
> Well, CI isn't happy with this, and for good reason:
CI is happier with this version, so I've committed 0001. If no major
problems emerge, I'll proceed with 0002 as well.
--
Robert Haas
EDB: http://www.enterprisedb.com
Hi,
On 2022-08-18 13:00:28 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Looks good, except that it perhaps could go a tad further: TCL_SHARED_BUILD
> > isn't used either afaics?
>
> I wondered about that, but we do need TCL_SHARED_BUILD in configure
> itself, and the PGAC_EVAL_TCLCONFIGSH
Andres Freund writes:
> Looks good, except that it perhaps could go a tad further: TCL_SHARED_BUILD
> isn't used either afaics?
I wondered about that, but we do need TCL_SHARED_BUILD in configure
itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it.
We could remove the line in
Hi,
On 2022-08-18 11:04:03 -0400, Tom Lane wrote:
> I happened to notice that configure extracts TCL_SHLIB_LD_LIBS
> from tclConfig.sh, and puts the value into Makefile.global,
> but then we never use it anywhere. AFAICT the only use went
> away in cd75f94da, in 2003. I propose the attached.
On Wed, Aug 17, 2022 at 10:57 AM Robert Haas wrote:
> Yeah, that looks right to me. I'm inclined to commit your patch with
> some changes to wording of the comments. I'm also inclined not to
> back-patch, since we don't know that this breaks anything for existing
> users of the xlogreader
Hi,
On 2022-08-17 21:59:29 -0700, Noah Misch wrote:
> The AIX sections of Makefile.shlib misuse the terms "static" and "shared".
>
> Imagine s/static library/library ending in .a/ and s/shared library/library
> ending in .so/. That yields an accurate description of the makefile rules.
I realize
On Wed, Aug 17, 2022 at 12:02 AM Dilip Kumar wrote:
> > Although 0002 is formally a performance optimization, I'm inclined to
> > think that if we're going to commit it, it should also be back-patched
> > into v15, because letting the code diverge when we're not even out of
> > beta yet seems
I happened to notice that configure extracts TCL_SHLIB_LD_LIBS
from tclConfig.sh, and puts the value into Makefile.global,
but then we never use it anywhere. AFAICT the only use went
away in cd75f94da, in 2003. I propose the attached.
regards, tom lane
diff --git
On 2022-08-18 Th 05:55, Dagfinn Ilmari Mannsåker wrote:
> Andrew Dunstan writes:
>
>> On 2022-08-16 Tu 14:12, Israel Barth Rubio wrote:
>>> Hello all,
>>>
>>> With the current implementation of COPY FROM in PostgreSQL we are
>>> able to load the DEFAULT value/expression of a column if the
On Thu, 2022-08-18 at 11:04 +0200, Alvaro Herrera wrote:
> On 2022-Aug-18, Laurenz Albe wrote:
> > On Wed, 2022-08-17 at 20:12 +0200, Alvaro Herrera wrote:
> > > Using ALTER TABLE DROP CONSTRAINT works fine, and the 'attnotnull'
> > > bit is lost when the last one such constraint goes away.
On Thu, Aug 18, 2022 at 11:24:22PM +0900, Masahiko Sawada wrote:
> The status = 11 is invalid value. Probably because indstats was not
> initialized to 0 as I mentioned.
>
> Justin, if it's reproducible in your environment, could you please try
> it again with the attached patch?
Yes, this seems
On 2022-08-18 Th 07:24, Daniel Gustafsson wrote:
>
> One thing I haven't researched yet is if the Buildfarm or CFBot parses the
> current output in any way or just check the exit status of the testrun.
>
>
Buildfarm: just the status.
cheers
andrew
--
Andrew Dunstan
EDB:
Hello Ilmari,
Thanks for checking it, too. I can study to implement these changes
to include a way of overriding the behavior for the given columns.
Regards,
Israel.
Em qui., 18 de ago. de 2022 às 06:56, Dagfinn Ilmari Mannsåker <
ilm...@ilmari.org> escreveu:
> Andrew Dunstan writes:
>
> > On
Hi everyone,
On Wed, Aug 10, 2022 at 6:56 AM Andrew Dunstan wrote:
>
> On 2022-08-10 We 09:04, Vivian Kong wrote:
> >
> > Hi,
> >
> >
> >
> > Are builds being paused on s390x as it looks like the s390x builds
> > were last run 15 days ago. If so, wondering what is the reason for
> > the pause
Hello,
Thanks for your review. I submitted the patch to the next commit fest
(https://commitfest.postgresql.org/39/3822/).
Regards,
Israel.
Em qua., 17 de ago. de 2022 às 18:56, Andrew Dunstan
escreveu:
>
> On 2022-08-17 We 17:12, Israel Barth Rubio wrote:
> >
> >
> > Does that address your
On 2022-08-18 Th 10:10, Robert Haas wrote:
> On Thu, Aug 18, 2022 at 12:59 AM Noah Misch wrote:
>> Along the lines of Robert's comment, it could be a nice code beautification
>> to
>> use a different suffix for the short-lived .a file. Perhaps _so_inputs.a.
> Yeah, this is the kind of thing I
On Thu, Aug 18, 2022 at 12:33 PM Nitin Jadhav
wrote:
>
> I spent some time on understanding the proposal and the patch. Here
> are a few comments wrt the test cases.
>
> > +ALTER PUBLICATION testpub_reset ADD TABLE pub_sch1.tbl1;
> > +
> > +-- Verify that tables associated with the publication
On Thu, Aug 18, 2022 at 11:04 PM Justin Pryzby wrote:
>
> On Thu, Aug 18, 2022 at 08:34:06AM -0500, Justin Pryzby wrote:
> > Unfortunately, it looks like the RPM packages are compiled with -O2, so
> > this is
> > of limited use. So I'll be back shortly with more...
>
> #3 0x006874f1 in
On Thu, Aug 18, 2022 at 11:06 PM Masahiko Sawada wrote:
>
> Hi,
>
> On Thu, Aug 18, 2022 at 10:34 PM Justin Pryzby wrote:
> >
> > Immediately after upgrading an internal instance, a loop around "vacuum" did
> > this:
>
> Thank you for the report!
>
> >
> > TRAP: FailedAssertion("indstats->status
On Thu, Aug 18, 2022 at 12:59 AM Noah Misch wrote:
> Along the lines of Robert's comment, it could be a nice code beautification to
> use a different suffix for the short-lived .a file. Perhaps _so_inputs.a.
Yeah, this is the kind of thing I was thinking about.
--
Robert Haas
EDB:
Hi,
On Thu, Aug 18, 2022 at 10:34 PM Justin Pryzby wrote:
>
> Immediately after upgrading an internal instance, a loop around "vacuum" did
> this:
Thank you for the report!
>
> TRAP: FailedAssertion("indstats->status == PARALLEL_INDVAC_STATUS_INITIAL",
> File: "vacuumparallel.c", Line: 611,
On Thu, Aug 18, 2022 at 08:34:06AM -0500, Justin Pryzby wrote:
> Unfortunately, it looks like the RPM packages are compiled with -O2, so this
> is
> of limited use. So I'll be back shortly with more...
#3 0x006874f1 in parallel_vacuum_process_all_indexes (pvs=0x25bdce0,
On Thu, Aug 18, 2022 at 04:12:45PM +0530, Anant ngo wrote:
> Hello
>
> Is there a postgres extension or project related to application-level/
> foreign-table data caching ? The postgres_fdw extension fetches data from
> foreign table for each command.
>
> I have seen previous messages in archive
Hi hackers,
Added a pg_buffercache_summary() function to retrieve an aggregated summary
information with less cost.
It's often useful to know only how many buffers are used, how many of them
are dirty etc. for monitoring purposes.
This info can already be retrieved by pg_buffercache. The
Peter Eisentraut writes:
> This is because the link command uses the option
> -mmacosx-version-min=11.3, which comes in from perl_embed_ldflags (perl
> -MExtUtils::Embed -e ldopts), but the compile commands don't use that
> option, which creates a situation that ld considers inconsistent.
> I
Hi hackers!
Tom, thank you for your feedback!
We thought about this because it already seems that custom Toasters
could have a bunch of options, so we already thinking how to store
them.
I'll check if we can implement storing Toaster options in PG_ATTRDEF.
Andres Freund complained that
Immediately after upgrading an internal instance, a loop around "vacuum" did
this:
TRAP: FailedAssertion("indstats->status == PARALLEL_INDVAC_STATUS_INITIAL",
File: "vacuumparallel.c", Line: 611, PID: 27635)
postgres: postgres pryzbyj [local] VACUUM(ExceptionalCondition+0x8d)[0x99d9fd]
postgres:
On Wed, Aug 17, 2022 at 11:58 AM wangw.f...@fujitsu.com
wrote:
>
> Attach the new patches.
>
Few comments on v23-0001
===
1.
+ /*
+ * Attach to the dynamic shared memory segment for the parallel query, and
+ * find its table of contents.
+ *
+ * Note: at this point, we have
Hello
Is there a postgres extension or project related to
application-level/foreign-table data caching ? The postgres_fdw extension
fetches data from foreign table for each command.
I have seen previous messages in archive about caching in form of global
temp tables, query cache etc. There are
Hi,
On Thu, Aug 18, 2022 at 5:38 AM Andres Freund wrote:
> I don't think we have the infrastructure for a nice solution to this at the
> moment - we need a fairly large overhaul of process initialization /
> shutdown
> to handle these interdependencies nicely.
>
>
Ok, understood.
> We can't
> On 18 Aug 2022, at 00:49, Andres Freund wrote:
>> while still be TAP compliant enough that running it with prove (with a tiny
>> Perl wrapper) works.
>
> Wonder if we could utilize that for making failures of 002_pg_upgrade.pl and
> 027_stream_regress.pl easier to understand, by reporting
On Thu, Aug 18, 2022 at 3:40 PM Peter Smith wrote:
>
> On Thu, Aug 18, 2022 at 6:57 PM Amit Kapila wrote:
> >
> > > 47. src/include/replication/logicalproto.h
> > >
> > > @@ -32,12 +32,17 @@
> > > *
> > > * LOGICALREP_PROTO_TWOPHASE_VERSION_NUM is the minimum protocol version
> > > with
> >
On Thu, Aug 18, 2022 at 6:57 PM Amit Kapila wrote:
>
> On Thu, Aug 18, 2022 at 11:59 AM Peter Smith wrote:
> >
> > Here are my review comments for patch v21-0001:
> >
> > 4. Commit message
> >
> > In addition, the patch extends the logical replication STREAM_ABORT message
> > so
> > that
Andrew Dunstan writes:
> On 2022-08-16 Tu 14:12, Israel Barth Rubio wrote:
>> Hello all,
>>
>> With the current implementation of COPY FROM in PostgreSQL we are
>> able to load the DEFAULT value/expression of a column if the column
>> is absent in the list of specified columns. We are not able
On Wed, Aug 17, 2022 at 5:55 PM Robert Haas wrote:
>
> Regarding the question of whether we need a cleanup lock on the new
> bucket I am not really seeing the advantage of going down that path.
> Simply fixing this code to take a cleanup lock instead of hoping that
> it always gets one by
On 2022-Aug-18, Laurenz Albe wrote:
> On Wed, 2022-08-17 at 20:12 +0200, Alvaro Herrera wrote:
> > 1. In my implementation, you can have more than one NOT NULL
> > pg_constraint row for a column. What should happen if the user does
> > ALTER TABLE .. ALTER COLUMN .. DROP NOT NULL;
> >
On Thu, Aug 18, 2022 at 11:59 AM Peter Smith wrote:
>
> Here are my review comments for patch v21-0001:
>
> 4. Commit message
>
> In addition, the patch extends the logical replication STREAM_ABORT message so
> that abort_time and abort_lsn can also be sent which can be used to update the
>
On Thu, Aug 18, 2022 at 5:27 PM David Rowley wrote:
>
> On Thu, 18 Aug 2022 at 17:16, Justin Pryzby wrote:
> >
> > On Thu, Aug 18, 2022 at 03:17:33PM +1200, David Rowley wrote:
> > > I'm probably not the only committer to want to run a mile when they
> > > see someone posting 17 or 26 patches in
On Wed, 2022-08-17 at 20:12 +0200, Alvaro Herrera wrote:
> I've been working on having NOT NULL constraints have pg_constraint
> rows.
>
> Everything is working now. Some things are a bit weird, and I would
> like opinions on them:
>
> 1. In my implementation, you can have more than one NOT
I wrote
> [v4]
This piece is a leftover from the last version, and forgot to remove
it, will fix:
diff --git a/contrib/cube/cubeparse.y b/contrib/cube/cubeparse.y
index 7577c4515c..e3b750b695 100644
--- a/contrib/cube/cubeparse.y
+++ b/contrib/cube/cubeparse.y
@@ -7,6 +7,7 @@
#include
> > > > > index dbe7d4f742..0b373048b5 100644
> > > > > --- a/contrib/cube/cubedata.h
> > > > > +++ b/contrib/cube/cubedata.h
> > > > > @@ -67,3 +67,7 @@ extern void cube_scanner_finish(void);
> > > > >
> > > > > /* in cubeparse.y */
> > > > > extern int cube_yyparse(NDBOX **result);
> > > > >
On Wed, Aug 17, 2022 at 8:14 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-08-16 17:41:43 +0700, John Naylor wrote:
> > For v3, I addressed some comments and added .h files to the
> > headerscheck exceptions.
>
> Thanks!
>
>
> > /*
> > * NB: include bootparse.h only AFTER including bootstrap.h,
On 8/18/22 03:32, David Rowley wrote:
> On Thu, 18 Aug 2022 at 02:46, Tomas Vondra
> wrote:
>> So I don't think the current costing is wrong, but it certainly is more
>> complex. But the test does not test what it intended - I have two ideas
>> how to make it work:
>>
>> 1) increase the number
On Thu, 18 Aug 2022 at 17:16, Justin Pryzby wrote:
>
> On Thu, Aug 18, 2022 at 03:17:33PM +1200, David Rowley wrote:
> > I'm probably not the only committer to want to run a mile when they
> > see someone posting 17 or 26 patches in an email. So maybe "bang for
> > buck" is a better method for
I spent some time on understanding the proposal and the patch. Here
are a few comments wrt the test cases.
> +ALTER PUBLICATION testpub_reset ADD TABLE pub_sch1.tbl1;
> +
> +-- Verify that tables associated with the publication are dropped after RESET
> +\dRp+ testpub_reset
> +ALTER PUBLICATION
When building on macOS against a Homebrew-provided Perl installation, I
get these warnings during the build:
ld: warning: object file (SPI.o) was built for newer macOS version
(12.4) than being linked (11.3)
ld: warning: object file (plperl.o) was built for newer macOS version
(12.4) than
Hi Wang-san,
FYI, I also checked the latest patch v23-0001 but found that the
v21-0001/v23-0001 differences are minimal, so all my v21* review
comments are still applicable for the patch v23-0001.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
Hi all, This is a continuation of the above thread...
>> > 4. In order to use WAL-logging each page must start with a standard 24
>> > byte PageHeaderData even if it is needless for storage itself. Not a
>> > big deal though. Another (acutally documented) WAL-related limitation
>> > is that only
Here are my review comments for patch v21-0001:
Note - There are some "general" comments which will result in lots of
smaller changes. The subsequent "detailed" review comments have some
overlap with these general comments but I expect some will be missed
so please search/replace to fix all code
On Mon, Aug 15, 2022 at 5:53 PM Thomas Munro wrote:
> Remove configure probe for IPv6.
> Remove dead ifaddrs.c fallback code.
> Remove configure probe for net/if.h.
> Fix macro problem with gai_strerror on Windows.
> Remove configure probe for netinet/tcp.h.
> mstcpip.h is not missing
74 matches
Mail list logo
