Re: Revise the Asserts added to bimapset manipulation functions

2024-01-01 Thread Richard Guo
On Sun, Dec 31, 2023 at 6:44 AM David Rowley wrote: > On Fri, 29 Dec 2023 at 23:38, Richard Guo wrote: > > After applying this process to the first RestrictInfo, the bitmapset now > > becomes {t2, t3}. Consequently, the second RestrictInfo also perceives > > {t2, t3} as its required_relids.

INFORMATION_SCHEMA node

2024-01-01 Thread Tatsuo Ishii
In the following paragraph in information_schema: character encoding form An encoding of some character repertoire. Most older character repertoires only use one encoding form, and so there are no separate names for them (e.g., LATIN1 is an encoding form

Re: Minor cleanup for search path cache

2024-01-01 Thread Tom Lane
Zhang Mingli writes: > Only me? > zml@localhashdata postgres % git apply minor-search-path-cache-cleanup.patch > error: patch failed: src/backend/catalog/namespace.c:156 > error: src/backend/catalog/namespace.c: patch does not apply > error: patch failed: src/tools/pgindent/typedefs.list:2479 >

Re: Minor cleanup for search path cache

2024-01-01 Thread Zhang Mingli
Hi, Zhang Mingli www.hashdata.xyz On Jan 2, 2024 at 05:38 +0800, Tom Lane , wrote: > I happened to notice that there is a not-quite-theoretical crash > hazard in spcache_init(). If we see that SPCACHE_RESET_THRESHOLD > is exceeded and decide to reset the cache, but then nsphash_create > fails

Re: Track in pg_replication_slots the reason why slots conflict?

2024-01-01 Thread Amit Kapila
On Mon, Jan 1, 2024 at 5:24 PM shveta malik wrote: > > Please ignore the previous patch and PFA new v4 (v4_2). The only > change from the earlier v4 is the subject correction in commit msg. > The patch looks good to me. I have slightly changed one of the descriptions in the docs and also

Re: Random pg_upgrade test failure on drongo

2024-01-01 Thread Alexander Lakhin
Hello Kuroda-san, 28.12.2023 06:08, Hayato Kuroda (Fujitsu) wrote: Dear Alexander, I agree with your analysis and would like to propose a PoC fix (see attached). With this patch applied, 20 iterations succeeded for me. There are no reviewers so that I will review again. Let's move the PoC to

Re: Commitfest manager January 2024

2024-01-01 Thread vignesh C
On Mon, 1 Jan 2024 at 21:01, Magnus Hagander wrote: > > On Mon, Jan 1, 2024 at 4:35 AM vignesh C wrote: > > > > On Sun, 24 Dec 2023 at 18:40, vignesh C wrote: > > > > > > On Sun, 24 Dec 2023 at 07:16, Michael Paquier wrote: > > > > > > > > On Sat, Dec 23, 2023 at 08:52:38AM +0530, vignesh C

Re: pg_column_toast_chunk_id: a function to get a chunk ID of a TOASTed value

2024-01-01 Thread jian he
On Mon, Nov 6, 2023 at 8:00 AM jian he wrote: > > minor doc issues. > Returns the chunk id of the TOASTed value, or NULL if the value is not > TOASTed. > Should it be "chunk_id"? > > you may place it after pg_create_logical_replication_slot entry to > make it look like alphabetical order. > >

Re: Add pg_basetype() function to obtain a DOMAIN base type

2024-01-01 Thread jian he
On Mon, Dec 4, 2023 at 5:11 PM John Naylor wrote: > > On Thu, Sep 28, 2023 at 12:22 AM Alexander Korotkov > wrote: > > The one thing triggering my perfectionism is that the patch does two > > syscache lookups instead of one. > > For an admin function used interactively, I'm not sure why that >

Re: Change GUC hashtable to use simplehash?

2024-01-01 Thread jian he
On Tue, Dec 26, 2023 at 4:01 PM John Naylor wrote: > > 0001-0003 are same as earlier > 0004 takes Jeff's idea and adds in an optimization from NetBSD's > strlen (I said OpenBSD earlier, but it goes back further). I added > stub code to simulate big-endian when requested at compile time, but a >

Re: Assorted typo fixes

2024-01-01 Thread Dagfinn Ilmari Mannsåker
Shubham Khanna writes: > I was reviewing the Patch and came across a minor issue that the Patch > does not apply on the current Head. Please provide the updated version > of the patch. Thanks for the heads-up. Commit 5ccb3bb13dcbedc30d015fc06d306d5106701e16 removed one of the instances of "data

Minor cleanup for search path cache

2024-01-01 Thread Tom Lane
I happened to notice that there is a not-quite-theoretical crash hazard in spcache_init(). If we see that SPCACHE_RESET_THRESHOLD is exceeded and decide to reset the cache, but then nsphash_create fails for some reason (perhaps OOM), an error will be thrown leaving the SearchPathCache pointer

Re: add function argument names to regex* functions.

2024-01-01 Thread Dian Fay
On Wed Dec 27, 2023 at 10:28 PM EST, jian he wrote: > On Thu, Dec 28, 2023 at 6:25 AM Peter Eisentraut wrote: > > > > On 27.12.23 17:53, jian he wrote: > > > similar to [1], add function argument names to the following functions: > > > regexp_like, regexp_match,regexp_matches,regexp_replace, > >

Re: Commitfest manager January 2024

2024-01-01 Thread Magnus Hagander
On Mon, Jan 1, 2024 at 4:35 AM vignesh C wrote: > > On Sun, 24 Dec 2023 at 18:40, vignesh C wrote: > > > > On Sun, 24 Dec 2023 at 07:16, Michael Paquier wrote: > > > > > > On Sat, Dec 23, 2023 at 08:52:38AM +0530, vignesh C wrote: > > > > I didn't see anyone volunteering for the January

Re: Transaction timeout

2024-01-01 Thread Andrey M. Borodin
> On 29 Dec 2023, at 16:15, Andrey M. Borodin wrote: PFA v20. Code steps are intact. Further refactored tests: 1. Check termination of active and idle queries (previously tests from Li were testing only termination of idle query) 2. Check timeout reschedule (even when last active

Re: Shared detoast Datum proposal

2024-01-01 Thread Andy Fan
Andy Fan writes: > > Some Known issues: > -- > > 1. Currently only Scan & Join nodes are considered for this feature. > 2. JIT is not adapted for this purpose yet. JIT is adapted for this feature in v2. Any feedback is welcome. -- Best Regards Andy Fan >From

Re: Proposal to include --exclude-extension Flag in pg_dump

2024-01-01 Thread Ayush Vatsa
Hi, > Aren't extensions excluded by default? That's why we have --extension. According to the documentation of pg_dump when the --extension option is not specified, all non-system extensions in the target database will get dumped. > Why do we need to explicitly exclude extensions? Hence to include

Re: Autonomous transactions 2023, WIP

2024-01-01 Thread Pavel Stehule
po 1. 1. 2024 v 12:15 odesílatel Ivan Kush napsal: > > On 01.01.2024 09:47, Pavel Stehule wrote: > > > > > > All use cases of pg_background, except asynchronous execution. If > > later > > add asynchronous execution, then all =) > > > > For example, also: > > > > * conversion

Re: Proposal to include --exclude-extension Flag in pg_dump

2024-01-01 Thread Ashutosh Bapat
On Mon, Dec 25, 2023 at 3:48 PM Ayush Vatsa wrote: > > Hi PostgreSQL Community, > Recently I have been working on pg_dump regarding my project and wanted to > exclude an extension from the dump generated. I wonder why it doesn't have > --exclude-extension type of support whereas --extension

Re: warn if GUC set to an invalid shared library

2024-01-01 Thread John Naylor
On Thu, Dec 28, 2023 at 12:27 PM Shubham Khanna wrote: > > I was reviewing the Patch and came across a minor issue that the Patch > does not apply on the current Head. Please provide the updated version > of the patch. For your information, the commitfest manager has the ability to send private

Re: add AVX2 support to simd.h

2024-01-01 Thread John Naylor
On Thu, Nov 30, 2023 at 12:15 AM Nathan Bossart wrote: > I don't intend for this patch to be > seriously considered until we have better support for detecting/compiling > AVX2 instructions and a buildfarm machine that uses them. That's completely understandable, yet I'm confused why there is a

Re: Track in pg_replication_slots the reason why slots conflict?

2024-01-01 Thread shveta malik
On Mon, Jan 1, 2024 at 5:17 PM shveta malik wrote: > > On Mon, Jan 1, 2024 at 4:30 PM Amit Kapila wrote: > > > > On Mon, Jan 1, 2024 at 12:32 PM shveta malik wrote: > > > > > > PFA v3 after changing column name to 'conflict_reason' > > > > > > > Few minor comments: > > === > >

Re: Track in pg_replication_slots the reason why slots conflict?

2024-01-01 Thread shveta malik
On Mon, Jan 1, 2024 at 4:30 PM Amit Kapila wrote: > > On Mon, Jan 1, 2024 at 12:32 PM shveta malik wrote: > > > > PFA v3 after changing column name to 'conflict_reason' > > > > Few minor comments: > === > 1. > + > + wal_removed = required WAL has been removed.

Re: Autonomous transactions 2023, WIP

2024-01-01 Thread Ivan Kush
On 01.01.2024 09:47, Pavel Stehule wrote: All use cases of pg_background, except asynchronous execution. If later add asynchronous execution, then all =) For example, also: * conversion from Oracle's `PRAGMA AUTONOMOUS` to Postgres. * possibility to create

Re: Track in pg_replication_slots the reason why slots conflict?

2024-01-01 Thread Amit Kapila
On Mon, Jan 1, 2024 at 12:32 PM shveta malik wrote: > > PFA v3 after changing column name to 'conflict_reason' > Few minor comments: === 1. + + wal_removed = required WAL has been removed. + + + + + rows_removed

Update for copyright messages to 2024 (Happy New Year!)

2024-01-01 Thread Michael Paquier
Hi, (CC-ing Bruce) As of this new year, and in the vein of c8e1ba736b2b. Bruce, are you planning an update of the copyright dates with a run of ./src/tools/copyright.pl on HEAD, and the smallish updates of the back branches? And of course, Happy New Year to all! -- Michael signature.asc

Re: speed up a logical replica setup

2024-01-01 Thread vignesh C
On Wed, 6 Dec 2023 at 12:53, Euler Taveira wrote: > > On Thu, Nov 9, 2023, at 8:12 PM, Michael Paquier wrote: > > On Thu, Nov 09, 2023 at 03:41:53PM +0100, Peter Eisentraut wrote: > > On 08.11.23 00:12, Michael Paquier wrote: > >> - Should the subdirectory pg_basebackup be renamed into something

Re: Assorted typo fixes

2024-01-01 Thread Shubham Khanna
On Thu, Dec 28, 2023 at 3:21 AM Dagfinn Ilmari Mannsåker wrote: > > Hi folks, > > I was playing around with the `typos` tool > (https://github.com/crate-ci/typos), and thought I'd run it on the > posgres repo for fun. After a bit of tweaking to get rid of most false > positives (see separately

Re: Remove unneeded PGDATABASE setting from TAP tests

2024-01-01 Thread Bharath Rupireddy
On Sun, Dec 31, 2023 at 8:36 AM Michael Paquier wrote: > > On Sun, Dec 31, 2023 at 07:24:08AM +0530, Bharath Rupireddy wrote: > > Some of the TAP tests are explicitly setting PGDATABASE environment > > variable to 'postgres', which isn't needed because the TAP test's perl > > library