Re: WAL usage calculation patch

2020-03-15 Thread Kirill Bychik
> > > On Thu, Mar 5, 2020 at 8:55 PM Kirill Bychik > > > wrote: > > > > I wanted to keep the patch small and simple, and fit to practical > > > > needs. This patch is supposed to provide tuning assistance, catching > > > > an io heavy query

Re: WAL usage calculation patch

2020-03-17 Thread Kirill Bychik
> > Please feel free to work on any extension of this patch idea. I lack > > both time and knowledge to do it all by myself. > > > I'm adding a 3rd patch on top of yours to expose the new WAL counters in > pg_stat_database, for vacuum and autovacuum. I'm not really enthiusiastic > with > this app

Re: WAL usage calculation patch

2020-03-17 Thread Kirill Bychik
> > > > Please feel free to work on any extension of this patch idea. I lack > > > > both time and knowledge to do it all by myself. > > > > > > I'm adding a 3rd patch on top of yours to expose the new WAL counters in > > > pg_stat_database, for vacuum and autovacuum. I'm not really > > > enthius

Re: WAL usage calculation patch

2020-03-18 Thread Kirill Bychik
> > There is a higher-level Instrumentation API that can be used with > > INSTRUMENT_WAL flag to collect the wal usage information. I believe > > the instrumentation is widely used in the executor code, so it should > > not be a problem to colelct instrumentation information on autovacuum > > worke

Re: WAL usage calculation patch

2020-03-22 Thread Kirill Bychik
> > > I'm attaching a v5 with fp records only for temp tables, so there's no > > > risk of > > > instability. As I previously said I'm fine with your two patches, so > > > unless > > > you have objections on the fpi test for temp tables or the documentation > > > changes, I believe those should

Re: WAL usage calculation patch

2020-03-27 Thread Kirill Bychik
> > > I'm attaching a v5 with fp records only for temp tables, so there's > > > no risk of > > > instability. As I previously said I'm fine with your two patches, so > > > unless > > > you have objections on the fpi test for temp tables or the > > > documentation > > >>>

WAL usage calculation patch

2020-02-05 Thread Kirill Bychik
Hello pgsql-hackers, Submitting a patch that would enable gathering of per-statement WAL generation statistics, similar to how it is done for buffer usage. Collected is the number of records added to WAL and number of WAL bytes written. The data collected was found valuable to analyze update-heav

Re: WAL usage calculation patch

2020-02-18 Thread Kirill Bychik
вт, 18 февр. 2020 г. в 06:23, Thomas Munro : > On Mon, Feb 10, 2020 at 8:20 PM Craig Ringer wrote: > > On Wed, 5 Feb 2020 at 21:36, Kirill Bychik wrote: > > > Patch is separated in two parts: core changes and pg_stat_statements > > > additions. Essentially the extensio

Re: WAL usage calculation patch

2020-02-20 Thread Kirill Bychik
> вт, 18 февр. 2020 г. в 06:23, Thomas Munro : > > On Mon, Feb 10, 2020 at 8:20 PM Craig Ringer wrote: > > > On Wed, 5 Feb 2020 at 21:36, Kirill Bychik > > > wrote: > > > > Patch is separated in two parts: core changes and pg_stat_statements > > >

Fwd: WAL usage calculation patch

2020-03-05 Thread Kirill Bychik
> I'm quite worried about the stability of those counters for regression tests. > Wouldn't a checkpoint happening during the test change them? Agree, stability of test could be an issue, even shifting of write format or compression method or adding compatible changes could break such test. Frankly

Re: WAL usage calculation patch

2020-03-06 Thread Kirill Bychik
пт, 6 мар. 2020 г. в 20:14, Julien Rouhaud : > > On Thu, Mar 5, 2020 at 8:55 PM Kirill Bychik wrote: > > > > > While at it, did you consider adding a full-page image counter in the > > > WalUsage? > > > That's something I'd really like to