autoprewarm is fogetting to register a tranche.

sisit that it must be there. regards, -- Kyotaro Horiguchi NTT Open Source Software Center >From 3ac3de48c9c6992bf9137dc65362ada502100c3b Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi <horiguchi.kyot...@lab.ntt.co.jp> Date: Fri, 15 Dec 2017 14:08:18 +0900 Subject: [PATCH 1/3] Add

Re: Protect syscache from bloating with negative cache entries

ke to solve this problem and the a-counter-freely-running-in-minute(or several seconds)-resolution and pruning-too-long-unaccessed-entries-on-resizing seems to me to work enough for at least several known bloat cases. This still has a defect that this is not workable for a very quick bloating. I'll try thinking about the remaining issue. If no one has immediate objection to the direction, I'll come up with an implementation. regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] Walsender timeouts and large transactions

time in WaitLatchOrSocket. - walsender exits by timeout on network stall. So, I think the patch is functionally perfect. I'm a reviewer of this patch but I think I'm not allowed to mark this "Ready for Commiter" since the last change is made by me. regards, -- Kyotaro Horiguchi

Re: [HACKERS] path toward faster partition pruning

, that is passed as input to match_clauses_to_partkey(), > to be mutually conjunctive for our purpose here. You're right and I know it. I'm ok to leave it since I recalled that clause_selectivity always has a similar code. > On 2017/11/10 14:44, Kyotaro HORIGUCHI wrote: > > At Fri, 10

Re: Failed to delete old ReorderBuffer spilled files

there are some codes cosmetically setting > > final_lsn when the fate of transaction is determined possibly we > > should not accept a invalid value of final_lsn even in the case. > > It doesn't seem just a cosmetic. The first/last_lsn are used to determin the files to be deleted. On the other hand the TXN cannot have last_lsn since it hasn't see abort/commit record. > My new patch keeps setting final_lsn, but changed its location to the > top of ReorderBufferCleanupTXN(). > I think it's a kind of preparation, so doing it at the top improves > readability. > > > Anyway I think you should register this patch to the next commit fest > > so as not forget. > > Thanks for you advice, I've registered this issue as a bug. Using last changing LSN might work but I'm afraid that that fails to remove the last snap file if the crash happens at the very start of a segment. Anyway all files of the transaction is no longer useless at the time, but it seems that the last_lsn is required to avoid directory scanning at every transaction end. Letting ReorderBufferAbortOld scan the directory and determine the first and last LSN then set to the txn would work but it might be an overkill. Using the beginning LSN of the next segment of the last_change->lsn could surely work... really? (ReorderBufferRestoreCleanup doesn't complain on ENOENT.) By the way, just using unlink() there might lead to the revmoed file's resurrection but it would be another issue. regards -- Kyotaro Horiguchi NTT Open Source Software Center

Re: Failed to delete old ReorderBuffer spilled files

At Tue, 21 Nov 2017 20:53:04 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20171121.205304.90315453.horiguchi.kyot...@lab.ntt.co.jp> > At Tue, 21 Nov 2017 20:27:25 +0900, atorikoshi > <torikoshi_atsushi...@lab.ntt.co.jp> wr

Re: [HACKERS] More stats about skipped vacuums

Hello, At Wed, 22 Nov 2017 08:20:22 +0900, Michael Paquier <michael.paqu...@gmail.com> wrote in <cab7npqq03jrewkqbc0fwje9lt1-faqc961oww+upw9qmrxa...@mail.gmail.com> > On Tue, Nov 21, 2017 at 4:09 PM, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: &

Re: Failed to delete old ReorderBuffer spilled files

At Wed, 22 Nov 2017 12:57:34 +0900, Michael Paquier wrote in

Re: [HACKERS] Improve catcache/syscache performance.

; Greetings, > > Andres Freund The folloing CF entry (in Needs review state) is of this thread and this is already pushed. May I mark this as committed or anyone else does it? https://commitfest.postgresql.org/15/1300/ regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] Walsender timeouts and large transactions

ds to > > be conditional here, isn't it? The pq_flush_if_writable() can be done > > unconditionally. > > > > Well, even the CHECK_FOR_INTERRUPTS() can be called unconditionally yes. > It just seems like it's needless call as we'll call both in for loop > anyway if we take the "slow" path. I admit it's not exactly big win > though. If you think it would improve readability I can move it. I think this is the last message in this thread so I changed the status of the CF entry to "Waiting for Author". regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] Walsender timeouts and large transactions

Hello, At Fri, 17 Nov 2017 13:24:08 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20171117.132408.85564852.horiguchi.kyot...@lab.ntt.co.jp> > > Well, even the CHECK_FOR_INTERRUPTS() can be called unconditionally yes. > >

Re: [HACKERS] More stats about skipped vacuums

At Mon, 27 Nov 2017 13:51:22 -0500, Robert Haas <robertmh...@gmail.com> wrote in <ca+tgmob2tuqvezfhv2klc-xobszxdwgdc1wmjlg5+iopla0...@mail.gmail.com> > On Mon, Nov 27, 2017 at 1:49 AM, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: > > Hmmm. Okay, we

Re: [HACKERS] WAL logging problem in 9.4.3?

At Tue, 28 Nov 2017 10:36:39 +0900, Michael Paquier wrote in

Re: [HACKERS] asynchronous execution

Hello, At Fri, 20 Oct 2017 17:37:07 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20171020.173707.12913619.horiguchi.kyot...@lab.ntt.co.jp> > The attached PoC patch theoretically has no impact on the normal > code paths and just br

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

test > > The last patch still applies, but did not get any reviews. > Horiguchi-san, you are marked as a reviewer of this patch. Could you > look at it? For now, I am moving it to next CF. Sorry for the absense. It is near to complete. I'll look this soon. regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

Hello, At Wed, 29 Nov 2017 14:04:01 +0900, Michael Paquier <michael.paqu...@gmail.com> wrote in <cab7npqtt-mj4s8qoo_c9cafacv0j3vhgg4_kw2u1wxvyeyb...@mail.gmail.com> > On Tue, Sep 19, 2017 at 3:04 PM, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: > >&g

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

Thank you for adding the detailed comment and commiting. At Sat, 5 May 2018 01:49:31 +0300, Heikki Linnakangas <hlinn...@iki.fi> wrote in <47215279-228d-f30d-35d1-16af695e5...@iki.fi> > On 04/05/18 10:05, Heikki Linnakangas wrote: > > On 24/04/18 13:57, Kyotaro HORIGUCHI w

Re: Oddity in tuple routing for foreign partitions

> > numbers, which could be any partition with arbitrarily different > > attribute > > numbers. > > > >> Anyway, I think that > >> the former is more like an improvement rather than a fix, so it would > >> be > >> better to leave that for another patch for PG12? > > > > I agree, so I'm dropping the patch for 1. > > OK, let's focus on #2! > > > See attached an updated version with changes as described above. > > Looks good to me. Thanks for the updated version! Agreed on all points above. regards. -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] asynchronous execution

incomplete post. regards. -- Kyotaro Horiguchi NTT Open Source Software Center >From 7ad4210dd20b6672367255492e2b1d95cd90b122 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi <horiguchi.kyot...@lab.ntt.co.jp> Date: Mon, 22 May 2017 12:42:58 +0900 Subject: [PATCH 1/3] Allow wait event set to be

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

which is not assumed to have additional columns not in its definition, including nonsystem junk columns. I'm not sure but it seems not that simple to give base relations an ability to have junk columns. regards. -- Kyotaro Horiguchi NTT Open Source Software Center

Re: Possible bug in logical replication.

ed). The attached patch also fixes this. The documentation doesn't look requiring a fix. regards. -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/backend/replication/slotfuncs.c b/src/backend/replication/slotfuncs.c index d9e10263bb..d3cb777f9f 100644 --- a/src/bac

Infinite loop on master shutdown

. regards, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c index e47ddca6bc..1916acf629 100644 --- a/src/backend/replication/walsender.c +++ b/src/backend/replication/walsender.c @@ -1809,6 +1809,19

Re: log_min_messages shows debug instead of debug2

g2" or even "debug1". All log level of "debugN" are seen as DEBUG in log lines. Thus showing "debug2" as just "debug" may obfuscate the cause of having so many log lines. From another view point, it can be thought as not-good that print a value with a hidden word. In short, I submit +1 for this. regards. -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] asynchronous execution

This gets further refactoring. At Fri, 11 May 2018 17:45:20 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20180511.174520.188681124.horiguchi.kyot...@lab.ntt.co.jp> > But, this is not just a rebased version. On the way fixing > se

A Japanese-unfriendy error message contruction

ecifically " %s NO %s" is the natural translation of "policy %s on %s". But currently we cannot get the natural error message in Japanese. For the reason, I'd like to propose to refactor getObjectDescription:OPCLASS_POLICY as the attached patch. The same structure is seen for OPCL

Re: Time to put context diffs in the grave

it, and I actually have stepped on it. I saw Álvaro made a complaint about the bug but it doesn't seem to have been fixed. It is the most major reason I'm posting patches in unified format hesitently (really I am!). The second reason is git format-patch doesn't give me diffs in context format. re

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

At Fri, 18 May 2018 15:31:07 -0400, Robert Haas <robertmh...@gmail.com> wrote in <ca+tgmoabuzhhca21sam7wh+a-gh2d6gkkhvapkqhnhow85d...@mail.gmail.com> > On Fri, May 18, 2018 at 4:29 AM, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: > > I ha

Re: [doc fix] Add operation of freeing output SQLDA

g regression test also free output SQLDA's memory space. > The attached patch fixes the documentation. *1: The test code knows the shape exactly so it can properly free them in proper way. regards. -- Kyotaro Horiguchi NTT Open Source Software Center

Re: A Japanese-unfriendy error message contruction

Thank you for the suggestion. Is there anyone using another language who is having difficulties in translating some messages? At Tue, 22 May 2018 14:27:29 -0400, Tom Lane <t...@sss.pgh.pa.us> wrote in <13575.1527013...@sss.pgh.pa.us> > Kyotaro HORIGUCHI <horiguchi.kyot...@lab

Re: perl checking

of 8, so of course it does the right > thing. > > We don't normally use these scripts anyway, so I'll go with this > suggestion without further investigation. Agreed. I'm fine with the direction. regards. -- Kyotaro Horiguchi NTT Open Source Software Center

Re: Possible bug in logical replication.

toring EndRecPtr after the last XLogReadRecord call. That is, from the definition, confirmed_lsn must be on the start of a record or page boundary and error out if not. For that reason, calling XLogFindNextRecord would not be the right thing to do here. We should just skip a header if we are on a boun

Re: A Japanese-unfriendy error message contruction

At Thu, 24 May 2018 14:20:21 -0400, Tom Lane <t...@sss.pgh.pa.us> wrote in <24988.1527186...@sss.pgh.pa.us> > Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> writes: > > Hello. Here is the patch set. > > Thanks! I pushed all this plus fixes for the OCLAS

Re: A Japanese-unfriendy error message contruction

tion is not excercised in the current regression test. I found that the last one you sugeested makes error messages far cleaner, easy to grasp the meaning at a glance. regards. -- Kyotaro Horiguchi NTT Open Source Software Center >From cdb956ac2da784f37b110f61da8915819d3ff107 Mon Sep 17 00:00

Re: Fix some error handling for read() and errno

At Wed, 23 May 2018 09:00:40 +0900, Michael Paquier <mich...@paquier.xyz> wrote in <2018052340.ga3...@paquier.xyz> > On Tue, May 22, 2018 at 04:51:00PM +0900, Kyotaro HORIGUCHI wrote: > > I see the same issue in snapbuild.c(4 places). > >

XLogWrite uses palloc within a critical section

NameP calls palloc within, and it is within a critical section there. So it ends with assertion failure hiding the PANIC message. We should use XLogFileName instead. The problem has existed at least since 9.3. The code is frequently revised so the patch needed to vary into four files. regards. -- K

In what range of the code can we read debug_query_string?

, the biggest problem is the fact that I myself haven't been able to run the path... Any suggestions, thoughts, opinions are welcome. regards. -- Kyotaro Horiguchi NTT Open Source Software Center *** a/src/backend/tcop/postgres.c --- b/src/backend/tcop/postgres.c *** *** 2399,2407

Re: XLogWrite uses palloc within a critical section

Thank you for the comment. At Fri, 25 May 2018 09:05:21 +0300, Heikki Linnakangas <hlinn...@iki.fi> wrote in <466a3c6d-7986-8cb1-d908-e85aa6a09...@iki.fi> > On 25/05/18 07:45, Kyotaro HORIGUCHI wrote: > > Hello. > > I happened to see the following in XLogWrite

Re: parallel foreign scan

rom multple servers, the following proposed PoC patch is a implement of asynchronous execution of postgres_fdw and it might be helpful. https://www.postgresql.org/message-id/20180515.202945.69332784.horiguchi.kyot...@lab.ntt.co.jp The postgres_fdw.c part in it is complicated since it supports shared

Re: Fix some error handling for read() and errno

fatal_error("could not read from log file %s, offset %u, length %d: %s", | fname, sendOff, segbytes, strerror(err)); A bit differnt issue, but in pg_waldump.c, search_directory can check uninitialized errno when read returns a non-zero value. regards. -- Kyotaro Horiguchi NTT Open Source Software Center

Re: perl checking

ls/msvc/dummylib perl -cw src/tools/Mkvcbuild.pm > > > This also allows us to check src/tools/win32tzlist.pl. > > > In due course I'll submit a script to automate this syntax checking. > > > cheers > > > andrew regards. -- Kyotaro Horiguchi NTT Open Source Software Center

Re: Infinite loop on master shutdown

At Thu, 17 May 2018 09:20:01 -0700, Andres Freund <and...@anarazel.de> wrote in <20180517162001.rzd7l6g2h66hv...@alap3.anarazel.de> > Hi, > > On 2018-05-17 17:19:00 +0900, Kyotaro HORIGUCHI wrote: > > Hello, as in pgsql-bug ML. > > > >

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

Thanks for the discussion. At Thu, 7 Jun 2018 19:16:57 +0530, Ashutosh Bapat wrote in > On Tue, Jun 5, 2018 at 3:40 PM, Kyotaro HORIGUCHI > wrote: > > Hello. > > > > At Mon, 04 Jun 2018 20:58:28 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI > > wrote in

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

I'm willing to work on that if I'm not on a wrong way here. -- Kyotaro Horiguchi

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

arameters and specify remote victims using them accurately. It fails on some join-pushdown cases since it doesn't add tid columns to join tlist. I suppose that build_tlist_to_deparse needs something but I'll consider further tomorrow. regards. -- Kyotaro Horiguchi NTT Open Source Software Center d

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

At Mon, 04 Jun 2018 20:58:28 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20180604.205828.208262556.horiguchi.kyot...@lab.ntt.co.jp> > Hello. > > At Fri, 1 Jun 2018 10:21:39 -0400, Ashutosh Bapat > wrote in > > > I am not suggesting to commit 0003 in

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

On Thu, May 31, 2018 at 11:34 AM, Ashutosh Bapat wrote: > On Thu, May 31, 2018 at 7:36 PM, Tom Lane wrote: >> What you want for the first part of that is basically like >> generate_new_param() in subselect.c. We don't expose that publicly >> at the moment, but we could, or maybe better to

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

Hello. At Mon, 04 Jun 2018 20:58:28 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20180604.205828.208262556.horiguchi.kyot...@lab.ntt.co.jp> > It fails on some join-pushdown cases since it doesn't add tid > columns to join tlist. I suppose that build_tlist_to_dep

Re: In what range of the code can we read debug_query_string?

Thank you for the comment. At Fri, 25 May 2018 10:08:08 -0400, Tom Lane <t...@sss.pgh.pa.us> wrote in <3389.1527257...@sss.pgh.pa.us> > Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> writes: > > It is set for other kinds of message, (parse, bind, execute). I >

How to find the base version cf-bot is using?

> Author: Peter Eisentraut > Date: Sun Jul 1 15:10:08 2018 +0200 How can I find the base version the CF-bot used at the time? regards. -- Kyotaro Horiguchi NTT Open Source Software Center

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

Hello. At Fri, 15 Jun 2018 11:19:21 +0530, Ashutosh Bapat wrote in > On Tue, Jun 12, 2018 at 8:49 AM, Kyotaro HORIGUCHI > wrote: > > Thanks for the discussion. > > > > At Thu, 7 Jun 2018 19:16:57 +0530, Ashutosh Bapat > > wrote in > > &g

Re: PATCH: backtraces for error messages

Hello. Thaks for discussing. At Mon, 25 Jun 2018 17:08:41 +0800, Craig Ringer wrote in > On 25 June 2018 at 14:21, Kyotaro HORIGUCHI > > I think it's pretty strongly desirable for PANIC. > > > > Ah, I forgot about that. I agree to that. The cost to collect the > > i

Let's remove DSM_IMPL_NONE.

. The motive of this is there's a case where fallback path is large(?) but scarcely expected to be used. regards. -- Kyotaro Horiguchi NTT Open Source Software Center >From 3322194ecf9c9dc02f1f96f71abc421cd65ff1eb Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: Thu, 15 Feb 2018 11:22

Re: [HACKERS] Restricting maximum keep segments by repslots

it-feature.patch TAP test for this feature v2-0004-Documentation-for-slot-limit-feature.patch Documentation, as the name. regards. -- Kyotaro Horiguchi NTT Open Source Software Center >From 9fe29d9fef53891a40b81ed255ca9060f8af4ea1 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: T

Re: [HACKERS] Possibly too stringent Assert() in b-tree code

g_reuse_page(Relation rel, BlockNumber blkno, TransactionId > latestRemovedXid) > { > xl_btree_reuse_page xlrec_reuse; > > /* >* Note that we don't register the buffer with the record, because this >* operation doesn't modify the page. This record only exists to pr

Re: Protect syscache from bloating with negative cache entries

Hello. I rebased this patchset. At Thu, 15 Mar 2018 14:12:46 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20180315.141246.130742928.horiguchi.kyot...@lab.ntt.co.jp> > At Mon, 12 Mar 2018 17:34:08 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI

Re: some question about _bt_getbuf

hen recycling an all-zeroes page > in an index. > Referring to below comments in code, an all-zeroes page is created when > backend downs in the split process after extending the index's relation to > get a new page and before making WAL entries for that. I'm not sure if there's no other cases to create such pages but at least your steps does as mentioned in the comment of _bt_page_recyclable(). And I agree to Amit's diagnosis and Tom's solution. regards. -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [bug fix] ECPG: freeing memory for pgtypes crashes on Windows

vote for back-patching this up to 9.5 (quite arbitrary..) but it is fine for me if the documentation of 9.6 and earlier mention a restriction like "For Windows environment, the application may crash when it is using free() to the return values from PGTYPES*_to_ascii functions. Make sure to use the sa

Re: [bug fix] ECPG: freeing memory for pgtypes crashes on Windows

At Mon, 25 Jun 2018 08:16:10 +, "Tsunakawa, Takayuki" wrote in <0A3221C70F24FB45833433255569204D1FA241F9@G01JPEXMBYT05> > From: Kyotaro HORIGUCHI [mailto:horiguchi.kyot...@lab.ntt.co.jp] > > However I also don't see a problem to back-patch it, I don't see > &g

Re: PATCH: backtraces for error messages

Hi. At Mon, 25 Jun 2018 09:32:36 +0800, Craig Ringer wrote in > On 21 June 2018 at 19:09, Kyotaro HORIGUCHI > wrote: > > I think this for assertion failure is no problem but I'm not sure > > for other cases. > > > I think it's pretty strongly desirable for

Re: Small fixes about backup history file in doc and pg_standby

the word ".backup" in the context of recovery_command. The definition of the symbol XLOG_BACKUP_LABEL is no longer useful after your patch applied. Removing the symbol makes XLOG_DATA and the variable nextWALFileName useless and finally we can remove all branching using it. regards. -- Kyotaro Horiguchi NTT Open Source Software Center

Re: Protect syscache from bloating with negative cache entries

Hello. The previous v4 patchset was just broken. At Tue, 26 Jun 2018 18:00:03 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20180626.180003.127457941.horiguchi.kyot...@lab.ntt.co.jp> > Hello. I rebased this patchset. .. > > The attached is the patch set including

Re: shared-memory based stats collector

Hello. Thanks for the comment. At Mon, 2 Jul 2018 14:25:58 -0400, Robert Haas wrote in > On Fri, Jun 29, 2018 at 4:34 AM, Kyotaro HORIGUCHI > wrote: > > Nowadays PostgreSQL has dynamic shared hash (dshash) so we can > > use this as the main storage of statistics. We can shar

Re: Standby corruption after master is restarted

u, Apr 26, 2018 at 07:53:04PM +0900, Kyotaro HORIGUCHI wrote: > > I think this behavior is a bug. XLogReadRecord is considering the > > case but palloc_extended() breaks it. So in the attached, add a > > new flag MCXT_ALLOC_NO_PARAMERR to palloc_extended() and > > alloca

Re: Oddity in tuple routing for foreign partitions

At Thu, 26 Apr 2018 21:16:38 +0900, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp> wrote in <5ae1c326.6040...@lab.ntt.co.jp> > (2018/04/26 20:06), Kyotaro HORIGUCHI wrote: > > Please rewrite it to use not array reference, but pointer > > reference if one mtsta

Re: Standby corruption after master is restarted

length 1298694144 at 0/83C17B70 too long > LOG: record length 1298694144 at 0/83C17B70 too long > LOG: received promote request > LOG: redo done at 0/83C17B38 > LOG: last completed transaction was at log time 2018-04-26 19:10:12.360253+09 > LOG: selected new timeline ID: 2 > LOG:

Re: Protect syscache from bloating with negative cache entries

At Tue, 19 Dec 2017 13:14:09 -0500, Tom Lane <t...@sss.pgh.pa.us> wrote in <748.1513707...@sss.pgh.pa.us> > Robert Haas <robertmh...@gmail.com> writes: > > On Tue, Dec 19, 2017 at 3:31 AM, Kyotaro HORIGUCHI > > <horiguchi.kyot...@lab.ntt.co.jp> wrote: >

Re: autoprewarm is fogetting to register a tranche.

Hello, At Mon, 18 Dec 2017 12:46:02 -0500, Robert Haas <robertmh...@gmail.com> wrote in <ca+tgmob-0tymqsjwpgv7dteqtrnsg-uagptzkhkgns22hqp...@mail.gmail.com> > On Fri, Dec 15, 2017 at 3:32 AM, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: > > Hello, I

Re: [HACKERS] Restricting maximum keep segments by repslots

At Thu, 30 Nov 2017 12:44:16 +0900, Michael Paquier wrote in

Re: [HACKERS] Restricting maximum keep segments by repslots

: The changes of documentation are seen in the following html files. doc/src/sgml/html/warm-standby.html#STREAMING-REPLICATION-SLOTS doc/src/sgml/html/runtime-config-replication.html#GUC-MAX-SLOT-WAL-KEEP-SIZE doc/src/sgml/html/view-pg-replication-slots.html One annoyance is that the min_ke

Re: TAP test module - PostgresClient

for TAP tests. If we want to let psql have such feature, it would be something like "psql server" or "reconnectable session" of frontend protocol. Both seem too much or leading to something dangerous. > > Or just > > write a bespoke testing tool. > > > >

Re: [HACKERS] WAL logging problem in 9.4.3?

rsion didn't conflict with the current master, though) and changed the status to "Needs Review". regards, -- Kyotaro Horiguchi NTT Open Source Software Center >From 15e3d095b89e9a5bb8025008d1475107b340cbd4 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi <horiguchi.kyot...@lab.ntt

Re: [HACKERS] asynchronous execution

At Mon, 11 Dec 2017 20:07:53 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20171211.200753.191768178.horiguchi.kyot...@lab.ntt.co.jp> > > The attached PoC patch theoretically has no impact on the normal > > code paths and j

Re: Index-only scan returns incorrect results when using a composite GIST index with a gist_trgm_ops column.

not > enough to stress the problem, you surely should add some (haven't > checked the patch in detail, sorry ;p ). Uggg.. I'm beaten again.. You're definitely right! It was a bit hard to find the way to cause the failure without extension but the first attached file is that. regards, -- Ky

Re: [HACKERS] [PATCH] Improve geometric types

0 for the most cases but it is a long-standing behavior.. (Anyway I don't find a reasonable definition of the distance between very-nearly parallel lines..) -- Sorry time's up today. regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

Horiguchi-san submitted but covering a few related cases. Thank you for commiting it. regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] Restricting maximum keep segments by repslots

f ... the majority? I'm convinced that my original setting is not so problematic so I reverted it. > Not sure, but that might be another situation in which "patch" > works and "git apply" doesn't. (Feeling too lazy to test it...) I was also afraid of that as I wrote upthrea

Re: [HACKERS] [PATCH] Improve geometric types

Hello, At Thu, 18 Jan 2018 16:01:01 +0100, Emre Hasegeli wrote in

Re: Bug in Physical Replication Slots (at least 9.5)?

Hello, At Fri, 19 Jan 2018 11:28:58 +, Greg Stark wrote in

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

ot;pgdefnamespace.pgsqlxml.internal" but I believe no one can notice that. - The default-ns translator (xpath_parser.c) seems working perfectly with some harmless exceptions. (xpath specifications is here: https://www.w3.org/TR/1999/REC-xpath-19991116/) Related unused features (and not documented?): context variables ($n notations), user-defined functions (or function names prefixed by a namespace prefix) Newly documented behavior: the default namespace isn't applied to and/or/div/mod. - Dodumentation looks enough. - Regression test doesn't cover the XPath syntax but it's not viable. I am fine with the basic test cases added by the current patch. regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

At Fri, 19 Jan 2018 18:24:56 +0900, Michael Paquier <michael.paqu...@gmail.com> wrote in <20180119092456.ga1...@paquier.xyz> > On Fri, Jan 19, 2018 at 10:54:53AM +0900, Kyotaro HORIGUCHI wrote: > > On the other hand if one logical record must be read from single > >

Re: Index-only scan returns incorrect results when using a composite GIST index with a gist_trgm_ops column.

k is not required but we cannot predict that until actually acquire a tuple during execution. Please find the attached patch. regards, -- Kyotaro Horiguchi NTT Open Source Software Center *** a/src/backend/optimizer/path/indxpath.c --- b/src/backend/optimizer/path/indxpath.c *

Re: [HACKERS] [PATCH] Improve geometric types

Hello, I'm still wandering on the way and confused. Sorry for inconsistent comments in advanceX-( At Sun, 14 Jan 2018 13:20:57 +0100, Emre Hasegeli wrote in

Re: [HACKERS] Restricting maximum keep segments by repslots

s streaming/keeping/lost/unknown as described in docs patch is also > acceptable for me. Maybe anyone else has better idea? I'll fix this after the discussion. regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] Restricting maximum keep segments by repslots

r discussion) - added documentation. I didn't adopt "setting per slot" since the keep amount is not measured from slot's restart_lsn, but from checkpoint LSN. *1: As I mentioned upthread, I think that at least the "pg_replication_slots.min_keep_lsn" is arguable since it shows the same value for all slots and I haven't found no other appropriate place. > Fwiw I think there's a real need for this feature so I would like to > get it in for Postgres 11. It encourages me a lot. Thanks. regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] [PATCH] Improve geometric types

e or other similar functions. At last, just a simple comment. - point_eq_point() assumes that NaN == NaN. This is an inherited behavior from old float[48]_cmp_internal() but it's not a common treat. point_eq_point() needs any comment about the special definition as float[48]_cmp_internal h

Re: [HACKERS] [PATCH] Improve geometric types

Hello, At Wed, 31 Jan 2018 17:33:42 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20180131.173342.26333067.horiguchi.kyot...@lab.ntt.co.jp> > 0003: This patch replaces "double" with float and bare arithmetic > and comp

line_perp() (?-|) is broken.

I happend to see a strange geometric calcualtion on master/HEAD. CREATE TABLE t (l1 line, l2 line); INSERT INTO t (SELECT line(point(0, 0), point(x, y)), line(point(0,0), point(-y, x)) FROM (SELECT random() x, random() y FROM generate_series(0, 1000)) AS a); SELECT l1?-|l2 AS is_perp, l1, l2

Re: [HACKERS] Restricting maximum keep segments by repslots

Hello, At Mon, 29 Jan 2018 19:26:34 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20180129.192634.217484965.horiguchi.kyot...@lab.ntt.co.jp> > While rechecking the patch, I fixed the message issued on losing > segments in 0001, re

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

Hello. At Wed, 24 Jan 2018 10:30:39 +0100, Pavel Stehule wrote in

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

the basic test cases added by the current patch. regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] Restricting maximum keep segments by repslots

Thank you for kindly noticing me of that. At Mon, 29 Jan 2018 11:07:31 +1300, Thomas Munro wrote in

Re: [HACKERS] [PATCH] Improve geometric types

At Wed, 31 Jan 2018 13:09:09 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20180131.130909.210233873.horiguchi.kyot...@lab.ntt.co.jp> > At Sun, 21 Jan 2018 21:59:19 +0100, Emre Hasegeli <e...@h

Re: [HACKERS] [PATCH] Improve geometric types

)) >*result = lseg->p[1]; However I'm not sure that adjusting the intersection to the tips of the segment is good or not. Adjusting onto the line can be better in another case. lseg_interpt_lseg, for instance, checks lseg_contain_point on the line parameter of lseg_interpt_line. # I'll be back later.. regards -- Kyotaro Horiguchi NTT Open Source Software Center

Re: Boolean partitions syntax

value not moving. So I'm not seeing > where is the bright line between "IN ('today')" and "IN (random())". > > regards, tom lane The patch leaves the ambiguity of values like 'today' but doesn't accept arbitrary functions. Howerver, it needs additiona

Re: Query running for very long time (server hanged) with parallel append

At Mon, 5 Feb 2018 15:29:27 +0530, Amit Khandekar wrote in

Re: Query running for very long time (server hanged) with parallel append

At Tue, 06 Feb 2018 13:34:19 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20180206.133419.02213593.horiguchi.kyot...@lab.ntt.co.jp> > At Mon, 5 Feb 2018 15:29:27 +0530, Amit Khandekar <amitdkhan...@gmail.com> > wrote in

Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem

script. I hope it is correct. regards, -- Kyotaro Horiguchi NTT Open Source Software Center #! /usr/bin/perl $maxmem=1024 * 4; #= print "exponential sized strategy\n"; $ss = 64; $ts = 0; $sumiteritem = 0; for ($i = 1 ; $ts < $maxmem ; $i++) { $ss = $ss * 2; if ($ts +

Re: [HACKERS] More stats about skipped vacuums

on the existence of DSM at the present since over a year we had no complain despite the fact that DSM is silently turned on? And apart from that we are ready to remove 'none' from the options of dynamic_shared_memory_type right now? If I may rely on DSM, fallback stuff would not be required. > regards, tom lane regards, -- Kyotaro Horiguchi NTT Open Source Software Center

Re: [HACKERS] More stats about skipped vacuums

At Thu, 08 Feb 2018 18:04:15 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20180208.180415.112312013.horiguchi.kyot...@lab.ntt.co.jp> > > > I suggest we remove support for dynamic_shared_memory_type = none first, > > > an

Re: [HACKERS] More stats about skipped vacuums

At Tue, 6 Feb 2018 14:50:01 +0900, Masahiko Sawada <sawada.m...@gmail.com> wrote in <cad21aocrn6q0wgg7uwgvsqjzbocnsrazbyjomuy+-grkvh-...@mail.gmail.com> > On Mon, Dec 11, 2017 at 8:15 PM, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: > > I

  1   2   3   4   5   6   7   8   9   10   >