Re: [PROPOSAL] Make PSQLVAR on \getenv opitional

2021-12-28 Thread Matheus Alcantara
On Tuesday, December 28th, 2021 at 16:53, Tom lane...@sss.pgh.pa.us wrote: > Matheus Alcantara msalcantara@pm.me writes: > >>> it is not consistent with other \g* commands. Maybe a new statement \senv ? >>> But what is the use case? You can just press ^z and inside sh

[PROPOSAL] Make PSQLVAR on \getenv opitional

2021-12-28 Thread Matheus Alcantara
Hi pgsql hackers, I was testing the new psql command \getenv introduced on commit 33d3eeadb2 and from a user perspective, I think that would be nice if the PSQLVAR parameter were optional, therefore when it is only necessary to view the value of the environment variable, the user just run

Re: [PROPOSAL] Make PSQLVAR on \getenv opitional

2021-12-28 Thread Matheus Alcantara
> Ășt 28. 12. 2021 v 19:51 odesĂ­latel Matheus Alcantara > napsal: > >> Hi pgsql hackers, I was testing the new psql command \getenv introduced on >> commit 33d3eeadb2 and from a user perspective, I think that would be nice if >> the PSQLVAR parameter were optional

[PATCH] Add tests for psql tab completion

2022-02-12 Thread Matheus Alcantara
Hi hackers. I'm attaching a patch that add some new test cases for tab completion of psql. This is my first patch that I'm sending here so let me know if I'm doing something wrong. -- Matheus AlcantaraFrom 6af6b972960f4e9017f1c311ee4b13a96d5f66a1 Mon Sep 17 00:00:00 2001 From: Matheus

Trying to add more tests to gistbuild.c

2022-05-06 Thread Matheus Alcantara
I'm studying how the gist index works trying to improve the test coverage of gistbuild.c. Reading the source code I noticed that the gistInitBuffering function is not covered, so I decided to start with it. Reading the documentation and the source I understood that for this function to be

Re: Trying to add more tests to gistbuild.c

2022-05-06 Thread Matheus Alcantara
The attached patch is failing on make check due to a typo, resubmitting the correct one. -- Matheus Alcantaradiff --git a/src/test/regress/expected/gist.out b/src/test/regress/expected/gist.out index a36b4c9c56..b5edc44250 100644 --- a/src/test/regress/expected/gist.out +++

Re: Trying to add more tests to gistbuild.c

2022-07-30 Thread Matheus Alcantara
that concern could be > alleviated if we put the test somewhere else. Maybe contrib/btree_gist > would be suitable? I can't say much about it. If there's anything I can do here, please let me know. -- Matheus AlcantaraFrom 9176b605230890f08d9a2d4692dff4fd313746e4 Mon Sep 17 00:00:00 2001 From:

Interesting areas for beginners

2022-10-22 Thread Matheus Alcantara
=6a1f082abac9da756d473e16238a906ca5a592dc -- Matheus Alcantara

Re: Interesting areas for beginners

2022-10-24 Thread Matheus Alcantara
Thanks so much for the answers, I'll try to start looking at some patches. -- Matheus Alcantara

Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns

2022-10-25 Thread Matheus Alcantara
I've tested all 4 of your patches, and all of them seem to work as expected. This is my first time reviewing a patch, so let's see if more experience hackers has anything more to say about these patches, but at first they seem correct to me. -- Matheus Alcantara

Re: mprove tab completion for ALTER EXTENSION ADD/DROP

2022-12-03 Thread Matheus Alcantara
hed on current master and seems to be working properly. I'm starting reviewing some patches here, let's see what more experience hackers has to say about this, but as far I can tell is that is working as expected. -- Matheus Alcantara

Re: Index not getting cleaned even though vacuum is running

2022-11-16 Thread Matheus Alcantara
nimizes the size of the table, but can take a long time. It also requires extra disk space for the new copy of the table, until the operation completes." https://www.postgresql.org/docs/current/routine-vacuuming.html -- Matheus Alcantara

Re: Make ON_ERROR_STOP stop on shell script failure

2022-11-22 Thread Matheus Alcantara
o the master cleanly. Could you please rebase it? -- Matheus Alcantara

Duplicated LLVMJitHandle->lljit assignment?

2023-07-12 Thread Matheus Alcantara
AlcantaraFrom 2a2c773b2437b2c491576db8d7ed6b6d1ba2c815 Mon Sep 17 00:00:00 2001 From: Matheus Alcantara Date: Wed, 12 Jul 2023 18:57:52 -0300 Subject: [PATCH] Remove duplicated LLVMJitHandle->lljit assignment --- src/backend/jit/llvm/llvmjit.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/