}
> What about changing this if statement like following:
> if (entry->exprstate_valid)
> return;
>
Modified in v58 [1] as suggested
--
[1]
https://www.postgresql.org/message-id/CAHut%2BPvkswkGLqzYo7z9rwOoDeLtUk0PEha8kppNvZts0h22Hw%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
On Mon, Dec 27, 2021 at 9:57 AM Euler Taveira wrote:
>
> On Sun, Dec 26, 2021, at 1:09 PM, Alvaro Herrera wrote:
>
> On 2021-Dec-26, Euler Taveira wrote:
>
> > On Sat, Dec 25, 2021, at 1:20 AM, Amit Kapila wrote:
> > > On Fri, Dec 24, 2021 at 11:04 AM Peter Smith
&
On Tue, Dec 28, 2021 at 4:34 AM Tom Lane wrote:
>
> Peter Smith writes:
> > The most recent cfbot run for a patch I am interested in has failed a
> > newly added regression test.
> > Please see http://cfbot.cputube.org/ for 36/2906
> > The failure logs [2] are
On Fri, Dec 31, 2021 at 12:39 AM houzj.f...@fujitsu.com
wrote:
>
> On Wed, Dec 29, 2021 11:16 AM Tang, Haiying wrote:
> > On Mon, Dec 27, 2021 9:16 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > On Thur, Dec 23, 2021 4:28 PM Peter Smith wrote
d in row filters from all the publications
+ * the relation is in are part of replica identity, or the publication
+ * actions do not include UPDATE and DELETE.
+ */
Some minor rewording of the comment:
"true" --> "True".
"part of replica identity" --> "part of the replica identity"
"UPDATE and DELETE" --> "UPDATE or DELETE"
--
Kind Regards,
Peter Smith.
Fujitsu Australia.
On Wed, Jan 5, 2022 at 4:34 PM Peter Smith wrote:
>
> I have reviewed again the source code for v58-0001.
>
> Below are my review comments.
>
> Actually, I intend to fix most of these myself for v59*, so this post
> is just for records.
>
&g
FYI - v58 is currently known to be broken due to a recent commit [1].
I plan to post a v59* later today to address this as well as other
recent review comments.
--
[1]
https://github.com/postgres/postgres/commit/6ce16088bfed97f982f66a9dc17b8364df289e4d
Kind Regards,
Peter Smith.
Fujitsu
I saw one (and then went looking and found some more) enum with a
trailing comma.
These are quite rare in the PG src, so I doubt they are intentional.
PSA a patch to remove the trailing commas for all that I found.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
v1-0001-Remove-trailing
On Thu, Jan 6, 2022 at 12:23 PM Tom Lane wrote:
>
> Thomas Munro writes:
> > On Thu, Jan 6, 2022 at 12:56 PM Peter Smith wrote:
> >> These are quite rare in the PG src, so I doubt they are intentional.
> >> PSA a patch to remove the trailing commas for all that I
hat no information was accidentally lost along the way. We
understand that prior to the final commit this will all need to be
fused together just like you are suggesting.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
ntly no typedef for the enum
ReorderBufferChangeType.
Of course, it is easy to add a typedef and then this 'enum' is not
needed in the signature, but I wasn't sure if adding a new typedef
strictly belonged as part of this Row-Filter patch or not.
--
Kind Regards.
Peter Smith.
Fujitsu Australia.
bactions can be used for row filtering.
>
Fixed in v59* [1]
--
[1]
https://www.postgresql.org/message-id/CAHut%2BPsiw9fbOUTpCMWirut1ZD5hbWk8_U9tZya4mG-YK%2Bfq8g%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
On Wed, Jan 5, 2022 at 4:26 PM Amit Kapila wrote:
>
> On Tue, Jan 4, 2022 at 12:15 PM Peter Smith wrote:
> >
> > On Fri, Dec 31, 2021 at 12:39 AM houzj.f...@fujitsu.com
> > wrote:
> > > > 3) v55-0002
> > > > +static bool pgoutput_row_filter_u
On Wed, Jan 5, 2022 at 4:34 PM Peter Smith wrote:
>
> I have reviewed again the source code for v58-0001.
>
> Below are my review comments.
>
> Actually, I intend to fix most of these myself for v59*, so this post
> is just for records.
>
&g
--
[1]
https://www.postgresql.org/message-id/CAHut%2BPsiw9fbOUTpCMWirut1ZD5hbWk8_U9tZya4mG-YK%2Bfq8g%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
On Wed, Jan 5, 2022 at 1:05 PM wangw.f...@fujitsu.com
wrote:
>
> On Thu, Jan 4, 2022 at 00:54 PM Peter Smith wrote:
> > Modified in v58 [1] as suggested
> Thanks for updating the patches.
> A few comments about v58-0001 and v58-0002.
>
> v58-0001
> 1.
> How about m
On Wed, Jan 5, 2022 at 1:05 PM wangw.f...@fujitsu.com
wrote:
>
> On Thu, Jan 4, 2022 at 00:54 PM Peter Smith wrote:
> > Modified in v58 [1] as suggested
> Thanks for updating the patches.
> A few comments about v58-0001 and v58-0002.
>
> v58-0001
> 1.
> How about m
a single statement so the parentheses are not needed here.
~~
6. src/include/replication/logicalproto.h
+extern void logicalrep_write_update_cached(StringInfo out,
TransactionId xid, Relation rel,
+TupleTableSlot *oldtuple, TupleTableSlot *newtuple,
+bool binary);
This extern seems unused ???
Kind Regards,
Peter Smith.
Fujitsu Australia
unexpected object depending on column: publication of table t1
in publication p1
test_pub=#
~~
But the message looks OK. What exactly was your expectation for this
review comment?
--
Kind Regards,
Peter Smith.
Fujitsu Australia.
Col-Filtering".
Thoughts?
--
Kind Regards,
Peter Smith.
Fujitsu Australia
sCache(rftuple);
+ }
Those 3 assignments to the context.pubviaroot/parentid/relid can be
moved to be inside the if (!rfisnull) block, because IIUC they don't
get used otherwise. Or, maybe better to just leave as-is; I am not
sure what is best. Please consider.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
typedefs.list - ReorderBufferChangeType
Actually, the typedef for ReorderBufferChangeType was added in the
62-0001, so this typedef change should've been done in patch 0001 and
it can be removed from patch 0002
--
[1]
https://www.postgresql.org/message-id/CAHut%2BPucFM3Bt-gaTT7Pr-Y_x%2
y the previous call to
pgoutput_row_filter may have transformed it to a different action.
~~~
13. src/tools/pgindent/typedefs.list - RowFilterPubAction
If you choose to keep the typedef for RowFilterPubAction (ref to
comment #1) then it should also be added to the typedefs.list.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
On Thu, Jan 13, 2022 at 5:49 PM Peter Smith wrote:
>
> Thanks for posting the merged v63.
>
> Here are my review comments for the v63-0001 changes.
>
...
> ~~~
>
> 4. src/backend/replication/pgoutput/pgoutput.c - pgoutput_row_filter comments
>
> +
> +/*
> +
ot;,
+ lrel->remoteid,
+ lrel->remoteid,
+ pub_names.data);
I think that trailing ";" of the SQL is not needed, and nearby SQL
execution code does not include one so maybe better to remove it for
consistency.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
although the SQLs looked to be similar
they actually take different PublicationObjSpec execution paths in the
gram.y: i.e. " ColId OptWhereClause" Versus " ColId indirection
OptWhereClause"
~~
So this review comment can be skipped. Both tests should be retained.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
f unnecessary due to partition and the ancestor
* having identical TupleDesc.
*/
- TupleConversionMap *map;
+ AttrMap *map;
} RelationSyncEntry;
I wondered if you should also rename this member to something more
meaningful like 'attrmap' instead of just 'map'.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
and so could be a
local (as you say), but I felt the code consistency and future-proof
benefits outweighed the idea of reducing the code to bare minimum
required to work just "because we can".
So I don't plan to change this, but if you still feel strongly that
the parameter must be removed please give a convincing reason.
Kind Regards,
Peter Smith.
Fujitsu Australia.
finished using the ent.
Kind Regards,
Peter Smith.
Fujitsu Australia
v1-0001-Fix-for-stream_cleanup_files-HASH_REMOVE.patch
Description: Binary data
On Sun, Mar 21, 2021 at 8:54 PM Amit Kapila wrote:
>
> On Sat, Mar 20, 2021 at 12:54 PM Peter Smith wrote:
> >
> > PSA my patch to correct this by firstly doing a HASH_FIND, then only
> > HASH_REMOVE after we've finished using the ent.
> >
>
> Why can
On Mon, Mar 22, 2021 at 9:21 AM Thomas Munro wrote:
>
> On Mon, Mar 22, 2021 at 10:50 AM Peter Smith wrote:
> > The real problem isn't the Assert. It's all those other usages of ent
> > disobeying the API rule: "(NB: in the case of the REMOVE action, the
>
now what do you think about the changes?
>
Hi Amit.
PSA a small collection of feedback patches you can apply on top of the
patch v65-0001 if you decide they are OK.
(There are all I have found after a first pass over all the recent changes).
------
Kind Regards,
Peter Smith.
Fujitsu Au
On Mon, Mar 22, 2021 at 6:27 PM Peter Smith wrote:
>
> On Sun, Mar 21, 2021 at 6:37 PM Amit Kapila wrote:
> >
> > I have further updated the patch to implement unique GID on the
> > subscriber-side as discussed in the nearby thread [1]. That requires
> > some change
an pgindent, (d) modified tests to use standard
> wait_for_catch function and removed few tests to reduce the time and
> to keep regression tests reliable.
I checked all v65* / v66* differences and found only two trivial comment typos.
PSA patches to fix those.
----
Kind Regards,
Peter Smi
On Tue, Mar 23, 2021 at 10:44 AM Peter Smith wrote:
>
> On Mon, Mar 22, 2021 at 11:51 PM Amit Kapila wrote:
> >
> > I have incorporated all your changes and additionally made few more
> > changes (a) got rid of LogicalRepBeginPrepareData and instead used
> > Logical
On Tue, Mar 23, 2021 at 9:01 PM Peter Smith wrote:
>
> On Tue, Mar 23, 2021 at 10:44 AM Peter Smith wrote:
> >
> > On Mon, Mar 22, 2021 at 11:51 PM Amit Kapila
> > wrote:
> > >
> > > I have incorporated all your changes and additionally
On Wed, Mar 24, 2021 at 11:31 PM Amit Kapila wrote:
>
> On Tue, Mar 23, 2021 at 3:31 PM Peter Smith wrote:
> >
> > On Tue, Mar 23, 2021 at 10:44 AM Peter Smith wrote:
> > >
> > > PSA patches to fix those.
> > >
> >
> > Hi Amit.
> &
On Thu, Mar 25, 2021 at 1:40 PM Peter Smith wrote:
>
> On Wed, Mar 24, 2021 at 11:31 PM Amit Kapila wrote:
> >
> > On Tue, Mar 23, 2021 at 3:31 PM Peter Smith wrote:
> > >
> > > On Tue, Mar 23, 2021 at 10:44 AM Peter Smith
> > > wr
as UNKNOWN is going to clash [1] with something else, which
IIUC is why the enums all have prefixes in the first place.
--
[1]
https://stackoverflow.com/questions/35380279/avoid-name-collisions-with-enum-in-c-c99
Kind Regards,
Peter Smith.
Fujitsu Australia
xist
2021-03-30 14:17:37.567 AEDT [22317] STATEMENT: DROP SUBSCRIPTION tap_sub;
--
PSA a small patch which simply removes this prefix "The error was:"
--
Kind Regards,
Peter Smith.
Fujitsu Australia
v1-0001-Remove-redundant-errdetail-The-error-was.patch
Description: Binary data
On Tue, Mar 30, 2021 at 5:10 PM Tom Lane wrote:
>
> Peter Smith writes:
> > There are a couple of error messages within the logical replication
> > code where the errdetail text includes a prefix of "The error was:"
>
> Hmm, isn't project style more usual
e
same - "tablesync slots"
--
Kind Regards,
Peter Smith.
Fujitsu Australia
v1-0001-Use-consistent-terminology-for-tablesync-slots.patch
Description: Binary data
On Tue, Mar 30, 2021 at 8:14 PM Amit Kapila wrote:
>
> On Tue, Mar 30, 2021 at 2:21 PM Peter Smith wrote:
> >
> > Hi,
> >
> > The logical replication tablesync worker creates tablesync slots.
> >
> > Previously some PG docs pages were referring to these
On Thu, Apr 1, 2021 at 4:58 PM Ajin Cherian wrote:
>
>
>
> On Thu, Apr 1, 2021 at 2:29 PM Amit Kapila wrote:
>>
>> On Tue, Mar 30, 2021 at 5:34 AM Peter Smith wrote:
>> >
>> > Please find attached the latest patch set v68*
>> >
>>
>
streamed transactions)."
I think there should be consistent wording used on this page where possible.
--
[1]
https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/String.html
[2]
https://www.postgresql.org/docs/devel/protocol-logicalrep-message-formats.html
Kind Regards,
Peter Smith.
Fujitsu Australia
On Thu, Apr 8, 2021 at 12:56 PM Amit Kapila wrote:
>
> On Thu, Apr 8, 2021 at 3:49 AM Peter Smith wrote:
> >
> > On Wed, Apr 7, 2021 at 10:15 PM Amit Kapila wrote:
> > >
> > > On Wed, Apr 7, 2021 at 1:11 PM Ajin Cherian wrote:
> >
> > 3.
> &
o you have any objection to me removing them?
Otherwise, it might seem strange to document a flag that has no function.
--
KInd Regards,
Peter Smith.
Fujitsu Australia
On Fri, Apr 9, 2021 at 6:40 PM Amit Kapila wrote:
>
> On Fri, Apr 9, 2021 at 12:33 PM Peter Smith wrote:
> >
> > On Mon, Dec 14, 2020 at 8:27 PM Amit Kapila wrote:
> > >
> > > 2.
> > > + /*
> > > + * Flags are determined from the state of th
PSA a patch to fix a typo found on this page [1],
"preapre_end_lsn" -> "prepare_end_lsn"
--
[1] https://www.postgresql.org/docs/devel/logicaldecoding-output-plugin.html
Kind Regards,
Peter Smith.
Fujitsu Australia
fix_typo.patch
Description: Binary data
r_type == SERVER_TYPE_STANDBY)))
{
- /* Not writable; fail this connection. */
+ if (conn->which_primary_or_rw_host == -2)
+ {
+ /*
+ * This scenario is possible only for the
+ * prefer-standby type for the next pass of the
+ * list of connections as it couldn't find any
+ * servers that are read-only.
+ */
+ goto consume_checked_target_connection;
+ }
Is this goto consume_checked_target_connection deliberate?
Previously (in the v17 patch) there was a another label, and so this
same code did goto consume_checked_write_connection;
The v17 code seems more correct than the current v18 code, which is
now jumping to a label not even in the same case block!
Kind Regards,
Peter Smith.
Fujitsu Australia
On Thu, Aug 20, 2020 at 12:11 PM osumi.takami...@fujitsu.com
wrote:
> I have fixed my patch again.
Hi Osumi-san,
FYI - The latest patch (v06) has conflicts when applied.
Kind Regards,
Peter Smith.
Fujitsu Australia
with what is already there?
e.g. split_to_table, string_split_to_table, etc.
Kind Regards,
Peter Smith.
Fujitsu Australia
mitter".
Kind Regards,
Peter Smith.
Fujitsu Australia
f function name would be more consistent
>>> with what is already there?
>>> e.g. split_to_table, string_split_to_table, etc.
>>
>> I don't agree. This function is twin (with almost identical behaviour) for
>> "string_to_array" function, so I think so the name is correct.
OK
Kind Regards,
Peter Smith.
Fujitsu Australia
st patch.
They seem 1000's away from the next nearest oid.
I was curious about the reason for those particular numbers (8432, 8433)?
Kind Regards,
Peter Smith.
Fujitsu Australia
REPLACE TRIGGER to replace a regular trigger")));
ereport(ERROR, (errcode(ERRCODE_DUPLICATE_OBJECT),
errmsg("trigger \"%s\" for relation \"%s\" is a constraint trigger", ...),
errhint("use CREATE OR REPLACE CONSTRAINT to replace a constraint
trigger")));
---
COMMENT trigger.c (comment wording)
+ * In case of replace trigger, trigger should no-more dependent on old
+ * referenced objects. Always remove the old dependencies and then
Needs re-wording.
Kind Regards,
Peter Smith.
Fujitsu Australia
t for "can't replace regular trigger with constraint trigger""
e.g. test for "can't replace constraint trigger with regular trigger"
etc.
COMMENT (trigger with pending events)
This is another test where the complexity of the functions
("not_replaced", and "fail_to_replace") seemed excessive.
I think just calling these "funcA" and "funcB" as mentioned above
would be easier, and would serve just as well.
Kind Regards,
Peter Smith.
Fujitsu Australia
hanks for teaching me!
===
I have re-checked the string_to_table_20200825.patch.
Everything looks good to me now, so I am marking this as "ready for committer".
Kind Regards,
Peter Smith.
Fujitsu Australia
Hello.
FYI - that patch has conflicts when applied.
Kind Regards
Peter Smith
Fujitsu Australia.
On Thu, Aug 27, 2020 at 3:11 PM vignesh C wrote:
>
> On Tue, Jul 14, 2020 at 12:17 PM vignesh C wrote:
> >
> > On Tue, Jul 14, 2020 at 11:13 AM David Rowley wrote:
> > >
On Thu, Sep 3, 2020 at 8:30 AM Tom Lane wrote:
> The proposed tests seemed mighty duplicative, and they even contained
> syntax errors, so I didn't believe that they were carefully considered.
Can you please share examples of what syntax errors were in those
previous tests?
Kind Reg
rigger my_trig
+ after insert on my_table
+ for each row execute procedure funcB(); --should fail
+ERROR: trigger "my_trig" for relation "my_table" is a constraint trigger
+HINT: use CREATE OR REPLACE CONSTRAINT TRIGGER to replace a costraint trigger
I think the first "--should fail" comment is misleading. First time is OK.
Kind Regards,
Peter Smith.
Fujitsu Australia
cro-optimisation is worth doing is another question.
---
Kind Regards,
Peter Smith.
Fujitsu Australia
On Sun, Aug 30, 2020 at 5:25 PM vignesh C wrote:
>
> On Thu, Aug 27, 2020 at 11:02 AM Peter Smith wrote:
> >
> > Hello.
> >
> > FYI - that patch has conflicts wh
eate a new trigger, or replace an
existing definition."
Shouldn't the "Notes" include information about restrictions when
using OR REPLACE
e.g. cannot replace triggers with triggers of a different kind
e.g. cannot replace triggers with pending events
What do you think?
Kind Regards,
Peter Smith.
Fujitsu Australia
th a different type of trigger, that
means it is impossible to replace regular trigger with constraint
trigger and vise versa.
AFTER (suggestion)
You cannot replace triggers with a different type of trigger. That
means it is impossible to replace a regular trigger with a constraint
trigger, and vice ver
On Thu, Sep 10, 2020 at 12:34 PM osumi.takami...@fujitsu.com
wrote:
> I attached the v11 patch.
The v11 patch looked OK to me.
Since I have no more review comments I am marking this as "ready for committer".
Kind Regards,
Peter Smith.
Fujitsu Australia
43C43348A4993FDFE550%40TYAPR01MB2990.jpnprd01.prod.outlook.com
[3] -
https://www.postgresql.org/message-id/OSBPR01MB4888CBD08DDF73721C18D2C0ED790%40OSBPR01MB4888.jpnprd01.prod.outlook.com
Kind Regards,
Peter Smith.
Fujitsu Australia
e the table UNLOGGED in the
first place? (or ALTER it to set UNLOGGED just one time and then leave
it as UNLOGGED).
Kind Regards,
Peter Smith.
Fujitsu Australia
]
https://www.postgresql.org/message-id/CAHut%2BPvJMRB-ZyC80we2kiUFv4cVjmA6jxXpEMhm1rmz%3D1ryeA%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
00) AND (c < 100)))
>
I also reported the same as this some months back, but at that time it
was rejected citing some pg_dump patch. (Please see [1] #14).
--
[1]
https://www.postgresql.org/message-id/532a18d8-ce90-4444-8570-8a9fcf09f329%40www.fastmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
r explanation what does "valid" mean.
>
Updated comment in v34. [1]
--
[1]
https://www.postgresql.org/message-id/CAHut%2BPvWk4w%2BNEAqB32YkQa75tSkXi50cq6suV9f3fASn5C9NA%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia.
nd how to allow UDFs. Do we want to have an
> additional label for it or can we come up with something which allows
> the user to continue replication even if she has dropped the object
> used in the function? It seems like we can limit the scope of base
> patch functionality to allow the use of immutable built-in functions
> in row filter expressions.
>
OK, immutable system functions are now allowed in v34 [1]
--
[1]
https://www.postgresql.org/message-id/CAHut%2BPvWk4w%2BNEAqB32YkQa75tSkXi50cq6suV9f3fASn5C9NA%40mail.gmail.com
Kind Regards,
Peter Smith
Fujitsu Australia
PSA a smalll patch to fix some typos (acccidental 3x repeated
lettters) in code commments.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
v1-0001-Fix-PG-comment-typos.patch
Description: Binary data
tch (which is independent of the
others) is the only patch currently working, so I am attaching it so
at least the cfbot can have something to run.
--
[1]
https://github.com/postgres/postgres/commit/5a2832465fd8984d089e8c44c094e6900d987fcd
Kind Regards,
Peter Smith.
Fujitsu Australia
v35-0
While you are changing these, maybe also change:
Before: PUBLICATIONOBJ..._CURRSCHEMA
After: PUBLICATIONOBJ..._CUR_SCHEMA
Which seems more readable to me.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
1 patch [1]
--
[1]
https://www.postgresql.org/message-id/CAFPTHDYKfxTr2zpA-fC12u%2BhL2abCc%3D276OpJQUTyc6FBgYX9g%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
/5a2832465fd8984d089e8c44c094e6900d987fcd
[2] https://www.postgresql.org/docs/devel/sql-alterpublication.html
Kind Regards,
Peter Smith.
Fujitsu Australia
On Thu, Nov 4, 2021 at 11:55 AM houzj.f...@fujitsu.com
wrote:
>
> On Thurs, Nov 4, 2021 8:12 AM Peter Smith wrote:
> > FYI - I found a small problem with one of the new PublicationObjSpec parser
> > error messages that was introduced by the recent schema publication commit
&g
any current PG
behaviour, but doing this will let the new row-filter feature work in
a consistent/predictable/sane way.
Thoughts?
--
Kind Regards,
Peter Smith.
Fujitsu Australia
On Thu, Nov 4, 2021 at 2:08 PM Amit Kapila wrote:
>
> On Thu, Nov 4, 2021 at 8:17 AM Peter Smith wrote:
> >
> >
> > PROPOSAL
> >
> > I propose that we change the way duplicate tables are processed to
> > make it so that it is always the *last* one th
On Thu, Nov 4, 2021 at 3:24 PM vignesh C wrote:
>
> On Thu, Nov 4, 2021 at 5:41 AM Peter Smith wrote:
> >
> > FYI - I found a small problem with one of the new PublicationObjSpec
> > parser error messages that was introduced by the recent schema
> > publication
[1]
--
[1]
https://www.postgresql.org/message-id/CAHut%2BPtRdXzPpm3qv3cEYWWfVUkGT84EopEHxwt95eo_cG_3eQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
qv3cEYWWfVUkGT84EopEHxwt95eo_cG_3eQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia.
te)
> + if (pub->pubactions.pubdelete || pub->pubactions.pubupdate)
> {
> char replica_identity = rel->rd_rel->relreplident;
>
Fixed in v37-0006 [1]
--
[1]
https://www.postgresql.org/message-id/CAHut%2BPtRdXzPpm3qv3cEYWWfVUkGT84EopEHxwt95eo_cG_3eQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
t is an interesting idea. I had
thought the same as this some time ago but never acted on it. I will
try implementing this idea as a separate new patch because it probably
needs to be performance tested against the current code just in case
the extra effort to combine the expressions outweighs a
ias as expected.
------
[1]
https://github.com/postgres/postgres/commit/5a2832465fd8984d089e8c44c094e6900d987fcd
Kind Regards,
Peter Smith.
Fujitsu Australia
pubobj->location));
> +
>
> This change looks a bit ad-hoc to me. Can we handle this at a later
> point of time in publicationcmds.c?
>
Fixed in v38-0001 [1].
--
[1]
https://www.postgresql.org/message-id/CAHut%2BPvWCS%2BW_OLV60AZJucY1RFpkXS%3DhfvYWwpwyMvifdJxiQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
On Mon, Nov 8, 2021 at 5:53 PM houzj.f...@fujitsu.com
wrote:
>
> On Fri, Nov 5, 2021 1:14 PM Peter Smith wrote:
> > PSA new set of v37* patches.
>
> Thanks for updating the patches.
> Few comments:
>
> 1) v37-0001
>
> I think it might be better to also
On Tue, Nov 9, 2021 at 2:03 PM tanghy.f...@fujitsu.com
wrote:
>
> On Friday, November 5, 2021 1:14 PM, Peter Smith
> wrote:
> >
> > PSA new set of v37* patches.
> >
>
> Thanks for your patch. I have a problem when using this patch.
>
> The document a
and execute it only once.
>
Fixed in v38-0003 [1].
--
[1]
https://www.postgresql.org/message-id/CAHut%2BPvWCS%2BW_OLV60AZJucY1RFpkXS%3DhfvYWwpwyMvifdJxiQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
On Wed, Nov 10, 2021 at 4:57 PM houzj.f...@fujitsu.com
wrote:
>
> On Wed, Nov 10, 2021 10:48 AM Amit Kapila wrote:
> > On Tue, Nov 9, 2021 at 2:22 PM houzj.f...@fujitsu.com wrote:
> > >
> > > On Fri, Nov 5, 2021 4:49 PM Amit Kapila wrote:
> > > > O
place like they were in the 0001 patch.
-
[1]
https://www.postgresql.org/message-id/CAA4eK1%2BXoD49bz5-2TtiD0ugq4PHSRX2D1sLPR_X4LNtdMc4OQ%40mail.gmail.com
[2]
https://www.postgresql.org/message-id/20210128022032.eq2qqc6zxkqn5syt%40alap3.anarazel.de
Kind Regards,
Peter Smith.
Fujitsu Australia
ypedef enum ReorderBufferChangeType
{
REORDER_BUFFER_CHANGE_INSERT,
REORDER_BUFFER_CHANGE_UPDATE,
@@ -65,7 +65,7 @@ enum ReorderBufferChangeType
REORDER_BUFFER_CHANGE_INTERNAL_SPEC_CONFIRM,
REORDER_BUFFER_CHANGE_INTERNAL_SPEC_ABORT,
REORDER_BUFFER_CHANGE_TRUNCATE
-};
+} ReorderBufferChangeType;
This new typedef can be added to src/tools/pgindent/typedefs.list.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
ales_publication FOR ALL
TABLES IN SCHEMA marketing, sales;
+
--
[1] https://www.postgresql.org/docs/devel/sql-createpublication.html
[2] https://www.postgresql.org/docs/devel/sql-createsubscription.html
Kind Regards,
Peter Smith.
Fujitsu Australia
On Wed, Nov 17, 2021 at 11:45 PM Daniel Gustafsson wrote:
>
> Pushed, thanks for review!
>
Thanks!
--
Kind Regards,
Peter Smith.
Fujitsu Australia
uld
> connect the expressions by OR, not AND.
>
Fixed in V40 [1]
-
[1]
https://www.postgresql.org/message-id/CAHut%2BPv-D4rQseRO_OzfEz2dQsTKEnKjBCET9Z-iJppyT1XNMQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
On Mon, Nov 15, 2021 at 9:31 PM Amit Kapila wrote:
>
> On Wed, Nov 10, 2021 at 12:36 PM Peter Smith wrote:
> >
> > On Mon, Nov 8, 2021 at 5:53 PM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > 3) v37-0005
> > >
> > > - no par
LOG: terminating any other active
> server processes
>
>
> Backtrace is attached. I think maybe the problem is related to the below
> change in 0003 patch:
>
> + free(entry->exprstate);
>
Fixed in V40 [1] using a fix provided by Greg Nancarrow.
-
[1]
https://www.postgresql.org/message-id/CAHut%2BPv-D4rQseRO_OzfEz2dQsTKEnKjBCET9Z-iJppyT1XNMQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
ostgres=# select * from t;
>a
>
> ab
> (1 row)
>
> The second record can’t be replicated.
>
> By the way, when only applied 0001 patch, I couldn't reproduce this bug.
> So, I think it was related to the later patches.
>
Fixed in V40-0003 [1] using a fix provided by Greg Nancarrow.
-
[1]
https://www.postgresql.org/message-id/CAHut%2BPv-D4rQseRO_OzfEz2dQsTKEnKjBCET9Z-iJppyT1XNMQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
On Mon, Nov 15, 2021 at 12:01 PM Peter Smith wrote:
>
> On Fri, Nov 12, 2021 at 9:19 PM Ajin Cherian wrote:
> >
> > Attaching version 39-
>
> Here are some review comments for v39-0006:
>
> 1)
> @@ -261,9 +261,9 @@ rowfilter_expr_replident_walker(Node *node,
&g
e that if the attribute is not NULL in the old slot
> still it is stored as VARATT_IS_EXTERNAL_ONDISK? I think no, so
> instead of adding
> this last condition in check it should be asserted inside the if check.
>
Fixed in v40 [1]
-
[1]
https://www.postgresql.org/message-id/CAHut%2BPv-D4rQseRO_OzfEz2dQsTKEnKjBCET9Z-iJppyT1XNMQ%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
201 - 300 of 2023 matches
Mail list logo
