On Wed, Nov 22, 2017 at 2:36 PM, Amit Langote <langote_amit...@lab.ntt.co.jp
> wrote:
> On 2017/11/22 17:42, amul sul wrote:
> > On Wed, Nov 22, 2017 at 11:38 AM, Amit Langote wrote:
> >> On 2017/11/22 13:45, Rushabh Lathia wrote:
> >>> Attaching pat
Hi
Here is a patch for fixing the function
ExecBuildSlotPartitionKeyDescription()
prologue.
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
diff --git a/src/backend/executor/execPartition.c b/src/backend/executor/execPartition.c
index d275cef..2fc411a 100644
--- a/src/backend/executor
On Sat, Dec 16, 2017 at 12:40 AM, Robert Haas <robertmh...@gmail.com> wrote:
> On Fri, Dec 15, 2017 at 12:40 PM, Peter Eisentraut
> <peter.eisentr...@2ndquadrant.com> wrote:
> > On 12/14/17 22:59, Rushabh Lathia wrote:
> >> I noted that no_priv_msg and
ould
prefer the array rather then code been fitted into the function.
> --
> Peter Eisentraut http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
--
Rushabh Lathia
On Fri, Dec 15, 2017 at 3:32 AM, Michael Paquier <michael.paqu...@gmail.com>
wrote:
> On Fri, Dec 15, 2017 at 12:18 AM, Peter Eisentraut
> <peter.eisentr...@2ndquadrant.com> wrote:
> > On 12/13/17 23:31, Rushabh Lathia wrote:
> >> PFA patch, where introduced new
at
appropriate places.
Also update the necessary "make check" expected output changes.
Regards,
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
diff --git a/src/backend/catalog/aclchk.c b/src/backend/catalog/aclchk.c
index e481cf3..680ef18 100644
--- a/src/backend/catalog/aclchk.c
+++ b/src/backe
}
But after commit, condition for isnull is missing. It doesn't look
intentional,
is it?
Attaching patch to fix as well as regression test.
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
diff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c
index 67d4c2
Thanks Tels for reviewing the patch.
On Fri, Dec 8, 2017 at 2:54 PM, Tels <nospam-pg-ab...@bloodgate.com> wrote:
> Hello Rushabh,
>
> On Fri, December 8, 2017 2:28 am, Rushabh Lathia wrote:
> > Thanks for review.
> >
> > On Fri, Dec 8, 2017 at 6:27 AM, Pet
group by rollup((deptno,epno)) order by 1 asc;
without the ROLLUP, I don't see any problem with results.
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
Hi,
There is multiple return statement in llvm_function_reference
and that's definitely looks typo. Here is the patch to fix the
same.
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
diff --git a/src/backend/jit/llvm/llvmjit.c b/src/backend/jit/llvm/llvmjit.c
index daae964..5d0cdab 100644
--- a/src
On Sat, Jan 6, 2018 at 3:47 AM, Peter Geoghegan <p...@bowt.ie> wrote:
> On Tue, Jan 2, 2018 at 8:43 PM, Rushabh Lathia <rushabh.lat...@gmail.com>
> wrote:
> > I agree that plan_create_index_workers() needs to count the leader as a
> > normal worker for the CREATE
tenance.
> >
> > Good point.
>
> WFM.
>
>
This is good point. I agree with max_parallel_maintenance_workers.
> --
> Peter Geoghegan
>
--
Rushabh Lathia
uple is same
as newtuple, then we don't require to free the trigtuple.
ExecBRDeleteTriggers() also does the similar things, but their we don't
need a check because it doesn't care about the return tuple.
PFA patch which add a check to not free the trigtuple if newtuple is same
as trigtuple and also
On Wed, Jan 3, 2018 at 9:11 AM, Peter Geoghegan <p...@bowt.ie> wrote:
> On Tue, Jan 2, 2018 at 1:38 AM, Rushabh Lathia <rushabh.lat...@gmail.com>
> wrote:
> > Need to do after the indexRelation build. So I added after update of
> > pg_inde
eciated.
>
> --
> Álvaro Herrerahttps://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
>
--
Rushabh Lathia
www.EnterpriseDB.com
row)
postgres@90169=#select format_type('bit'::regtype, null);
format_type
-
"bit"
(1 row)
Is this expected behaviour? attaching patch to get back the older
behaviour.
Thanks,
Regards,
Rushabh Lathia
www.EnterpriseDB.com
diff --git a/src/backend/utils/adt/format_ty
(a int, b char) partition by list (a);
> create table foo1 partition of foo for values in (1) partition by list (b);
> create table foo1a (a, b) as values (2, 'b');
>
> -- note that we're attaching to foo1, not foo
> alter table foo1 attach partition foo1a for values in ('a');
>
> If we didn't include foo1's (the parent) constraint (that is, a = 1), the
> above command will wrongly succeed. It must include a = 1 in the
> constraint to be be checked when scanning foo1a.
>
> Although, I noticed there is no test covering this.
>
> >> BTW, I think this is already broken for the case where the default
> >> partition is partitioned and you attach a partition colliding with a row
> >> that's being concurrently inserted in a partition of the default
> >> partition, though I didn't bother to write a test for that.
> >
> > How is it broken? Every attaching partitions are checked for the
> > specified partition bound and every partitions of the default
> > partition are also checked against the new default part bound. We
> > already hold required locks on all the participants.
>
> Yes, concurrent insertions to either the default partition or any of its
> partitions couldn't be occurring as we'd have locked them.
>
> >> Anyway, I'm just an onlooker fixing a CommandCounterIncrement change.
> >
> > It's reassuring. Thanks.
>
> Yes, thank you for taking the time out to clean things up.
>
> Thanks,
> Amit
>
> [1]
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=
> commitdiff;h=972b6ec20bf
>
>
--
Rushabh Lathia
0300
Fix relcache handling of the 'default' partition
Regards,
--
Rushabh Lathia
On Tue, Mar 20, 2018 at 6:38 AM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 3/19/18 03:25, Rushabh Lathia wrote:
> > For the FUNCTION when we have single OUT/INOUT parameter
> > the return type for that function will be set to the type of OUT
> pa
t4b"
Here error message says that calling procedures with output arguments is not
supported in SQL functions. Whereas here it's getting called from the SQL
procedure. So error message needs to be changed.
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
se anyone looking
> at regress.c would naturally assume that anything in there is
> being exercised.
>
> regards, tom lane
>
>
--
Rushabh Lathia
to look
> as much as possible like before, and added a regression test.
>
Thanks Tom.
Regards,
Rushabh Lathia
www.EnterpriseDB.com
: Tue Nov 20 15:36:57 2018 -0800
Remove WITH OIDS support, change oid catalog column visibility.
PFA patch to fix the issue. I also added the testcase for the
same into the regression.
regards,
Rushabh Lathia
www.EnterpriseDB.com
diff --git a/src/backend/commands/trigger.c b/src/backend
While looking code further around this, I realized that we need
similar kind of fix for bitmap as well as index only scan as well.
Here is the patch, which does similar fix for bitmap and indexonly
scans.
Thanks,
On Fri, Nov 23, 2018 at 6:47 PM Rushabh Lathia
wrote:
>
>
> On Fr
On Fri, Nov 23, 2018 at 3:33 AM David Rowley
wrote:
> On Thu, 22 Nov 2018 at 22:33, Rushabh Lathia
> wrote:
> > CREATE TABLE foo (x int primary key);
> > INSERT INTO foo VALUES (1), (2), (3), (4), (5);
> >
> > CREATE OR REPLACE FUNCTION f1(a int) RETURNS int
> &
IndexScan() or teach ExecInitIndexScan() to take AccessShareLock
on the scan coming from CMD_DELETE.
Thoughts/Comments?
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
oesn't
find it there, just throws an error. Maybe require fix
into ECPGclose() - rather than throwing an error continue
executing statement "CLOSE cur_name" with ecpg_do().
Attaching the ECPG program for reference.
Thanks,
--
Rushabh Lathia
www.EnterpriseDB.com
test.pgc
Description: Binary data
any idea how to improve the
> situation to not error out on statements that used to work?
>
> Michael
> --
> Michael Meskes
> Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
> Meskes at (Debian|Postgresql) dot Org
> Jabber: michael at xmpp dot meskes dot org
> VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL
>
>
>
--
Rushabh Lathia
had quick glance to the patch - here are few commits:
1)
+if (event_relation->rd_rel->relnatts == 0)
Can't use direct relnatts - as need to consider attisdropped.
2)
I think you may like to change the error message to be in-line with
the other error message in the similar code area.
May be something like:
"could not convert table \"%s\" to a view because table does not have any
column"
Regards,
Rushabh Lathia
www.EnterpriseDB.com
rbid this?
Because pg_dump - produce the output for such case as:
CREATE VIEW public.foo AS
SELECT
FROM public.bar;
which fails to restore because we forbid this in create view:
postgres@20625=#CREATE VIEW public.foo AS
postgres-# SELECT
postgres-#FROM public.bar;
ERROR: view must have at least one column
postgres@20625=#
Given
> that we these days allows selects without columns, I see no reason to
> require this for views. The view error check long predates allowing
> SELECT and CREATE TABLE without columns. I think it's existence is just
> an oversight. Tom, you did relaxed the permissive cases, any opinion?
>
> Greetings,
>
> Andres Freund
>
>
--
Rushabh Lathia
re it doesn't consider the default_tablespace if the parent
partitioned
tablespace is an InvalidOid (which was the care before this commit).
PFA patch to fix the same.
Thanks,
--
Rushabh Lathia
www.EnterpriseDB.com
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
On Fri, May 17, 2019 at 10:30 AM Amit Langote
wrote:
> Agree that this behavior change seems unintentional.
>
> On 2019/05/17 12:40, Rushabh Lathia wrote:
> > Looking at the commit changes, it seems like at condition when no other
> > tablespace is specified, we d
ll = (tbinfo->notnull[j] &&
(!tbinfo->inhNotNull[j] ||
dopt->binary_upgrade));
PFA patch to fix the issue, which allow to dump the NOT NULL
for partition table.
PS: we also need to backport
(!tbinfo->inhNotNull[j] ||
> dopt->binary_upgrade));
>
> PFA patch to fix the issue, which allow to dump the NOT NULL
> for partition table.
>
> PS: we also need to backport this to v11.
>
> Thanks,
> --
> Rushabh Lathia
> www.EnterpriseDB.com
>
>
--
Rushabh Lathia
;update"
13)
* The undo record should be freed by the caller by calling
ReleaseUndoRecord.
* This function will old the pin on the buffer where we read the previous
undo
* record so that when this function is called repeatedly with the same
context
%s/old/hold
I will continue further review for the same patch.
Regards,
--
Rushabh Lathia
www.EntepriseDB.com
ion of macro ‘PQExpBufferBroken’
>if (PQExpBufferBroken())
>
>
I also observed this warning. PFA to fix the same.
pg_gmtime can fail in case of malloc failure:
> + /*
> + * Convert time to a string. Since it's not clear what time zone to use
> + * and since time zone definit
On Thu, Nov 14, 2019 at 6:30 PM Tomas Vondra
wrote:
> On Thu, Nov 14, 2019 at 03:27:42PM +0530, Rushabh Lathia wrote:
> >Today I noticed strange behaviour, consider the following test:
> >
> >postgres@126111=#create table foo ( a text );
> >CREATE TABLE
> >postgr
d
> > need a
> > pretty fast disk (aka M.2 SSD) and network (aka > 1 Gbit) to top these
> > speeds
> > and then you'd use a real CPU for your server, not some poor Intel
> > powersaving
> > surfing thingy-majingy :)
>
> I mean, how fast is in theory doe
Thanks Jeevan for reviewing the patch and offline discussion.
On Mon, Dec 9, 2019 at 11:15 AM Jeevan Chalke <
jeevan.cha...@enterprisedb.com> wrote:
>
>
> On Fri, Dec 6, 2019 at 12:05 PM Rushabh Lathia
> wrote:
>
>>
>>
>> On Fri, Dec 6, 2019 at 1:44 AM R
On Mon, Dec 9, 2019 at 2:52 PM Rushabh Lathia
wrote:
>
> Thanks Jeevan for reviewing the patch and offline discussion.
>
> On Mon, Dec 9, 2019 at 11:15 AM Jeevan Chalke <
> jeevan.cha...@enterprisedb.com> wrote:
>
>>
>>
>> On Fri, Dec 6,
On Thu, Dec 5, 2019 at 12:17 AM Robert Haas wrote:
> On Wed, Dec 4, 2019 at 1:01 PM Rushabh Lathia
> wrote:
> > As per the discussion on the thread, here is the patch which
> >
> > a) Make checksum for manifest file optional.
> > b) Allow user to
On Fri, Dec 6, 2019 at 1:44 AM Robert Haas wrote:
> On Thu, Dec 5, 2019 at 11:22 AM Rushabh Lathia
> wrote:
> > Here is the whole stack of patches.
>
> I committed 0001, as that's just refactoring and I think (hope) it's
> uncontroversial. I think 0002-0005 need to
-based all patch set.
Regards,
--
Rushabh Lathia
www.EnterpriseDB.com
On Tue, Oct 1, 2019 at 5:43 PM Robert Haas wrote:
> On Mon, Sep 30, 2019 at 5:31 AM Jeevan Chalke
> wrote:
> > Entry for directory is not added in manifest. So it might be difficult
> > at clien
On Tue, Nov 19, 2019 at 7:19 PM Andrew Dunstan <
andrew.duns...@2ndquadrant.com> wrote:
>
> On 11/19/19 5:00 AM, Rushabh Lathia wrote:
> >
> >
> > My colleague Suraj did testing and noticed the performance impact
> > with the checksums. On further
Thank you Jeevan for reviewing the patch.
On Thu, Nov 21, 2019 at 2:33 PM Jeevan Chalke <
jeevan.cha...@enterprisedb.com> wrote:
>
>
> On Tue, Nov 19, 2019 at 3:30 PM Rushabh Lathia
> wrote:
>
>>
>>
>> My colleague Suraj did testing and noticed the p
Today I noticed strange behaviour, consider the following test:
postgres@126111=#create table foo ( a text );
CREATE TABLE
postgres@126111=#insert into foo values ( repeat('PostgreSQL is the
world''s best database and leading by an Open Source Community.', 8000));
INSERT 0 1
; and added
> parallel option in all of its tests, to make sure parallel mode works
> expectantly. The one thing that differs from base backup is the file
> checksum reporting. In parallel mode, the total number of checksum failures
> are not reported correctly however it will abort the backup whenever a
> checksum failure occurs. This is because processes are not maintaining any
> shared state. I assume that it's not much important to report total number
> of failures vs noticing the failure and aborting.
>
>
> --
> Asif Rehman
> Highgo Software (Canada/China/Pakistan)
> URL : www.highgo.ca
>
>
--
Rushabh Lathia
he function and indented one level less. And
> I think if you look at this function you'll see a way that you can
> save a *second* level of indentation for much of that code. Please
> check the rest of the patch for similar cases, too.
>
> +static char *
> +nextLine(char *buf)
> +{
> + while (*buf != '\0' && *buf != '\n')
> + buf = buf + 1;
> +
> + return buf + 1;
> +}
>
> I'm pretty sure that my previous review mentioned the importance of
> protecting against buffer overruns here.
>
> +static char *
> +nextWord(char *line)
> +{
> + while (*line != '\0' && *line != '\t' && *line != '\n')
> + line = line + 1;
> +
> + return line + 1;
> +}
>
> Same problem here.
>
> In both cases, ++ is more idiomatic.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Rushabh Lathia
waitevent before getting the data again?
>
> [1] -
> https://www.postgresql.org/message-id/CA%2BTgmobBw-3573vMosGj06r72ajHsYeKtksT_oTxH8XvTL7DxA%40mail.gmail.com
>
Sure, we can try out this and do a similar run to collect the
pg_stat_activity output.
> --
> With Regards,
> Amit Kapila.
> EnterpriseDB: http://www.enterprisedb.com
>
>
>
--
Rushabh Lathia
e patch.
--
> Peter Eisentraut http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
--
Rushabh Lathia
in a single session, it
> will be used in multiple sessions, having an
> option at the per-server level would not be a good idea.
>
> With Regards,
> Bharath Rupireddy.
> EnterpriseDB: http://www.enterprisedb.com
>
>
>
--
Rushabh Lathia
t; Parallel Seq Scan on t (cost=0.00..22450.33 rows=42
> width=105) (actual time=66.396..101.979 rows=33 loops=3)
>Filter: (a < 100)
>Rows Removed by Filter: 00
> Planning Time: 0.154 ms
> Execution Time: 110.158 ms
> (9 rows)
>
> --
> Regards,
> Dilip Kumar
> EnterpriseDB: http://www.enterprisedb.com
>
--
Rushabh Lathia
Regards,
> Bharath Rupireddy.
> EnterpriseDB: http://www.enterprisedb.com
>
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c
index 6d53dc4..97170d3 100644
--- a/src/backend/commands/copy.c
+++ b/src/backend/commands/copy.c
@
at way, we can set it per server so that remote connections to the
> particular server don’t remain idle.
>
>
+1
I have not looked at the implementation, but I agree that here problem
is with postgres_fdw so we should try to solve that by keeping it limited
to postgres_fdw. I liked the idea of passing it as an option to the FDW
connection.
Regards,
>
> --
> Masahiko Sawadahttp://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
>
>
--
Rushabh Lathia
On Thu, Apr 15, 2021 at 7:49 PM Tom Lane wrote:
> Rushabh Lathia writes:
> > Commit mentioned in the $subject changed the FirstBootstrapObjectId
> > (transam.h) from 12000 to 13000. I was trying to understand the reason
> > behind this change, but was not able to gather t
changes? Is it accidental or intentional?
Thanks,
Rushabh Lathia
www.EnterpriseDB.com
,
Rushabh Lathia
www.EnterpriseDB.com
g on PostgreSQL community
> contributions. We're excited to welcome Gurjeet to the team at
> Supabase.
>
> [1]: https://supabase.io/
> [2]: https://gurjeet.singh.im/GurjeetResume.pdf
>
> PS: Hacker News announcement is at https://news.ycombinator.com/item?id=
>
> Best regards,
> --
> Gurjeet Singh http://gurjeet.singh.im/
>
>
>
--
Rushabh Lathia
range to be getting EndOfLog from GetLastSegSwitchData() which
> returns lastSegSwitchLSN while getting EndOfLogTLI from replayEndTLI
> ... because there's also replayEndRecPtr, which seems to go with
> replayEndTLI. It feels like we should use a source for the TLI that
> clearly matches the source for the corresponding LSN, unless there's
> some super-good reason to do otherwise.
>
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
>
>
>
--
Rushabh Lathia
lid, table_toast_map, pg_class_desc,
> - effective_multixact_freeze_max_age);
> + classRel->rd_tableam->taboptions, effective_multixact_freeze_max_age);
> if (tab == NULL)
>
Split the another added parameter to function in the next line.
5)
Overall patch has many indentation issues, I would suggest running the
pgindent to fix those.
Regards
Rushabh Lathia
www.EnterpriseDB.com
.
Regards,
Rushabh Lathia
www.EnterpriseDB.com
ust in time, before the feature freeze deadline.
> --
> Michael
>
--
Rushabh Lathia
therwise not reachable by the current tests.
>
+1 for the idea as it does the better code coverage.
>
> --
> Regards,
> Amul Sul
> EDB: http://www.enterprisedb.com
>
--
Rushabh Lathia
t and to fix the above issue either we need a 4th list or do
changes in the existing list.
Thought/Comments?
Regards,
Rushabh Lathia
www.EnterpriseDB.com
On Tue, Sep 27, 2022 at 7:34 PM Robert Haas wrote:
> On Tue, Sep 27, 2022 at 2:53 AM Rushabh Lathia
> wrote:
> > Yes, I was also thinking to avoid the duplicate logic but couldn't found
> > a way. I did the quick testing with the patch, and reported test is
> working
&
On Mon, Sep 26, 2022 at 11:46 PM Robert Haas wrote:
> On Mon, Sep 26, 2022 at 3:44 AM Rushabh Lathia
> wrote:
> > Commit 6566133c5f52771198aca07ed18f84519fac1be7 ensure that
> > pg_auth_members.grantor is always valid. This commit did changes
> > into shdepDropOwned
OWNER:
- /* If a local object, save it for deletion below */
- if (sdepForm->dbid == MyDatabaseId)
+ /* Save it for deletion below */
Case ending up with above error because of the above removed condition.
Please find the attached patch wh
67 matches
Mail list logo
