Re: C testing for Postgres

2019-07-02 Thread Adam Berlin
> Just to clarify what Adam is proposing in this thread is *not* a fault > injection framework. > Yes, thanks for clarifying Ashwin. Sorry Michael, this testing framework is more like these other frameworks: Java with Junit + Hamcrest: http://hamcrest.org/JavaHamcrest/tutorial Ruby with Rspec:

Re: C testing for Postgres

2019-06-28 Thread Adam Berlin
to use this tool, would the community want to vendor the framework in the Postgres repository, or keep it in a separate repository that produces a versioned shared library? On Fri, Jun 28, 2019 at 5:57 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > On Fri, Jun 28, 2019 at 11:38 AM

C testing for Postgres

2019-06-28 Thread Adam Berlin
t(s). 1 passed, 0 failed, 0 pending ``` Rather than post a patch, I'd rather start a conversation first. I'm guessing there are some improvements that we'd want to make (for example: the Makefile) before commiting a patch. Let's iterate on improvements before creating a formal patch. Thoughts? Tha

Re: COPY FROM WHEN condition

2018-11-09 Thread Adam Berlin
As a newcomer to this patch, when I read this example: COPY table_name WHEN (some_condition) .. I expect COPY to only be run when the condition is true, and I do not expect the WHEN clause to filter rows. I'm curious what you think about: COPY table_name WHERE (some_condition) Users should

Re: Add extension options to control TAP and isolation tests

2018-11-09 Thread Adam Berlin
Nice cleanup. Also, I like the ability to enable/control more types of tests easily from the Makefile. What are the next steps for this patch?