Re: patch to allow disable of WAL recycling

2018-07-11 Thread David Pacheco
On Tue, Jul 10, 2018 at 10:32 PM, Thomas Munro < thomas.mu...@enterprisedb.com> wrote: > On Wed, Jul 11, 2018 at 8:25 AM, Joshua D. Drake > wrote: > > On 07/10/2018 01:15 PM, Jerry Jelinek wrote: > >> > >> Thanks to everyone who took the time to look at the patch and send me > >> feedback. I'm h

Re: patch to allow disable of WAL recycling

2018-07-11 Thread David Pacheco
On Tue, Jul 10, 2018 at 1:34 PM, Alvaro Herrera wrote: > On 2018-Jul-10, Jerry Jelinek wrote: > > > 2) Disabling WAL recycling reduces reliability, even on COW filesystems. > > I think the problem here is that WAL recycling in normal filesystems > helps protect the case where filesystem gets full

Re: Compiler warnings with --enable-dtrace

2018-05-11 Thread David Pacheco
On Sat, May 5, 2018 at 6:22 AM, Thomas Munro wrote: > Hi hackers, > > --enable-dtrace produces compiler warnings about const correctness, > except on macOS. That's because Apple's dtrace produces function > declarations in probes.h that take strings as const char * whereas > AFAIK on all other o