Re: Race between KeepFileRestoredFromArchive() and restartpoint

l/xlogtemp.18799" to > “pg_wal/0001D4530010”: File exists WAL restore/recovery seemed to continue on just fine then. And it would continue on until the pg_wal volume ran out of space unless I was manually rm'ing already-recovered WAL files from the side. -- Don Seiler www.seiler.us

Re: [PATCH] Include application_name in "connection authorized" log message

Thanks for all the guidance! Don. On Fri, Sep 28, 2018, 18:12 Stephen Frost wrote: > Greetings, > > * Stephen Frost (sfr...@snowman.net) wrote: > > * Stephen Frost (sfr...@snowman.net) wrote: > > > I still don't see that as a reason for tools to be suseptible to > serious > > > issues if a

Re: [PATCH] Include application_name in "connection authorized" log message

On Mon, Sep 24, 2018 at 4:10 PM Stephen Frost wrote: > > * Don Seiler (d...@seiler.us) wrote: > > > > OK I created a new function called clean_ascii() in common/string.c. I > call > > this from my new logic in postmaster.c as well as replacing the logic in > &g

Re: [PATCH] Include application_name in "connection authorized" log message

On Tue, Aug 7, 2018 at 12:32 PM Tom Lane wrote: > Don Seiler writes: > > > 1. We want to make a generic, central ascii-lobotomizing function similar > > to check_application_name that we can re-use there and for other checks > (eg > > user name). > > 2. Chan

Re: [PATCH] Include application_name in "connection authorized" log message

plication_name()?) 3. Call this function when storing the value in the port struct. Please let me know if I'm missing/misunderstanding anything. Don. -- Don Seiler www.seiler.us

Re: [PATCH] Include application_name in "connection authorized" log message

On Tue, Aug 7, 2018 at 8:46 AM, Stephen Frost wrote: > Greetings, > > * Don Seiler (d...@seiler.us) wrote: > > On Mon, Jul 30, 2018 at 5:20 AM, Peter Eisentraut < > > peter.eisentr...@2ndquadrant.com> wrote: > > > > > On 13/07/2018 20:20, Don Sei

Re: [PATCH] Include application_name in "connection authorized" log message

On Mon, Jul 30, 2018 at 5:20 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 13/07/2018 20:20, Don Seiler wrote: > > See attached for latest revision. > > This doesn't compile with SSL enabled because there is a comma missing. > Hmm I'll check t

Re: [PATCH] Include application_name in "connection authorized" log message

On Fri, Jul 13, 2018 at 10:13 AM, Don Seiler wrote: > On Fri, Jul 13, 2018 at 9:37 AM, Stephen Frost wrote: > >> >> Don, do you want to update the patch accordingly? If not, I'm happy to >> handle it when I go to commit it, which I'm thinking of doing sometime >

Re: [PATCH] Include application_name in "connection authorized" log message

On Mon, Jul 2, 2018 at 2:13 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 21.06.18 16:21, Don Seiler wrote: > > - (errmsg("connection > > authorized: user=%s database=%s", > > - >

Re: [PATCH] Include application_name in "connection authorized" log message

rent cases were for Stephen's request earlier in this thread. I'm happy to write it either way and agree it would be nice to not have a lot of duplicate code. Do you want me to submit another patch? Don. -- Don Seiler www.seiler.us

Re: [PATCH] Include application_name in "connection authorized" log message

we currently do). > Also, these don't need to be / shouldn't be 3 seperate patches/commits, > and there should be a sensible commit message which explains what the > change is entirely. > After much head scratching/banging on both our parts yesterday, I've finally figured this out. Thanks again for your patience and time. If you could update the patch accordingly and re-send, that'd be > awesome. :) See attached. -- Don Seiler www.seiler.us 0001-Changes-to-add-application_name-to-Port-struct-so-we.patch Description: Binary data

[PATCH] Include application_name in "connection authorized" log message

t; message. Thanks, Don. -- Don Seiler www.seiler.us appname_log.patch Description: Binary data