On Sat, 20 Apr 2024 at 01:36, Tom Lane wrote:
> Japin Li writes:
>> I see [1] has already implemented on login event trigger, why not implement
>> the logoff event trigger?
>
> What happens if the session crashes, or otherwise fails unexpectedly?
>
I am curren
it might be running concurrently, which may lead to the
checking being unstable.
Any thoughts?
[1]
https://www.postgresql.org/message-id/0d46d29f-4558-3af9-9c85-7774e14a7709%40postgrespro.ru
--
Regards,
Japin Li
>From ef7c6aa408d0a6a97d7b0d2e093b71e279b1b0dc Mon Sep 17 00:00:00 2001
From: Japin
On Fri, 19 Apr 2024 at 05:22, Thomas Munro wrote:
> On Thu, Apr 18, 2024 at 6:09 PM Japin Li wrote:
>> /home/japin/postgres/build/../src/include/lib/simplehash.h:1138:9: error:
>> format '%llu' expects argument of type 'long long unsigned int', but
>> argument 4 has typ
ake[1]: *** [Makefile:42: all-common-recurse] Error 2
make: *** [GNUmakefile:11: all-src-recurse] Error 2
For rmid >= RM_MIN_CUSTOM_ID && rmid <= RM_MAX_CUSTOM_ID comparison error, I
found that UINT8_MAX is defined as '255U' on Illumos, however, Linux glibc
uses '255' for UINT8_MAX, which is signed.
[1]
https://github.com/illumos/illumos-gate/blob/master/usr/src/uts/common/sys/int_limits.h#L92
[2]
https://sourceware.org/git/?p=glibc.git;a=blob;f=stdlib/stdint.h;h=bb3e8b5cc61fb3df8842225d2286de67e6f2ffe2;hb=refs/heads/master#l116
--
Regards,
Japin Li
On Wed, 17 Apr 2024 at 14:10, Michael Paquier wrote:
> On Tue, Apr 16, 2024 at 03:31:49PM +0900, Michael Paquier wrote:
>> Indeed, thanks! Will fix and double-check the surroundings.
>
> And fixed this one.
Thanks for the pushing!
--
Regards,
Japin Li
waiting on the lock. Thus, we are
* just trying to acquire the lock conditionally.
*/
--
Regards,
Japin Li
eRelationDesc). RelationParseRelOptions() is going to
> update relation->rd_options, and thus needs a full pg_class tuple to
> fetch options out of it. However, it is really unnecessary to access
> both tuples at the same time. We can use a full tuple, not
> relation->rd_rel, in both cases. See the attached patch.
>
> --
> Regards,
> Alexander Korotkov
+ Form_pg_class classForm = (Form_pg_class) GETSTRUCT(tuple);
+;
There is an additional semicolon in the code.
--
Regards,
Japin Li
cutoff, multi_cutoff,
num_tuples, tups_vacuumed,
tups_recently_dead);
}
It's a bit confusing, so attach a patch to fix this.
--
Regards,
Japin Li
diff --git a/src/include/access/tableam.h
}
+ amoptsfn = relation->rd_indam->amoptions;
+ }
- We can reduce the indentation by moving the classFrom and classTup into
the if branch.
- Perhaps we could remove the brace of else branch to maintain consistency
in the code style.
--
Regards,
Japin Li
On Mon, 25 Mar 2024 at 09:32, Tom Lane wrote:
> Japin Li writes:
>> /home/japin/postgres/debug/../src/bin/pg_dump/pg_dump_sort.c: In function
>> 'repairDependencyLoop':
>> /home/japin/postgres/debug/../src/bin/pg_dump/pg_dump_sort.c:1276:3: error:
>> format not a s
On Sat, 23 Mar 2024 at 01:22, Japin Li wrote:
> On Sat, 23 Mar 2024 at 01:04, Tom Lane wrote:
>> Japin Li writes:
>>> When I try to configure PostgreSQL 16.2 on Illumos using the following
>>> command,
>>> it complains $subject.
>>
>>> .
On Sat, 23 Mar 2024 at 01:04, Tom Lane wrote:
> Japin Li writes:
>> When I try to configure PostgreSQL 16.2 on Illumos using the following
>> command,
>> it complains $subject.
>
>> ./configure --enable-cassert --enable-debug --enable-nls --with-perl \
>&g
Hi, hackers,
When I try to configure PostgreSQL 16.2 on Illumos using the following command,
it complains $subject.
./configure --enable-cassert --enable-debug --enable-nls --with-perl \
--with-python --without-tcl --without-gssapi --with-openssl \
--with-ldap --with-libxml
On Tue, 19 Mar 2024 at 21:05, Alexander Korotkov wrote:
> Hi, Pavel!
>
> On Tue, Mar 19, 2024 at 11:34 AM Pavel Borisov wrote:
>> On Tue, 19 Mar 2024 at 03:34, Alexander Korotkov
>> wrote:
>>>
>>> On Sun, Mar 3, 2024 at 1:50 PM Alexander Korotkov
>>> wrote:
>>> > On Mon, Nov 27, 2023 at
On Fri, 08 Mar 2024 at 13:21, Michael Paquier wrote:
> On Wed, Mar 06, 2024 at 08:24:09AM +0800, Japin Li wrote:
>> On Wed, 06 Mar 2024 at 01:53, Jelte Fennema-Nio wrote:
>>> I think if you remove the EEO_CASE(EEOP_LAST) block the warning should
>>> go away. T
On Wed, 06 Mar 2024 at 01:53, Jelte Fennema-Nio wrote:
> On Tue, 5 Mar 2024 at 15:30, Japin Li wrote:
>> There is a warning if remove it, so I keep it.
>>
>> /home/japin/Codes/postgres/build/../src/backend/executor/execExprInterp.c:118:33:
>> warning: lab
On Tue, 05 Mar 2024 at 22:03, Jelte Fennema-Nio wrote:
> On Tue, 5 Mar 2024 at 14:50, Japin Li wrote:
>> Attach a patch to rewrite dispatch_table array using C99-designated
>> initializer syntax.
>
> Looks good. Two small things:
Thanks for the review.
>
> +
gt; previous versions, I think.
Hi,
Attach a patch to rewrite dispatch_table array using C99-designated
initializer syntax.
>From f398d6d310e9436c5e415baa6fd273981a9e181f Mon Sep 17 00:00:00 2001
From: Japin Li
Date: Tue, 5 Mar 2024 21:32:46 +0800
Subject: [PATCH v1 1/1] Use C99-designated initi
On Wed, 28 Feb 2024 at 00:06, Jelte Fennema-Nio wrote:
> On Tue, 27 Feb 2024 at 16:04, Japin Li wrote:
>> I see the config_group_names[] needs null-terminated because of help_config,
>> however, I didn't find the reference in help_config.c. Is this comment
>> outda
On Tue, 27 Feb 2024 at 19:55, Jelte Fennema-Nio wrote:
> On Tue, 27 Feb 2024 at 12:52, Jelte Fennema-Nio wrote:
>> Attached is an updated patchset to also convert pg_enc2icu_tbl and
>> pg_enc2gettext_tbl. I converted pg_enc2gettext_tbl in a separate
>> commit, because it actually requires some
On Mon, 26 Feb 2024 at 16:41, jian he wrote:
> Hi. minor issues.
>
> @@ -2063,12 +2009,12 @@ find_expr_references_walker(Node *node,
> CoerceViaIO *iocoerce = (CoerceViaIO *) node;
>
> /* since there is no exposed function, need to depend on type */
> - add_object_address(OCLASS_TYPE,
On Tue, 20 Feb 2024 at 13:40, Bharath Rupireddy
wrote:
> On Mon, Feb 19, 2024 at 8:25 PM Japin Li wrote:
>> [2]
>> +# Ensure checkpoint doesn't come in our way
>> +$primary->append_conf('postgresql.conf', qq(
>> +min_wal_size = 2MB
>> +max_wal_size =
On Mon, 19 Feb 2024 at 18:36, Bharath Rupireddy
wrote:
> On Wed, Jan 31, 2024 at 6:30 PM Bharath Rupireddy
> wrote:
>>
>> Needed a rebase due to commit 776621a (conflict in
>> src/test/recovery/meson.build for new TAP test file added). Please
>> find the attached v17 patch.
>
> Strengthened
On Mon, 19 Feb 2024 at 17:14, Andrey M. Borodin wrote:
>> On 18 Feb 2024, at 22:16, Andrey M. Borodin wrote:
>>
>> But it seems a little strange that session 3 did not fail at all
> It was only coincidence. Any test that verifies FATALing out in 100ms can
> fail, see new failure here [0].
>
On Mon, 19 Feb 2024 at 00:56, Tomas Vondra
wrote:
> On 2/18/24 03:30, Li Japin wrote:
>>
>> I find it seems need to change MAX_SIMUL_LWLOCKS if we enlarge the
>> NUM_BUFFER_PARTITIONS,
>> I didn’t find any comments to describe the relation between
>> MAX_SIMUL_LWLOCKS and
>>
On Tue, 30 Jan 2024 at 14:22, Andrey M. Borodin wrote:
>> On 26 Jan 2024, at 19:58, Japin Li wrote:
>>
>> Thanks for updating the patch. Here are some comments for v24.
>>
>> +
>> +Terminate any session that spans longer than the
Junwang, what do you think?
However, checking the reason on the timeout session may cause regression test
failed (as you point in 1), I don't strongly insist on it.
--
Best regards,
Japin Li.
On Thu, 25 Jan 2024 at 21:43, Aleksander Alekseev
wrote:
> Hi,
>
>> I find heapam_relation_copy_data() and index_copy_data() have the following
>> code:
>>
>> dstrel = smgropen(*newrlocator, rel->rd_backend);
>>
>> ...
>>
>> RelationCreateStorage(*newrlocator,
Hi, hackers
I find heapam_relation_copy_data() and index_copy_data() have the following
code:
dstrel = smgropen(*newrlocator, rel->rd_backend);
...
RelationCreateStorage(*newrlocator, rel->rd_rel->relpersistence, true);
The smgropen() is also called by
Hi, hackers
Recently, I'm trying to implement a new TAM for PostgreSQL, I find there is no
API for handling table's option. For example:
CREATE TABLE t (...) USING new_am WITH (...);
Is it possible add a new API to handle table's option in TableAmRoutine?
--
Regrads,
Japin Li.
On Tue, 16 Jan 2024 at 13:15, Bharath Rupireddy
wrote:
> On Tue, Jan 16, 2024 at 10:28 AM Michael Paquier wrote:
>>
>> Hmm. I'd rather have it do something useful in terms of test coverage
>> rather than being just an empty skull.
>>
>> How about adding the same kind of coverage as
On Wed, 03 Jan 2024 at 20:04, Andrey M. Borodin wrote:
>> On 3 Jan 2024, at 16:46, Andrey M. Borodin wrote:
>>
>> I do not understand why, but mailing list did not pick patches that I sent.
>> I'll retry.
>
>
> Sorry for the noise. Seems like Apple updated something in Mail.App couple of
>
On Tue, 26 Dec 2023 at 18:10, Shubham Khanna
wrote:
> On Tue, Dec 26, 2023 at 3:02 PM Japin Li wrote:
>>
>>
>> Hi hacker,
>>
>> As $subject detailed, the tab-complete cannot work such as:
>>
>>CREATE SUBSCRIPTION sub CONNECTION
This has popped up a few times in the past, and it seems to be GCC bug
> 53119. We previously used the {{...}} approach to suppress it. Should
> we do the same here, like attached?
>
> FWIW, in the same file we initialize BlockRefTableSerializedEntry
> variables also with {{0}}.
>
&
On Sun, 24 Dec 2023 at 01:14, Andrey M. Borodin wrote:
>> On 22 Dec 2023, at 10:39, Japin Li wrote:
>>
>>
>> I try to split the test for transaction timeout, and all passed on my CI [1].
>
>
> I like the refactoring you did in timeout.spec. I thought it is im
d to modify the type of `n`, right?
>
> You are right. n represents the return value of pg_snprintf, which is
> the byte length of the formatted data, which is int, not int64.
>
Thanks for you confirmation! Please consider the v2 patch to review.
--
Regrads,
Japin Li
ChengDu WenWu I
owing line can fix this.
+ int64 k;
Do not need to modify the type of `n`, right?
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
a
On Sat, 23 Dec 2023 at 10:40, Japin Li wrote:
> On Sat, 23 Dec 2023 at 08:32, Japin Li wrote:
>> On Fri, 22 Dec 2023 at 23:30, Junwang Zhao wrote:
>>> On Fri, Dec 22, 2023 at 10:44 PM Japin Li wrote:
>>>>
>>>>
>>>> On Fri, 22 Dec 202
On Sat, 23 Dec 2023 at 08:32, Japin Li wrote:
> On Fri, 22 Dec 2023 at 23:30, Junwang Zhao wrote:
>> On Fri, Dec 22, 2023 at 10:44 PM Japin Li wrote:
>>>
>>>
>>> On Fri, 22 Dec 2023 at 22:37, Junwang Zhao wrote:
>>> > On Fri, Dec 22, 2023
On Fri, 22 Dec 2023 at 23:30, Junwang Zhao wrote:
> On Fri, Dec 22, 2023 at 10:44 PM Japin Li wrote:
>>
>>
>> On Fri, 22 Dec 2023 at 22:37, Junwang Zhao wrote:
>> > On Fri, Dec 22, 2023 at 10:25 PM Japin Li wrote:
>> >> I try to set idle_in_transacti
ent/plpgsql-development-tips.html and
> new section - deployment or packaging to extensions
>
> I agree so https://www.postgresql.org/docs/current/plpgsql-overview.html is
> under dimensioned, but packaging should not be there
>
It seems redundant if we add this for each PL, maybe a separate section to
describe how to package PL into extensions is better.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
On Fri, 22 Dec 2023 at 22:37, Junwang Zhao wrote:
> On Fri, Dec 22, 2023 at 10:25 PM Japin Li wrote:
>> I try to set idle_in_transaction_session_timeout after begin transaction,
>> it changes immediately, so I think transaction_timeout should also be take
>> immed
On Fri, 22 Dec 2023 at 20:29, Junwang Zhao wrote:
> On Fri, Dec 22, 2023 at 1:39 PM Japin Li wrote:
>>
>>
>> On Tue, 19 Dec 2023 at 22:06, Japin Li wrote:
>> > On Tue, 19 Dec 2023 at 18:27, Andrey M. Borodin
>> > wrote:
>> >>&
On Tue, 19 Dec 2023 at 22:06, Japin Li wrote:
> On Tue, 19 Dec 2023 at 18:27, Andrey M. Borodin wrote:
>>> On 19 Dec 2023, at 13:26, Andrey M. Borodin wrote:
>>>
>>> I don’t have Windows machine, so I hope CF bot will pick this.
>>
>> I used Github
the general documentation to explain
> the rationale without repeating it in the individual script. What do you
> think?
Agreed.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
ession_timeout = '1ms'; SET
statement_timeout = '10s'; SET lock_timeout = '10s'; SET transaction_timeout =
'10s';
[1]
https://api.cirrus-ci.com/v1/artifact/task/4707530400595968/testrun/build/testrun/isolation/isolation/regression.diffs
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
t is sourced in psql, rather than via CREATE EXTENSION
\echo Use "CREATE EXTENSION pair" to load this file. \quit
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
On Mon, 18 Dec 2023 at 17:40, Andrey M. Borodin wrote:
>> On 18 Dec 2023, at 14:32, Japin Li wrote:
>>
>>
>> Thanks for updating the patch
>
> Sorry for the noise, but commitfest bot found one more bug in handling
> statement timeout. PFA v11.
>
On Windo
On Mon, 18 Dec 2023 at 13:49, Andrey M. Borodin wrote:
>> On 16 Dec 2023, at 05:58, Japin Li wrote:
>>
>>
>> On Fri, 15 Dec 2023 at 17:51, Andrey M. Borodin wrote:
>>>> On 8 Dec 2023, at 15:29, Japin Li wrote:
>>>>
>>>> Thanks
On Fri, 15 Dec 2023 at 17:51, Andrey M. Borodin wrote:
>> On 8 Dec 2023, at 15:29, Japin Li wrote:
>>
>> Thanks for updating the patch. LGTM.
>
> PFA v9. Changes:
> 1. Added tests for idle_in_transaction_timeout
> 2. Suppress statement_timeout if it’s sh
On Fri, 08 Dec 2023 at 18:08, Andrey M. Borodin wrote:
>> On 8 Dec 2023, at 12:59, Japin Li wrote:
>>
>>
>> On Thu, 07 Dec 2023 at 20:40, Andrey M. Borodin wrote:
>>>> On 7 Dec 2023, at 06:25, Japin Li wrote:
>>>>
>>>> If id
On Thu, 07 Dec 2023 at 20:40, Andrey M. Borodin wrote:
>> On 7 Dec 2023, at 06:25, Japin Li wrote:
>>
>> If idle_in_transaction_timeout is bigger than transaction_timeout,
>> the idle-in-transaction timeout don't needed, right?
> Yes, I thi
omeone
> more experienced in giving names to GUCs than me. Or, perhaps, a native
> speaker?
>
How about transaction_session_timeout? Similar to idle_session_timeout.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
On Fri, 03 Nov 2023 at 10:03, Thomas Munro wrote:
> On Fri, Nov 3, 2023 at 2:22 PM Thomas Munro wrote:
>> On Fri, Nov 3, 2023 at 3:42 AM Japin Li wrote:
>> > I think this might be a bug comes from Illumos pseudo-tty. I can reproduce
>> > this by using pseudo-tty on
On Thu, 02 Nov 2023 at 22:23, Tom Lane wrote:
> Japin Li writes:
>> It seems the 'SEL\t' is converted to 'SEL ' which is "SEL" with 5 spaces.
>
> That would be plausible if readline were disabled, or otherwise
> not functioning.
>
I think this might be a bu
On Thu, 02 Nov 2023 at 13:42, Japin Li wrote:
> On Thu, 02 Nov 2023 at 13:01, Noah Misch wrote:
>> On Wed, Nov 01, 2023 at 03:19:39PM +0800, Japin Li wrote:
>>> I try to run regression test on illumos, the 010_tab_completion will
>>> failed because of timeout.
>
On Thu, 02 Nov 2023 at 13:01, Noah Misch wrote:
> On Wed, Nov 01, 2023 at 03:19:39PM +0800, Japin Li wrote:
>> I try to run regression test on illumos, the 010_tab_completion will
>> failed because of timeout.
>
>> Any suggestions? Thanks in advance!
>
> This test
server to shut down done
server stopped
# No postmaster PID for node "main"
$ uname -a
SunOS db_build 5.11 x i86pc i386 i86pc illumos
$ perl --version
This is perl 5, version 34, subversion 0 (v5.34.0) built for
x86_64-solaris-thread-multi-64
I try to change PG_TEST_TIMEOUT_DEFAULT to 600, it also failed with timeout.
Any suggestions? Thanks in advance!
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
On Wed, 27 Sep 2023 at 13:46, Michael Paquier wrote:
> On Wed, Sep 27, 2023 at 09:15:00AM +0800, Japin Li wrote:
>> On Wed, 27 Sep 2023 at 08:03, Michael Paquier wrote:
>>> I am not sure that many people run this script frequently so that may
>>> not be worth a
On Wed, 27 Sep 2023 at 08:03, Michael Paquier wrote:
> On Tue, Sep 26, 2023 at 10:43:40AM +0800, Japin Li wrote:
>> # Allow running this even without --with-python
>> PYTHON ?= python
>>
>> $(srcdir)/unaccent.rules: generate_unaccent_rules.py
>> ../../src/com
OM
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
On Tue, 26 Sep 2023 at 06:20, Tom Lane wrote:
> Peter Eisentraut writes:
>> On 25.09.23 08:02, Japin Li wrote:
>>> When I try to update the unicode mapping table through *.xml in
>>> src/backend/utils/mb/Unicode/, it doesn't update the *.map files.
&g
On Tue, 26 Sep 2023 at 05:58, Peter Eisentraut wrote:
> On 25.09.23 08:02, Japin Li wrote:
>> When I try to update the unicode mapping table through *.xml in
>> src/backend/utils/mb/Unicode/, it doesn't update the *.map files.
>> I find the make cannot go to this dir
Hi, hackers
When I try to update the unicode mapping table through *.xml in
src/backend/utils/mb/Unicode/, it doesn't update the *.map files.
I find the make cannot go to this directory, what can I do to update
the mapping tables?
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co
On Mon, 25 Sep 2023 at 11:17, Tom Lane wrote:
> Japin Li writes:
>> I find src/backend/utils/mb/Unicode/Makefile has the following comments:
>
>>> # Note that while each script call produces two output files, to be
>>> # parallel-make safe we need to sp
uld not find the explanation in gram.y easily. Would someone point
it out for me? Thanks in advance!
--
Regrads,
Japin Li
uld not find the explanation in gram.y easily. Would someone point
it out for me? Thanks in advance!
--
Regrads,
Japin Li
On Tue, 15 Aug 2023 at 08:54, Japin Li wrote:
> On Tue, 15 Aug 2023 at 08:49, Andy Fan wrote:
>>>
>>>
>>>
>>> DROP SCHEMA test_schema;
>>> +ERROR: cannot drop schema test_schema because other objects depend on it
>>> +DETAIL: c
-dtrace \
--with-icu \
--with-llvm \
--with-openssl \
--with-python \
--with-libxml \
--with-libxslt \
--with-lz4 \
--with-pam \
CFLAGS='-O0 -Wmissing-prototypes -Wincompatible-pointer-types' \
>configure.log 2>&1
make -j $(nproc) -s && make install -s
(cd contrib/ && make -j $(nproc) -s && make install -s)
--
Regrads,
Japin Li
uot; already exists
CREATE ROLE regress_test_role2;
CREATE ROLE regress_test_role_super SUPERUSER;
CREATE ROLE regress_test_indirect;
Is it a bug that fixed in REL_15_STABLE? If yes, why not backpatch?
--
Regrads,
Japin Li
On Thu, 13 Jul 2023 at 16:19, Masahiko Sawada wrote:
> On Tue, Jul 11, 2023 at 10:24 AM Japin Li wrote:
>>
>>
>> On Mon, 10 Jul 2023 at 14:23, Masahiko Sawada wrote:
>> > On Mon, Jul 10, 2023 at 2:07 PM Kyotaro Horiguchi
>> > wrote:
>> >>
On Mon, 10 Jul 2023 at 14:23, Masahiko Sawada wrote:
> On Mon, Jul 10, 2023 at 2:07 PM Kyotaro Horiguchi
> wrote:
>>
>> At Mon, 10 Jul 2023 09:04:42 +0800, Japin Li wrote in
>> >
>> > On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote:
>> > >
On Sat, 08 Jul 2023 at 12:48, Michael Paquier wrote:
> On Fri, Jul 07, 2023 at 07:23:47PM +0800, Japin Li wrote:
>> +appendStringInfoString(, "\"stderr\"");
>> +#ifdef HAVE_SYSLOG
>> +appendStringInfoString(, &qu
On Fri, 07 Jul 2023 at 16:21, Masahiko Sawada wrote:
> On Fri, Jul 7, 2023 at 4:53 PM Japin Li wrote:
>>
>>
>> On Fri, 07 Jul 2023 at 14:46, jian he wrote:
>> > On Fri, Jul 7, 2023 at 1:06 PM Japin Li wrote:
>> >>
>> >>
>> >>
On Fri, 07 Jul 2023 at 14:46, jian he wrote:
> On Fri, Jul 7, 2023 at 1:06 PM Japin Li wrote:
>>
>>
>> Hi, hackers
>>
>> When I try to change log_destination using ALTER SYSTEM with the wrong value,
>> it complains of the "Unrecognized key word&quo
Hi, hackers
When I try to change log_destination using ALTER SYSTEM with the wrong value,
it complains of the "Unrecognized key word" without available values. This
patch tries to add a hint message that provides available values for
log_destination. Any thoughts?
--
Regrads
/* make sure we can handle the pin */
+ ResourceOwnerEnlargeBuffers(CurrentResourceOwner);
+
/*
* Try once to flush the dirty buffer.
*/
PinBuffer_Locked(bufHdr);
--
Regrads,
Japin Li.
gt;> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/tools/ci/README;hb=HEAD
I think, zero is not a valid buffer identifier. See src/include/storage/buf.h.
+ bufnum = PG_GETARG_INT32(0);
+ if (bufnum < 0 || bufnum > NBuffers)
+ {
+ ereport(ERROR,
+ (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
+errmsg("buffernum is not valid")));
+
+ }
If we use SELECT pg_buffercache_invalidate(0), it will crash.
--
Regrads,
Japin Li.
On Thu, 29 Jun 2023 at 08:19, Michael Paquier wrote:
> On Wed, Jun 28, 2023 at 09:26:02PM +0800, Japin Li wrote:
>> +1. LGTM.
>
> Nothing much to add, so applied with the initial comment fix.
Thanks!
--
Regrads,
Japin Li.
try = (pgssEntry *) hash_search(pgss_hash, , HASH_REMOVE, NULL);
>>
>> Why not if it improves the overall situation. Could you send a patch
>> with everything you have in mind?
>
>
> Here is the patch. I don't have too much in mind, so the patch just
> removes the blank line and revises the comment a bit.
>
+1. LGTM.
--
Regrads,
Japin Li.
On Wed, 28 Jun 2023 at 11:22, Richard Guo wrote:
> On Wed, Jun 28, 2023 at 10:53 AM Japin Li wrote:
>
>>
>> Hi, hackers
>>
>> There has $subject that introduced by commit 6b4d23feef6. When we reset
>> the entries
>> if all parameters are ava
for commit:
(use "git add ..." to update what will be committed)
(use "git restore ..." to discard changes in working directory)
modified: contrib/pg_stat_statements/pg_stat_statements.c
no changes added to commit (use "git add" and/or "git commit -a")
--
Regrads,
Japin Li.
== 0);
/* Lookup the hash table entry with shared lock. */
LWLockAcquire(pgss->lock, LW_SHARED);
However, we need memset() only when pgssHashKey has padding, right?
--
Regrads,
Japin Li.
diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_stateme
for pointing that out.
>
Thanks for all of your reviews. Agreed with Michael do not touch GUC_UNIT_TIME.
--
Regrads,
Japin Li.
(GUC_UNIT_MEMORY | GUC_UNIT_TIME));
+ flags & GUC_UNIT);
return NULL;
}
}
--
Regrads,
Japin Li.
PSA patch to fix a comment inaccurate.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c
index 6dc117dea8..bcb493b56c 100644
--- a/src/backend/utils/adt/ruleutils.c
+++ b/src/backend/utils/adt
Hi,
Commit 216a784829 change the src/backend/replication/logical/worker.c file mode
from 0644 to 0755, which is unwanted, right?
[1]
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=216a784829c2c5f03ab0c43e009126cbb819e9b2
--
Regrads,
Japin Li.
ChengDu WenWu Information
GET_MAJOR_VERSION(new_cluster.major_version) <= 906 ?
- "pg_clog" : "pg_xact");
+ copy_subdir_files(GetClogDirName(old_cluster),
GetClogDirName(new_cluster));
prep_status("Setting oldest XID for new cluster"
On Fri, 16 Dec 2022 at 12:25, Thomas Munro wrote:
> On Fri, Dec 16, 2022 at 4:44 PM Japin Li wrote:
>> Recently, I compile PostgreSQL on FreeBSD, I find commit a2a8acd152
>> introduecs
>> __freebsd__ macro, however, I cannot find this macro on FreeBSD 13. There
>&
-RELEASE-p3 GENERIC amd64
root@freebsd:~ # echo | gcc10 -dM -E - | grep -i 'freebsd'
#define __FreeBSD__ 13
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Thu, 17 Nov 2022 at 23:06, Japin Li wrote:
> On Thu, 17 Nov 2022 at 20:12, Ted Yu wrote:
>> Hi,
>> I was looking at commit aca992040951c7665f1701cd25d48808eda7a809
>>
>> I think the check of msg after the switch statement is not necessary. The
>&g
" does not exist
for access method \"%s\", skipping");
name = NameListToString(opfname);
args = strVal(linitial(castNode(List, object)));
}
}
break;
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Thu, 17 Nov 2022 at 16:22, Daniel Gustafsson wrote:
>> On 17 Nov 2022, at 08:06, Japin Li wrote:
>
>> I find some typo about xl_running_xacts in comments.
>> Attached a patch to fix those.
>
> Thanks, applied!
>
>> - * might look that we could use
Hi, hackers
I find some typo about xl_running_xacts in comments.
Attached a patch to fix those.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c
index 5006a5c464
On Wed, 16 Nov 2022 at 12:19, Tom Lane wrote:
> Japin Li writes:
>> Hi, hackers,
>
> ITYM pgsql-hackers, this is off-topic here.
>
Sorry for typo the email address.
>> When I'm reviewing patch [1], I find there is a memory leak in
>> adjust_data_dir(), the
On Wed, 16 Nov 2022 at 11:15, Ted Yu wrote:
> On Tue, Nov 15, 2022 at 7:12 PM Japin Li wrote:
>> After some rethinking, I find the origin code do not have problems.
>>
>> If fd is NULL or fgets() returns NULL, the process exits. Otherwise, we
>> call
>> pclo
On Wed, 16 Nov 2022 at 10:52, Ted Yu wrote:
> On Tue, Nov 15, 2022 at 6:35 PM Japin Li wrote:
>>
>> fd = popen(cmd, "r");
>> - if (fd == NULL || fgets(filename, sizeof(filename), fd) == NULL ||
>> pclose(fd) != 0)
>> + if (fd == N
using command \"%s\"\n"), progname, cmd);
exit(1);
}
Here, segfault maybe occurs if fd is NULL. I think we can remove pclose()
safely since the process will exit.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Wed, 16 Nov 2022 at 10:02, Japin Li wrote:
> I think we should check whether fd is NULL or not, otherwise, segmentation
> fault maybe occur.
>
> + if (pclose(fd) != 0)
> + {
> + write_stderr(_("%s: could not close the file following command
>
ing ?
>
> Please see attached patch for my proposal.
>
> Cheers
I think we should check whether fd is NULL or not, otherwise, segmentation
fault maybe occur.
+ if (pclose(fd) != 0)
+ {
+ write_stderr(_("%s: could not close the file following command
\"%s\&quo
1 - 100 of 310 matches
Mail list logo
