Re: Allow COPY's 'text' format to output a header

a merge conflict against master, then it'd be good for an > updated patch to be posted. > > Thanks! > > Stephen > Attached is an updated patch that should directly apply against current master. -- Simon Muller text_header_v6.patch Description: Binary data

Re: Allow COPY's 'text' format to output a header

t; Best, > -Cynthia Sure, thanks both for the feedback. Attached is a patch with the error kept as ERRCODE_FEATURE_NOT_SUPPORTED. -- Simon Muller text_header_v5.patch Description: Binary data

Re: Allow COPY's 'text' format to output a header

patible options was because the feature was not yet implemented, but now ERRCODE_SYNTAX_ERROR seems to make sense to me since I can't foresee a use case where BINARY and HEADER would ever be compatible options. -- Simon Muller

Re: Allow COPY's 'text' format to output a header

dded later since it would affect > the general functionality of the copy command, not just the ability to have > a text header. > > Best, > - Cynthia Shang > P.S. I did receive the first attached patch, but on my Ubuntu I had to apply it using "git apply --ignore-space-change --ignore-whitespace", probably due to line ending differences. -- Simon Muller text_header_v4.patch Description: Binary data

Re: Allow COPY's 'text' format to output a header

On 4 July 2018 at 22:44, Simon Muller wrote: > I noticed through the patch tester link at http://commitfest.cputube.org/ > that my patch caused a file_fdw test to fail (since I previously tested > only with "make check" and not with "make check-world").

Re: Allow COPY's 'text' format to output a header

On 14 May 2018 at 08:35, Simon Muller wrote: > Okay, I've added this to the next commitfest at > https://commitfest.postgresql.org/18/1629/. > > Thanks both Michael and David for the feedback so far. > I noticed through the patch tester link at http://commitfest.cputube.org

Re: Allow COPY's 'text' format to output a header

Okay, I've added this to the next commitfest at https://commitfest.postgresql.org/18/1629/. Thanks both Michael and David for the feedback so far. On 14 May 2018 at 02:37, Michael Paquier wrote: > On Sun, May 13, 2018 at 07:01:00PM -0400, David Steele wrote: > > This

Allow COPY's 'text' format to output a header

rectly and the patch is acceptable enough to be considered for application. Simon Muller 0001-Allow-COPY-s-text-format-to-output-a-header.patch Description: Binary data