Re: Overhauling "Routine Vacuuming" docs, particularly its handling of freezing

2023-05-04 Thread samay sharma
Hi, On Wed, May 3, 2023 at 3:48 PM Peter Geoghegan wrote: > On Wed, May 3, 2023 at 2:59 PM Peter Geoghegan wrote: > > Coming up with a new user-facing name for xidStopLimit is already on > > my TODO list (it's surprisingly hard). I have used that name so far > > because it unambiguously refers

Re: Overhauling "Routine Vacuuming" docs, particularly its handling of freezing

2023-05-04 Thread samay sharma
Hi, On Wed, May 3, 2023 at 2:59 PM Peter Geoghegan wrote: > Hi Samay, > > On Tue, May 2, 2023 at 11:40 PM samay sharma > wrote: > > Thanks for taking the time to do this. It is indeed difficult work. > > Thanks for the review! I think that this is something that would &

Re: Overhauling "Routine Vacuuming" docs, particularly its handling of freezing

2023-05-03 Thread samay sharma
Hi, On Mon, Apr 24, 2023 at 2:58 PM Peter Geoghegan wrote: > My work on page-level freezing for PostgreSQL 16 has some remaining > loose ends to tie up with the documentation. The "Routine Vacuuming" > section of the docs has no mention of page-level freezing. It also > doesn't mention the FPI

Re: Documentation for building with meson

2023-04-11 Thread samay sharma
Hi, On Tue, Apr 11, 2023 at 10:18 AM Andres Freund wrote: > Hi, > > On 2023-03-28 12:27:26 -0700, samay sharma wrote: > > Subject: [PATCH v9 1/5] Make minor additions and corrections to meson > docs > > > > This commit makes a few corrections to the meson docs &

Re: Documentation for building with meson

2023-03-28 Thread samay sharma
Hi, On Wed, Mar 15, 2023 at 4:28 AM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > > [PATCH v8 1/5] Make minor additions and corrections to meson docs > > The last hunk revealed that there is some mixing up between meson setup > and meson configure. This goes a bit further.

Re: Documentation for building with meson

2023-02-24 Thread samay sharma
Hi, On Thu, Dec 1, 2022 at 9:21 AM Andres Freund wrote: > Hi, > > On 2022-12-01 15:58:39 +0100, Peter Eisentraut wrote: > > On 23.11.22 22:24, samay sharma wrote: > > > Thank you. Attaching v7 addressing most of the points below. > > > > I have committed this

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-09 Thread samay sharma
Hi, On Wed, Dec 7, 2022 at 9:20 PM Peter Smith wrote: > On Thu, Dec 8, 2022 at 10:49 AM samay sharma > wrote: > > > ... > > > Thanks for the changes. See a few points of feedback below. > > > > Patch v7 addresses this feedback. PSA. > > >

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-07 Thread samay sharma
Hi, On Tue, Dec 6, 2022 at 11:12 PM Peter Smith wrote: > On Tue, Dec 6, 2022 at 5:57 AM samay sharma > wrote: > > > > Hi, > > > > On Mon, Oct 24, 2022 at 12:45 AM Peter Smith > wrote: > >> > >> Hi hackers. > >> > >

Re: PGDOCS - Logical replication GUCs - added some xrefs

2022-12-05 Thread samay sharma
Hi, On Mon, Oct 24, 2022 at 12:45 AM Peter Smith wrote: > Hi hackers. > > There is a docs Logical Replication section "31.10 Configuration > Settings" [1] which describes some logical replication GUCs, and > details on how they interact with each other and how to take that into > account when

Re: Documentation for building with meson

2022-11-23 Thread samay sharma
Hi, On Wed, Nov 23, 2022 at 12:16 PM Justin Pryzby wrote: > On Wed, Nov 23, 2022 at 11:30:54AM -0800, samay sharma wrote: > > Thanks for the feedback. Addressed all and added markup at a few more > > places in v6 (attached). > > Thanks. It looks good to me. A couple th

Re: Documentation for building with meson

2022-11-23 Thread samay sharma
Hi, On Tue, Nov 22, 2022 at 10:36 PM Justin Pryzby wrote: > On Mon, Nov 14, 2022 at 10:41:21AM -0800, samay sharma wrote: > > > You need LZ4, if you want to support compression of data with that > > method; see default_toast_compression and wal_compression. > > => The

Re: Documentation for building with meson

2022-11-14 Thread samay sharma
Hi, On Thu, Nov 10, 2022 at 4:46 AM Nazir Bilal Yavuz wrote: > Hi, > > I did some tests on windows. I used 'ninja' as a backend. > On 11/8/2022 9:23 PM, samay sharma wrote: > > Hi, > > On Sat, Nov 5, 2022 at 2:39 PM Andres Freund wrote: > >> Hi, >> >&g

Re: Documentation for building with meson

2022-10-30 Thread samay sharma
Hi, On Thu, Oct 27, 2022 at 1:04 AM John Naylor wrote: > +# Run the main pg_regress and isolation tests > +meson test --suite main > > This does not work for me in a fresh install until running > > meson test --suite setup > > In fact, we see in > > https://wiki.postgresql.org/wiki/Meson > >

Re: Documentation for building with meson

2022-10-26 Thread samay sharma
Hi, On Wed, Oct 19, 2022 at 7:43 PM Justin Pryzby wrote: > On Wed, Oct 19, 2022 at 11:35:10AM -0700, samay sharma wrote: > > Creating a new thread focussed on adding docs for building Postgres with > > meson. This is a spinoff from the original thread [1] and I've attempted >

Documentation for building with meson

2022-10-19 Thread samay sharma
Hi, Creating a new thread focussed on adding docs for building Postgres with meson. This is a spinoff from the original thread [1] and I've attempted to address all the feedback provided there in the attached patch. Please let me know your thoughts. [1]

Re: [RFC] building postgres with meson - v13

2022-10-03 Thread samay sharma
Hi, On Mon, Sep 26, 2022 at 6:02 AM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > On 24.09.22 20:09, Andres Freund wrote: > > On 2022-09-24 13:52:29 -0400, Tom Lane wrote: > >> ... btw, shouldn't the CF entry [1] get closed now? > > > > Unfortunately not - there's quite a few

Re: [RFC] building postgres with meson - v11

2022-09-08 Thread samay sharma
On Tue, Sep 6, 2022 at 9:46 PM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > On 02.09.22 01:12, samay sharma wrote: > > So, I was thinking of the following structure: > > - Supported Platforms > > - Getting the Source > > - Building with make and

Re: [RFC] building postgres with meson - v11

2022-09-08 Thread samay sharma
Hi, On Tue, Sep 6, 2022 at 9:48 PM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > On 02.09.22 19:16, samay sharma wrote: > > Another thing I'd like input on. A common question I've heard from > > people who've tried out the docs is How do we do the equiva

Re: [RFC] building postgres with meson - v11

2022-09-02 Thread samay sharma
On Thu, Sep 1, 2022 at 4:12 PM samay sharma wrote: > Hi, > > On Wed, Aug 31, 2022 at 1:42 AM Peter Eisentraut < > peter.eisentr...@enterprisedb.com> wrote: > >> On 24.08.22 17:30, Andres Freund wrote: >> >> 0545eec895 meson: Add docs >> >&

Re: [RFC] building postgres with meson - v11

2022-09-01 Thread samay sharma
Hi, On Wed, Aug 31, 2022 at 1:42 AM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > On 24.08.22 17:30, Andres Freund wrote: > >> 0545eec895 meson: Add docs > >> > >> We should think more about how to arrange the documentation. We > >> probably don't want to copy-and-paste all the

Re: [RFC] building postgres with meson - v11

2022-08-24 Thread samay sharma
Hi, On Wed, Aug 24, 2022 at 8:30 AM Andres Freund wrote: > Hi, > > On 2022-08-24 11:39:06 +0200, Peter Eisentraut wrote: > > I have looked at your branch at 0545eec895: > > > > 258f6dc0a7 Don't hardcode tmp_check/ as test directory for tap tests > > 8ecc33cf04 Split TESTDIR into TESTLOGDIR and

Re: Proposal: Support custom authentication methods using hooks

2022-08-02 Thread samay sharma
Hi Jacob, On Tue, Aug 2, 2022 at 2:48 PM Jacob Champion wrote: > [CFM hat] Okay, either way you look at it, this patchset needs author > work before any further review can be done. Peter has given some > additional feedback on next steps, Stephen has asked for clarification > on the goals of

Re: [PoC] Federated Authn/z with OAUTHBEARER

2022-03-22 Thread samay sharma
Hi Jacob, Thank you for porting this on top of the pluggable auth methods API. I've addressed the feedback around other backend changes in my latest patch, but the client side changes still remain. I had a few questions to understand them better. (a) What specifically do the client side changes

Re: Proposal: Support custom authentication methods using hooks

2022-03-16 Thread samay sharma
Hi, On Wed, Mar 16, 2022 at 8:02 AM Stephen Frost wrote: > Greetings, > > * samay sharma (smilingsa...@gmail.com) wrote: > > On Fri, Mar 4, 2022 at 11:15 AM Jacob Champion > wrote: > > > On Thu, 2022-03-03 at 11:12 +0100, Peter Eisentraut wrote: > > >

Re: Proposal: Support custom authentication methods using hooks

2022-03-15 Thread samay sharma
Hi, On Fri, Mar 4, 2022 at 11:15 AM Jacob Champion wrote: > On Thu, 2022-03-03 at 11:12 +0100, Peter Eisentraut wrote: > > At the moment, it is not possible to judge whether the hook interface > > you have chosen is appropriate. > > > > I suggest you actually implement the Azure provider, then

Re: Proposal: Support custom authentication methods using hooks

2022-03-02 Thread samay sharma
Hi, On Wed, Mar 2, 2022 at 12:32 AM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > On 01.03.22 22:34, Andres Freund wrote: > > The cases I've heard about are about centralizing auth across multiple > cloud > > services. Including secret management in some form. E.g. allowing an >

Re: Proposal: Support custom authentication methods using hooks

2022-02-24 Thread samay sharma
Hi Aleksander, On Thu, Feb 24, 2022 at 1:17 AM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi Samay, > > > I wanted to submit a patch to expose 2 new hooks (one for the > authentication check and another one for error reporting) in auth.c. These > will allow users to implement their

Re: Proposal: Support custom authentication methods using hooks

2022-02-23 Thread samay sharma
Hi all, On Thu, Feb 17, 2022 at 11:25 AM samay sharma wrote: > Hi all, > > I wanted to submit a patch to expose 2 new hooks (one for the > authentication check and another one for error reporting) in auth.c. These > will allow users to implement their own authentication metho

Proposal: Support custom authentication methods using hooks

2022-02-17 Thread samay sharma
Hi all, I wanted to submit a patch to expose 2 new hooks (one for the authentication check and another one for error reporting) in auth.c. These will allow users to implement their own authentication methods for Postgres or add custom logic around authentication. A use case where this is useful

Re: Error running configure on Mac

2022-01-23 Thread samay sharma
On Sun, Jan 23, 2022 at 11:14 PM Tom Lane wrote: > samay sharma writes: > > I was trying to build Postgres from source on my Mac (MacOS Monterey > 12.1) > > and ran into an error when running configure. > > Works for me, and for other developers, and for asso

Error running configure on Mac

2022-01-23 Thread samay sharma
Hi, I was trying to build Postgres from source on my Mac (MacOS Monterey 12.1) and ran into an error when running configure. ./configure ... checking for gcc option to accept ISO C99... unsupported configure: error: C compiler "gcc" does not support C99 When I do gcc --version I see:

Re: New developer papercut - Makefile references INSTALL

2022-01-20 Thread samay sharma
On Wed, Jan 19, 2022 at 4:58 PM Tim McNamara wrote: > Hello, > > I encountered a minor road bump when checking out the pg source today. The > Makefile's all target includes the following help message if GNUmakefile > isn't available: > > echo "You need to run the 'configure' program first. See