Re: Add PGDLLIMPORT to enable_hashagg

On 2018-02-21 11:41:31 -0800, Brian Cloutier wrote: > On Wed, Feb 21, 2018 at 10:14 AM, Andres Freund wrote: > > > Could you take the relevant commit, backport it to the > > relevant branches, resolve conflicts, make possibly appropriate > > adaptions, and post? > > > > The

Re: Add PGDLLIMPORT to enable_hashagg

On Wed, Feb 21, 2018 at 10:14 AM, Andres Freund wrote: > Could you take the relevant commit, backport it to the > relevant branches, resolve conflicts, make possibly appropriate > adaptions, and post? > The original commit touched some new variables and therefore didn't

Re: Add PGDLLIMPORT to enable_hashagg

On Fri, Feb 9, 2018 at 1:01 PM, Robert Haas wrote: > > Committed. Thanks for committing this! We forgot to ask though, could you please backport this patch to 10 and maybe even 9.6? As-is I don't think these variables will be available until PG 11.

Re: Add PGDLLIMPORT to enable_hashagg

On Wed, Feb 7, 2018 at 6:32 AM, Metin Doslu wrote: > i. The list of Pascal (max_worker_processes was already with > PGDLLIMPORT, so I also added to max_parallel_workers) > ii. Some others in cost.h to make the file more readable. Committed. -- Robert Haas EnterpriseDB:

Re: Add PGDLLIMPORT to enable_hashagg

Thank you Metin ! Regards PAscal -- Sent from: http://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html

Re: Add PGDLLIMPORT to enable_hashagg

Hey all, I'm attaching the updated patch, it includes i. The list of Pascal (max_worker_processes was already with PGDLLIMPORT, so I also added to max_parallel_workers) ii. Some others in cost.h to make the file more readable. Best, Metin On Tue, Feb 6, 2018 at 10:40 PM, Peter Geoghegan

Re: Add PGDLLIMPORT to enable_hashagg

On Tue, Feb 6, 2018 at 12:39 PM, Robert Haas wrote: > Yeah, let's get them all into one list and I'll commit the whole thing > together. +1 -- Peter Geoghegan

Re: Add PGDLLIMPORT to enable_hashagg

On Tue, Feb 6, 2018 at 3:34 PM, legrand legrand wrote: > Hello, > I know an other extension that would need the same for: > > src/include/optimizer/paths.h > geqo_threshold > enable_geqo > min_parallel_index_scan_size > min_parallel_table_scan_size > >

Re: Add PGDLLIMPORT to enable_hashagg

Hello, I know an other extension that would need the same for: src/include/optimizer/paths.h geqo_threshold enable_geqo min_parallel_index_scan_size min_parallel_table_scan_size src/include/optimizer/cost.h max_parallel_workers_per_gather enable_hashjoin enable_mergejoin enable_nestloop

Re: Add PGDLLIMPORT to enable_hashagg

On Mon, Feb 5, 2018 at 6:17 AM, Metin Doslu wrote: > There was already a discussion and commit for adding PGDLLIMPORT to some > variables which enables extensions to use them on Windows builds. For > reference, the previous thread:"Add PGDLLIMPORT lines to some variables". >