Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-05-14 Thread Kyotaro HORIGUCHI
Thank you for adding the detailed comment and commiting. At Sat, 5 May 2018 01:49:31 +0300, Heikki Linnakangas wrote in <47215279-228d-f30d-35d1-16af695e5...@iki.fi> > On 04/05/18 10:05, Heikki Linnakangas wrote: > > On 24/04/18 13:57, Kyotaro HORIGUCHI wrote: > >> At Mon, 23 Apr 2018 03:41:47 -

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-05-04 Thread Heikki Linnakangas
On 04/05/18 10:05, Heikki Linnakangas wrote: On 24/04/18 13:57, Kyotaro HORIGUCHI wrote: At Mon, 23 Apr 2018 03:41:47 -0400, Heikki Linnakangas wrote in <89e33d4f-5c75-0738-3dcb-44c4df59e...@iki.fi> Looking at the patch linked above (https://www.postgresql.org/message-id/20171026.190551.20899

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-05-04 Thread Heikki Linnakangas
On 24/04/18 13:57, Kyotaro HORIGUCHI wrote: At Mon, 23 Apr 2018 03:41:47 -0400, Heikki Linnakangas wrote in <89e33d4f-5c75-0738-3dcb-44c4df59e...@iki.fi> Looking at the patch linked above (https://www.postgresql.org/message-id/20171026.190551.208996945.horiguchi.kyotaro%40lab.ntt.co.jp): ---

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-04-24 Thread Kyotaro HORIGUCHI
Thank you very much for looking this! At Mon, 23 Apr 2018 03:41:47 -0400, Heikki Linnakangas wrote in <89e33d4f-5c75-0738-3dcb-44c4df59e...@iki.fi> > On 18/01/18 20:54, Kyotaro HORIGUCHI wrote: > > At Thu, 18 Jan 2018 11:52:52 -0800, Andres Freund > > wrote in <20180118195252.hyxgkb3krcqjz...@a

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-04-23 Thread Heikki Linnakangas
On 18/01/18 20:54, Kyotaro HORIGUCHI wrote: At Thu, 18 Jan 2018 11:52:52 -0800, Andres Freund wrote in <20180118195252.hyxgkb3krcqjz...@alap3.anarazel.de> On 2018-01-18 20:58:27 +0900, Michael Paquier wrote: b) The second patch that I would like to mention is doing things on the standby side

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-04-08 Thread Kyotaro HORIGUCHI
At Mon, 9 Apr 2018 13:59:45 +0900, Michael Paquier wrote in <20180409045945.gb1...@paquier.xyz> > On Mon, Apr 09, 2018 at 01:26:54PM +0900, Kyotaro HORIGUCHI wrote: > > Hello, I added this as Older Bugs in Open items. (I believe it's > > legit.) > > Yes, I think that's adapted. I am hesitating

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-04-08 Thread Michael Paquier
On Mon, Apr 09, 2018 at 01:26:54PM +0900, Kyotaro HORIGUCHI wrote: > Hello, I added this as Older Bugs in Open items. (I believe it's > legit.) Yes, I think that's adapted. I am hesitating to do the same thing with all the other patches marked as bug fixes. -- Michael signature.asc Description:

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-04-08 Thread Kyotaro HORIGUCHI
Hello, I added this as Older Bugs in Open items. (I believe it's legit.) The latest patch still applies on the HEAD with some offsets. At Tue, 23 Jan 2018 18:50:00 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20180123.185000.232069302.horiguchi.kyot...@lab.ntt.co.jp> > At Fri, 19 J

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-01-23 Thread Kyotaro HORIGUCHI
At Fri, 19 Jan 2018 18:24:56 +0900, Michael Paquier wrote in <20180119092456.ga1...@paquier.xyz> > On Fri, Jan 19, 2018 at 10:54:53AM +0900, Kyotaro HORIGUCHI wrote: > > On the other hand if one logical record must be read from single > > source, we need any means to deterrent wal-recycling on th

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-01-19 Thread Michael Paquier
On Fri, Jan 19, 2018 at 10:54:53AM +0900, Kyotaro HORIGUCHI wrote: > On the other hand if one logical record must be read from single > source, we need any means to deterrent wal-recycling on the > primary side. Conducting that within the primary side is rejected > by consensus. There is this appr

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-01-18 Thread Kyotaro HORIGUCHI
Hello, Thank you for the complrehensive explanation, Michael. I happened to see another instance of this failure on one of our client site. The precise steps lead to the situation is not available but it is reported that it had occurred without immediate shutdown. As far as I know just starting t

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-01-18 Thread Andres Freund
Hi, On 2018-01-18 20:58:27 +0900, Michael Paquier wrote: > On Wed, Jan 17, 2018 at 07:38:32AM -0500, Stephen Frost wrote: > > Thanks for looking at this patch previously. This patch is still in > > Needs Review but it's not clear if that's correct or not, but this seems > > to be a bug-fix, so it

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-01-18 Thread Michael Paquier
On Wed, Jan 17, 2018 at 07:38:32AM -0500, Stephen Frost wrote: > Thanks for looking at this patch previously. This patch is still in > Needs Review but it's not clear if that's correct or not, but this seems > to be a bug-fix, so it would be great if we could make some progress on > it (particular

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-01-17 Thread Stephen Frost
Michael, Andres, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Fri, Oct 27, 2017 at 3:13 AM, Michael Paquier > wrote: > > On Thu, Oct 26, 2017 at 3:05 AM, Kyotaro HORIGUCHI > > wrote: > >> The largest obstacle to do that is that walreceiver is not > >> utterly concerned to record int

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-11-28 Thread Michael Paquier
On Fri, Oct 27, 2017 at 3:13 AM, Michael Paquier wrote: > On Thu, Oct 26, 2017 at 3:05 AM, Kyotaro HORIGUCHI > wrote: >> The largest obstacle to do that is that walreceiver is not >> utterly concerned to record internals. In other words, it doesn't >> know what a record is. Teaching that introduc