Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Wed, Jun 6, 2018 at 9:21 AM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > On Wed, Jun 6, 2018 at 8:11 AM, Thomas Munro > wrote: > > On Mon, Mar 5, 2018 at 8:13 PM, Rajkumar Raghuwanshi > > wrote: > >> On Wed, Feb 7, 2018 at 2:00 PM, Ashutosh Bapat > >> Changed partition-wise

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Wed, Jun 6, 2018 at 8:11 AM, Thomas Munro wrote: > On Mon, Mar 5, 2018 at 8:13 PM, Rajkumar Raghuwanshi > wrote: >> On Wed, Feb 7, 2018 at 2:00 PM, Ashutosh Bapat >> Changed partition-wise statement to partitionwise. >> Attached re-based patch. >> >>> The patch looks good to me. I don't think

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Mon, Mar 5, 2018 at 8:13 PM, Rajkumar Raghuwanshi wrote: > On Wed, Feb 7, 2018 at 2:00 PM, Ashutosh Bapat > Changed partition-wise statement to partitionwise. > Attached re-based patch. > >> The patch looks good to me. I don't think we can reduce it further. >> But we need some tests to test

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Wed, Feb 7, 2018 at 2:00 PM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > On Fri, Dec 22, 2017 at 3:00 PM, Rajkumar Raghuwanshi > wrote: > > updated test patch attached. > Changed partition-wise statement to partitionwise. Attached re-based

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Fri, Dec 22, 2017 at 3:00 PM, Rajkumar Raghuwanshi wrote: > On Wed, Dec 20, 2017 at 5:21 PM, Ashutosh Bapat > wrote: >> >> Thanks. Here are some comments >> > Thanks Ashutosh for review and suggestions. > >> >> +-- test

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Wed, Dec 20, 2017 at 5:21 PM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > Thanks. Here are some comments > > Thanks Ashutosh for review and suggestions. > +-- test default partition behavior for range > +ALTER TABLE prt1 DETACH PARTITION prt1_p3; > +ALTER TABLE prt1 ATTACH

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Tue, Dec 5, 2017 at 1:24 PM, Rajkumar Raghuwanshi wrote: > On Tue, Dec 5, 2017 at 11:04 AM, Rajkumar Raghuwanshi > wrote: >> On Mon, Dec 4, 2017 at 7:34 AM, Ashutosh Bapat >> wrote:

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Tue, Dec 5, 2017 at 11:04 AM, Rajkumar Raghuwanshi wrote: > On Mon, Dec 4, 2017 at 7:34 AM, Ashutosh Bapat > wrote: >> I agree, the patch looks longer than expected. I think, it's important >> to have some testcases to

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Mon, Dec 4, 2017 at 7:34 AM, Ashutosh Bapat wrote: > I agree, the patch looks longer than expected. I think, it's important > to have some testcases to test partition-wise join with default > partitions. I think we need at least one test for range default >

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Sat, Dec 2, 2017 at 2:13 AM, Robert Haas wrote: > On Fri, Dec 1, 2017 at 1:36 AM, Rajkumar Raghuwanshi > wrote: >> On Tue, Oct 31, 2017 at 2:45 PM, Robert Haas wrote: OK, committed. This is a good

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Fri, Dec 1, 2017 at 1:36 AM, Rajkumar Raghuwanshi wrote: > On Tue, Oct 31, 2017 at 2:45 PM, Robert Haas wrote: >>> OK, committed. This is a good example of how having good code >> coverage doesn't necessarily mean you've found all