Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

2018-01-15 Thread Kyotaro HORIGUCHI
Hello, sorry for my late reply. At Wed, 10 Jan 2018 14:56:49 -0500, Tom Lane wrote in <26017.1515614...@sss.pgh.pa.us> > I think that there might be a much simpler solution to this, which > is to just remove make_inh_translation_list's tests of attinhcount, > as per attached. Those are really p

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

2018-01-12 Thread Tom Lane
I wrote: > I think that there might be a much simpler solution to this, which > is to just remove make_inh_translation_list's tests of attinhcount, > as per attached. I went ahead and pushed that, with an isolation test based on the one Horiguchi-san submitted but covering a few related cases.

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

2018-01-10 Thread Tom Lane
Kyotaro HORIGUCHI writes: > [ 0002-Lock-parent-on-ALTER-TABLE-NO-INHERIT.patch ] I don't especially like any of the patches proposed on this thread. The one with rechecking inheritance seems expensive, duplicative, and complicated. The approach of taking a lock on the parent will create deadlock

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

2017-12-12 Thread Kyotaro HORIGUCHI
Hello, At Wed, 29 Nov 2017 14:04:01 +0900, Michael Paquier wrote in > On Tue, Sep 19, 2017 at 3:04 PM, Kyotaro HORIGUCHI > wrote: > >> By the way, I will take a look at your patch when I come back from the > >> vacation. Meanwhile, I noticed that it needs another rebase after > >> 0a480502b09

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

2017-11-28 Thread Michael Paquier
On Tue, Sep 19, 2017 at 3:04 PM, Kyotaro HORIGUCHI wrote: >> By the way, I will take a look at your patch when I come back from the >> vacation. Meanwhile, I noticed that it needs another rebase after >> 0a480502b092 [1]. Moved to CF 2018-01. -- Michael