Re: [PATCH] Add native windows on arm64 support

2024-02-13 Thread Dave Cramer
On Tue, 13 Feb 2024 at 12:52, Andres Freund wrote: > Hi, > > On 2024-02-13 12:49:33 -0500, Dave Cramer wrote: > > > I think I might have been on to something - if my human emulation of a > > > preprocessor isn't wrong, we'd end up with > > > > > > #define S_UNLOCK(lock) \ > > > do {

Re: [PATCH] Add native windows on arm64 support

2024-02-13 Thread Andres Freund
Hi, On 2024-02-13 12:49:33 -0500, Dave Cramer wrote: > > I think I might have been on to something - if my human emulation of a > > preprocessor isn't wrong, we'd end up with > > > > #define S_UNLOCK(lock) \ > > do { _ReadWriteBarrier(); (*(lock)) = 0; } while (0) > > > > on msvc + arm.

Re: [PATCH] Add native windows on arm64 support

2024-02-13 Thread Dave Cramer
Dave Cramer www.postgres.rocks On Mon, 12 Feb 2024 at 16:19, Andres Freund wrote: > Hi, > > On 2024-02-12 12:50:12 -0800, Andres Freund wrote: > > On 2024-02-12 13:28:40 -0500, Andrew Dunstan wrote: > > I wonder if this indicates that we are either missing memory barriers > > somewhere or that

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Thomas Munro
On Sat, Feb 10, 2024 at 8:36 AM Andres Freund wrote: > Also, yikes, that's an ugly way of doing hardware detection. Jumping out of a > signal handler into normal code. Brrr. Maybe it's a little baroque but what's actually wrong with it? OpenSSL does something similar during initialisation as a

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Andres Freund
Hi, On 2024-02-12 12:50:12 -0800, Andres Freund wrote: > On 2024-02-12 13:28:40 -0500, Andrew Dunstan wrote: > I wonder if this indicates that we are either missing memory barriers > somewhere or that the memory barriers we end up with on msvc + arm aren't > correct? Either could explain why the

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Dave Cramer
On Mon, 12 Feb 2024 at 15:50, Andres Freund wrote: > Hi, > > On 2024-02-12 13:28:40 -0500, Andrew Dunstan wrote: > > On 2024-02-12 Mo 11:44, Dave Cramer wrote: > > > OK, so I have managed to get a debugger attached to postgres.exe when > it > > > faults and the fault occurs at > > > >

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Andres Freund
Hi, On 2024-02-09 15:32:10 -0500, Dave Cramer wrote: > On Fri, 9 Feb 2024 at 14:36, Andres Freund wrote: > > That's something like a segfault. > > > > One suspicion I have is that src/port/pg_crc32c_armv8_choose.c possibly > > doesn't properly support msvc. It seems to assume that SIGILL can be

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Andres Freund
Hi, On 2024-02-12 13:28:40 -0500, Andrew Dunstan wrote: > On 2024-02-12 Mo 11:44, Dave Cramer wrote: > > OK, so I have managed to get a debugger attached to postgres.exe when it > > faults and the fault occurs at > >

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Andrew Dunstan
On 2024-02-12 Mo 11:44, Dave Cramer wrote: Dave Cramer www.postgres.rocks On Mon, 12 Feb 2024 at 09:19, Andrew Dunstan wrote: On 2024-02-12 Mo 08:51, Dave Cramer wrote: On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote: On 2024-02-10 Sa 12:20, Dave Cramer wrote:

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Dave Cramer
Dave Cramer www.postgres.rocks On Mon, 12 Feb 2024 at 09:19, Andrew Dunstan wrote: > > On 2024-02-12 Mo 08:51, Dave Cramer wrote: > > > > On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote: > >> >> On 2024-02-10 Sa 12:20, Dave Cramer wrote: >> >> >> >> On Sat, 10 Feb 2024 at 11:19, Andrew

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Andrew Dunstan
On 2024-02-12 Mo 08:51, Dave Cramer wrote: On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote: On 2024-02-10 Sa 12:20, Dave Cramer wrote: On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan wrote: On 2024-02-09 Fr 14:23, Dave Cramer wrote: Dave Cramer

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Dave Cramer
On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote: > > On 2024-02-10 Sa 12:20, Dave Cramer wrote: > > > > On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan wrote: > >> >> On 2024-02-09 Fr 14:23, Dave Cramer wrote: >> >> >> Dave Cramer >> www.postgres.rocks >> >> >> On Fri, 9 Feb 2024 at 07:18, Dave

Re: [PATCH] Add native windows on arm64 support

2024-02-10 Thread Andrew Dunstan
On 2024-02-10 Sa 12:20, Dave Cramer wrote: On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan wrote: On 2024-02-09 Fr 14:23, Dave Cramer wrote: Dave Cramer www.postgres.rocks On Fri, 9 Feb 2024 at 07:18, Dave Cramer

Re: [PATCH] Add native windows on arm64 support

2024-02-10 Thread Dave Cramer
On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan wrote: > > On 2024-02-09 Fr 14:23, Dave Cramer wrote: > > > Dave Cramer > www.postgres.rocks > > > On Fri, 9 Feb 2024 at 07:18, Dave Cramer > wrote: > >> >> >> >> >> On Fri, 9 Feb 2024 at 00:26, Michael Paquier wrote: >> >>> On Tue, Feb 06, 2024 at

Re: [PATCH] Add native windows on arm64 support

2024-02-10 Thread Andrew Dunstan
On 2024-02-09 Fr 14:23, Dave Cramer wrote: Dave Cramer www.postgres.rocks On Fri, 9 Feb 2024 at 07:18, Dave Cramer wrote: On Fri, 9 Feb 2024 at 00:26, Michael Paquier wrote: On Tue, Feb 06, 2024 at 07:01:49AM -0500, Dave Cramer wrote: > Thanks, this patch

Re: [PATCH] Add native windows on arm64 support

2024-02-09 Thread Dave Cramer
On Fri, 9 Feb 2024 at 14:36, Andres Freund wrote: > Hi, > > On 2024-02-09 14:23:46 -0500, Dave Cramer wrote: > > > interestingly meson test does not produce any error > > > The buildfarm produces the following error for me: > > > > > > -SELECT relname, attname, coltypes,

Re: [PATCH] Add native windows on arm64 support

2024-02-09 Thread Andres Freund
Hi, On 2024-02-09 14:23:46 -0500, Dave Cramer wrote: > > interestingly meson test does not produce any error > > The buildfarm produces the following error for me: > > > > -SELECT relname, attname, coltypes, get_columns_length(coltypes) > > - FROM check_columns > > - WHERE

Re: [PATCH] Add native windows on arm64 support

2024-02-09 Thread Dave Cramer
Dave Cramer www.postgres.rocks On Fri, 9 Feb 2024 at 07:18, Dave Cramer wrote: > > > > > On Fri, 9 Feb 2024 at 00:26, Michael Paquier wrote: > >> On Tue, Feb 06, 2024 at 07:01:49AM -0500, Dave Cramer wrote: >> > Thanks, this patch works and >> > testing with meson passes. >> >> Only with the

Re: [PATCH] Add native windows on arm64 support

2024-02-09 Thread Dave Cramer
On Fri, 9 Feb 2024 at 00:26, Michael Paquier wrote: > On Tue, Feb 06, 2024 at 07:01:49AM -0500, Dave Cramer wrote: > > Thanks, this patch works and > > testing with meson passes. > > Only with the version posted at [1]? Interesting, that's the same > contents as v8 posted upthread, minus

Re: [PATCH] Add native windows on arm64 support

2024-02-08 Thread Michael Paquier
On Tue, Feb 06, 2024 at 07:01:49AM -0500, Dave Cramer wrote: > Thanks, this patch works and > testing with meson passes. Only with the version posted at [1]? Interesting, that's the same contents as v8 posted upthread, minus src/tools/ because we don't need to care about them anymore. Andrew,

Re: [PATCH] Add native windows on arm64 support

2024-02-06 Thread Dave Cramer
On Wed, 31 Jan 2024 at 10:21, Andrew Dunstan wrote: > > On 2024-01-30 Tu 17:54, Dave Cramer wrote: > > > > > On Tue, Jan 30, 2024 at 4:56 PM Andrew Dunstan > wrote: > >> >> On 2024-01-30 Tu 09:50, Dave Cramer wrote: >> >> >> >> On Tue, 30 Jan 2024 at 08:38, Andrew Dunstan wrote: >> >>> >>> On

Re: [PATCH] Add native windows on arm64 support

2024-01-31 Thread Andrew Dunstan
On 2024-01-31 We 10:34, Peter Eisentraut wrote: On 31.01.24 16:20, Andrew Dunstan wrote: - PostgreSQL will only build for the x64 architecture on 64-bit Windows. + PostgreSQL will only build for the x64 and ARM64 architecture on 64-bit Windows. Are there any other 64-bit architectures for

Re: [PATCH] Add native windows on arm64 support

2024-01-31 Thread Peter Eisentraut
On 31.01.24 16:20, Andrew Dunstan wrote: - PostgreSQL will only build for the x64 architecture on 64-bit Windows. + PostgreSQL will only build for the x64 and ARM64 architecture on 64-bit Windows. Are there any other 64-bit architectures for Windows? Possibly, the original sentence was meant

Re: [PATCH] Add native windows on arm64 support

2024-01-31 Thread Andrew Dunstan
On 2024-01-30 Tu 17:54, Dave Cramer wrote: On Tue, Jan 30, 2024 at 4:56 PM Andrew Dunstan wrote: On 2024-01-30 Tu 09:50, Dave Cramer wrote: On Tue, 30 Jan 2024 at 08:38, Andrew Dunstan wrote: On 2024-01-29 Mo 11:20, Dave Cramer wrote: Dave Cramer

Re: [PATCH] Add native windows on arm64 support

2024-01-30 Thread Dave Cramer
On Tue, Jan 30, 2024 at 4:56 PM Andrew Dunstan wrote: > > On 2024-01-30 Tu 09:50, Dave Cramer wrote: > > > > On Tue, 30 Jan 2024 at 08:38, Andrew Dunstan wrote: > >> >> On 2024-01-29 Mo 11:20, Dave Cramer wrote: >> >> >> Dave Cramer >> www.postgres.rocks >> >> >> On Mon, 29 Jan 2024 at 11:16,

Re: [PATCH] Add native windows on arm64 support

2024-01-30 Thread Andrew Dunstan
On 2024-01-30 Tu 09:50, Dave Cramer wrote: On Tue, 30 Jan 2024 at 08:38, Andrew Dunstan wrote: On 2024-01-29 Mo 11:20, Dave Cramer wrote: Dave Cramer www.postgres.rocks On Mon, 29 Jan 2024 at 11:16, Andrew Dunstan wrote: On

Re: [PATCH] Add native windows on arm64 support

2024-01-30 Thread Dave Cramer
On Tue, 30 Jan 2024 at 08:38, Andrew Dunstan wrote: > > On 2024-01-29 Mo 11:20, Dave Cramer wrote: > > > Dave Cramer > www.postgres.rocks > > > On Mon, 29 Jan 2024 at 11:16, Andrew Dunstan wrote: > >> >> On 2024-01-26 Fr 09:18, Dave Cramer wrote: >> >> >> >> On Fri, 26 Jan 2024 at 07:36, Andrew

Re: [PATCH] Add native windows on arm64 support

2024-01-30 Thread Andrew Dunstan
On 2024-01-29 Mo 11:20, Dave Cramer wrote: Dave Cramer www.postgres.rocks On Mon, 29 Jan 2024 at 11:16, Andrew Dunstan wrote: On 2024-01-26 Fr 09:18, Dave Cramer wrote: On Fri, 26 Jan 2024 at 07:36, Andrew Dunstan wrote: On 2024-01-25 Th 20:32, Michael Paquier

Re: [PATCH] Add native windows on arm64 support

2024-01-29 Thread Dave Cramer
Dave Cramer www.postgres.rocks On Mon, 29 Jan 2024 at 11:16, Andrew Dunstan wrote: > > On 2024-01-26 Fr 09:18, Dave Cramer wrote: > > > > On Fri, 26 Jan 2024 at 07:36, Andrew Dunstan wrote: > >> >> On 2024-01-25 Th 20:32, Michael Paquier wrote: >> > On Thu, Jan 25, 2024 at 04:52:30PM -0500,

Re: [PATCH] Add native windows on arm64 support

2024-01-29 Thread Andrew Dunstan
On 2024-01-26 Fr 09:18, Dave Cramer wrote: On Fri, 26 Jan 2024 at 07:36, Andrew Dunstan wrote: On 2024-01-25 Th 20:32, Michael Paquier wrote: > On Thu, Jan 25, 2024 at 04:52:30PM -0500, Dave Cramer wrote: >> On Thu, 25 Jan 2024 at 16:32, Andrew Dunstan wrote: >>> On

Re: [PATCH] Add native windows on arm64 support

2024-01-29 Thread Andrew Dunstan
On 2024-01-26 Fr 09:18, Dave Cramer wrote: On Fri, 26 Jan 2024 at 07:36, Andrew Dunstan wrote: On 2024-01-25 Th 20:32, Michael Paquier wrote: > On Thu, Jan 25, 2024 at 04:52:30PM -0500, Dave Cramer wrote: >> On Thu, 25 Jan 2024 at 16:32, Andrew Dunstan wrote: >>> On

Re: [PATCH] Add native windows on arm64 support

2024-01-26 Thread Dave Cramer
On Fri, 26 Jan 2024 at 07:36, Andrew Dunstan wrote: > > On 2024-01-25 Th 20:32, Michael Paquier wrote: > > On Thu, Jan 25, 2024 at 04:52:30PM -0500, Dave Cramer wrote: > >> On Thu, 25 Jan 2024 at 16:32, Andrew Dunstan > wrote: > >>> On 2024-01-25 Th 16:17, Dave Cramer wrote: > >>> Yeah, I think

Re: [PATCH] Add native windows on arm64 support

2024-01-26 Thread Andrew Dunstan
On 2024-01-25 Th 20:32, Michael Paquier wrote: On Thu, Jan 25, 2024 at 04:52:30PM -0500, Dave Cramer wrote: On Thu, 25 Jan 2024 at 16:32, Andrew Dunstan wrote: On 2024-01-25 Th 16:17, Dave Cramer wrote: Yeah, I think the default Developer Command Prompt for VS2022 is set up for x86 builds.

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Michael Paquier
On Thu, Jan 25, 2024 at 04:52:30PM -0500, Dave Cramer wrote: > On Thu, 25 Jan 2024 at 16:32, Andrew Dunstan wrote: >> On 2024-01-25 Th 16:17, Dave Cramer wrote: >> Yeah, I think the default Developer Command Prompt for VS2022 is set up >> for x86 builds. AIUI you should start by executing

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Thu, 25 Jan 2024 at 16:32, Andrew Dunstan wrote: > > On 2024-01-25 Th 16:17, Dave Cramer wrote: > > > > On Thu, 25 Jan 2024 at 16:04, Anthony Roberts > wrote: > >> Hi David, >> >> Unix "file" or "dumpbin /headers" in vcvarsall are your best bets. >> >> Thanks, >> Anthony >> > > > So there is

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Andrew Dunstan
On 2024-01-25 Th 16:17, Dave Cramer wrote: On Thu, 25 Jan 2024 at 16:04, Anthony Roberts wrote: Hi David, Unix "file" or "dumpbin /headers" in vcvarsall are your best bets. Thanks, Anthony So there is another way, select the file in Windows Explorer and right click,

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Thu, 25 Jan 2024 at 16:04, Anthony Roberts wrote: > Hi David, > > Unix "file" or "dumpbin /headers" in vcvarsall are your best bets. > > Thanks, > Anthony > So there is another way, select the file in Windows Explorer and right click, in the compatibility tab if the "Windows on ARM" is

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Andrew Dunstan
On 2024-01-25 Th 15:56, Dave Cramer wrote: On Thu, 25 Jan 2024 at 14:31, Andrew Dunstan wrote: On 2024-01-25 Th 08:45, Dave Cramer wrote: I tried running my buildfarm using my git repo and my branch, but get the following error Status Line: 492 bad branch parameter

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Anthony Roberts
Hi David, Unix "file" or "dumpbin /headers" in vcvarsall are your best bets. Thanks, Anthony On Thu, 25 Jan 2024, 21:01 Dave Cramer, wrote: > > > On Thu, 25 Jan 2024 at 12:30, Andrew Dunstan wrote: > >> >> On 2024-01-24 We 19:02, Michael Paquier wrote: >> >> On Wed, Jan 24, 2024 at

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Thu, 25 Jan 2024 at 12:30, Andrew Dunstan wrote: > > On 2024-01-24 We 19:02, Michael Paquier wrote: > > On Wed, Jan 24, 2024 at 06:45:21AM -0500, Dave Cramer wrote: > > I managed to get it to build the vcvarsall arch needs to be x64. I need to > add some options, but the patch above needs to

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Thu, 25 Jan 2024 at 14:31, Andrew Dunstan wrote: > > On 2024-01-25 Th 08:45, Dave Cramer wrote: > > > > > > I tried running my buildfarm using my git repo and my branch, but get the > following error > Status Line: 492 bad branch parameter > Content: > bad branch parameter fix_arm > > Web txn

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Andrew Dunstan
On 2024-01-25 Th 08:45, Dave Cramer wrote: I tried running my buildfarm using my git repo and my branch, but get the following error Status Line: 492 bad branch parameter Content: bad branch parameter fix_arm Web txn failed with status: 1 You can't use your own branch with the

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Thu, 25 Jan 2024 at 12:30, Andrew Dunstan wrote: > > On 2024-01-24 We 19:02, Michael Paquier wrote: > > On Wed, Jan 24, 2024 at 06:45:21AM -0500, Dave Cramer wrote: > > I managed to get it to build the vcvarsall arch needs to be x64. I need to > add some options, but the patch above needs to

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Andrew Dunstan
On 2024-01-24 We 19:02, Michael Paquier wrote: On Wed, Jan 24, 2024 at 06:45:21AM -0500, Dave Cramer wrote: I managed to get it to build the vcvarsall arch needs to be x64. I need to add some options, but the patch above needs to be applied to build it. Nice. If I may ask, what kind of host

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Thu, 25 Jan 2024 at 08:31, Dave Cramer wrote: > > > On Wed, 24 Jan 2024 at 19:03, Michael Paquier wrote: > >> On Wed, Jan 24, 2024 at 06:45:21AM -0500, Dave Cramer wrote: >> > I managed to get it to build the vcvarsall arch needs to be x64. I need >> to >> > add some options, but the patch

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Dave Cramer
On Wed, 24 Jan 2024 at 19:03, Michael Paquier wrote: > On Wed, Jan 24, 2024 at 06:45:21AM -0500, Dave Cramer wrote: > > I managed to get it to build the vcvarsall arch needs to be x64. I need > to > > add some options, but the patch above needs to be applied to build it. > > Nice. If I may ask,

Re: [PATCH] Add native windows on arm64 support

2024-01-24 Thread Michael Paquier
On Wed, Jan 24, 2024 at 06:45:21AM -0500, Dave Cramer wrote: > I managed to get it to build the vcvarsall arch needs to be x64. I need to > add some options, but the patch above needs to be applied to build it. Nice. If I may ask, what kind of host and/or configuration have you used to reach a

Re: [PATCH] Add native windows on arm64 support

2024-01-24 Thread Dave Cramer
On Tue, 23 Jan 2024 at 18:32, Michael Paquier wrote: > On Tue, Jan 23, 2024 at 04:13:05PM -0500, Dave Cramer wrote: > > On Tue, 23 Jan 2024 at 08:46, Dave Cramer > wrote: > >> The attached patch works with v17. I will work on getting a buildfarm > >> animal up shortly > > Thanks for doing that!

Re: [PATCH] Add native windows on arm64 support

2024-01-23 Thread Michael Paquier
On Tue, Jan 23, 2024 at 04:13:05PM -0500, Dave Cramer wrote: > On Tue, 23 Jan 2024 at 08:46, Dave Cramer wrote: >> The attached patch works with v17. I will work on getting a buildfarm >> animal up shortly Thanks for doing that! > I can build using meson manually, but for some reason building

Re: [PATCH] Add native windows on arm64 support

2024-01-23 Thread Dave Cramer
On Tue, 23 Jan 2024 at 08:46, Dave Cramer wrote: > > > On Tue, 19 Sept 2023 at 23:48, Michael Paquier > wrote: > >> On Tue, Sep 19, 2023 at 01:35:17PM +0100, Anthony Roberts wrote: >> > Was there an explicit request for something there? I was under the >> > impression that this was all just

Re: [PATCH] Add native windows on arm64 support

2024-01-23 Thread Dave Cramer
On Tue, 19 Sept 2023 at 23:48, Michael Paquier wrote: > On Tue, Sep 19, 2023 at 01:35:17PM +0100, Anthony Roberts wrote: > > Was there an explicit request for something there? I was under the > > impression that this was all just suggestion/theory at the moment. > > Yes. The addition of a

Re: [PATCH] Add native windows on arm64 support

2023-09-19 Thread Michael Paquier
On Tue, Sep 19, 2023 at 01:35:17PM +0100, Anthony Roberts wrote: > Was there an explicit request for something there? I was under the > impression that this was all just suggestion/theory at the moment. Yes. The addition of a buildfarm member registered into the community facilities, so as it is

Re: [PATCH] Add native windows on arm64 support

2023-09-19 Thread Anthony Roberts
Hi, This was covered earlier in the thread - I have taken this on in Niyas' stead. Was there an explicit request for something there? I was under the impression that this was all just suggestion/theory at the moment. Thanks, Anthony On 19/09/2023 09:33, Peter Eisentraut wrote: On

Re: [PATCH] Add native windows on arm64 support

2023-09-19 Thread Peter Eisentraut
On 14.09.23 11:39, Daniel Gustafsson wrote: On 13 Sep 2023, at 21:12, Peter Eisentraut wrote: On 31.08.23 06:44, Tom Lane wrote: I agree. I'm really uncomfortable with claiming support for Windows-on-ARM if we don't have a buildfarm member testing it. For other platforms that have a track

Re: [PATCH] Add native windows on arm64 support

2023-09-14 Thread Daniel Gustafsson
> On 13 Sep 2023, at 21:12, Peter Eisentraut wrote: > > On 31.08.23 06:44, Tom Lane wrote: >> I agree. I'm really uncomfortable with claiming support for >> Windows-on-ARM if we don't have a buildfarm member testing it. >> For other platforms that have a track record of multiple >> hardware

Re: [PATCH] Add native windows on arm64 support

2023-09-13 Thread Peter Eisentraut
On 31.08.23 06:44, Tom Lane wrote: I agree. I'm really uncomfortable with claiming support for Windows-on-ARM if we don't have a buildfarm member testing it. For other platforms that have a track record of multiple hardware support, it might not be a stretch ... but Windows was so resolutely

Re: [PATCH] Add native windows on arm64 support

2023-09-13 Thread Andres Freund
Hi, On 2023-08-31 14:33:56 +0900, Michael Paquier wrote: > On Thu, Aug 31, 2023 at 01:06:53AM -0400, Tom Lane wrote: > > That's a good point. The hardware resources to support a buildfarm > > animal are really pretty trivial these days. What is important is > > an animal owner who is willing to

Re: [PATCH] Add native windows on arm64 support

2023-09-13 Thread Peter Eisentraut
On 02.05.23 09:51, Niyas Sait wrote: diff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgml index cbc70a039c..2ecd5fcf38 100644 --- a/doc/src/sgml/install-windows.sgml +++ b/doc/src/sgml/install-windows.sgml @@ -352,7 +352,8 @@ $ENV{MSBFLAGS}="/m"; Special

Re: [PATCH] Add native windows on arm64 support

2023-08-30 Thread Michael Paquier
On Thu, Aug 31, 2023 at 01:06:53AM -0400, Tom Lane wrote: > That's a good point. The hardware resources to support a buildfarm > animal are really pretty trivial these days. What is important is > an animal owner who is willing to help chase down problems when they > arise. Unfortunately I

Re: [PATCH] Add native windows on arm64 support

2023-08-30 Thread Tom Lane
Thomas Munro writes: > But, supposing Azure credits were suddenly available (just between > you, me and the mailing list, I heard that this should be imminent as > some kind of grant to PG US, as a result of the Cirrus thing), do we > have a Windows-savvy volunteer to feed and water an animal? I

Re: [PATCH] Add native windows on arm64 support

2023-08-30 Thread Thomas Munro
On Thu, Aug 31, 2023 at 4:22 PM Michael Paquier wrote: > Honestly, I am not sure how to proceed here. Having something in the > buildfarm is necessary IMO, because this is the central place that > community members look at when it comes to monitoring the stability of > a patch committed. It's

Re: [PATCH] Add native windows on arm64 support

2023-08-30 Thread Tom Lane
Michael Paquier writes: > On Wed, Aug 30, 2023 at 04:12:16PM +0100, Anthony Roberts wrote: >> Just a follow-up: having spoken to the relevant people, sadly, right now, >> we do not have the capacity to be pulling machines out of our day-to-day CI >> tasks to dedicate to specific projects. >

Re: [PATCH] Add native windows on arm64 support

2023-08-30 Thread Michael Paquier
On Wed, Aug 30, 2023 at 04:12:16PM +0100, Anthony Roberts wrote: > Just a follow-up: having spoken to the relevant people, sadly, right now, > we do not have the capacity to be pulling machines out of our day-to-day CI > tasks to dedicate to specific projects. Okay, thanks for letting us know. >

Re: [PATCH] Add native windows on arm64 support

2023-08-30 Thread Anthony Roberts
Hi, Just a follow-up: having spoken to the relevant people, sadly, right now, we do not have the capacity to be pulling machines out of our day-to-day CI tasks to dedicate to specific projects. I can, however, offer a few alternatives: 1. If you have capacity on your linux x64 machines, it is

Re: [PATCH] Add native windows on arm64 support

2023-08-25 Thread Daniel Gustafsson
> On 25 Aug 2023, at 11:40, Anthony Roberts wrote: > * A machine for you to directly access (via a VPN) That could be very helpful to provide to developers who are trying to debug very wicked bugs which requires access for analysis. Such things are on a case by case basis of course at your

Re: [PATCH] Add native windows on arm64 support

2023-08-25 Thread Anthony Roberts
Thanks for the link - that looks basically the same as what we do for CMake (option 2), so should be relatively easy. I will have a chat to relevant people about setting a machine up properly for it. Thanks, Anthony On 25/08/2023 11:17, Michael Paquier wrote: On Fri, Aug 25, 2023 at

Re: [PATCH] Add native windows on arm64 support

2023-08-25 Thread Anthony Roberts
Hi, Which of these are you looking for us to provide: * A machine for you to directly access (via a VPN) * A machine we just run a worker script on that automatically picks up the builds as required * Us to do downstream CI All are possible, but preferably not option 1, as it would mean

Re: [PATCH] Add native windows on arm64 support

2023-08-25 Thread Michael Paquier
On Fri, Aug 25, 2023 at 10:40:39AM +0100, Anthony Roberts wrote: > Which of these are you looking for us to provide: > > * A machine for you to directly access (via a VPN) > * A machine we just run a worker script on that automatically picks up the > builds as required > * Us to do downstream CI

Re: [PATCH] Add native windows on arm64 support

2023-08-17 Thread Michael Paquier
On Thu, Aug 17, 2023 at 09:41:44AM +0100, Anthony Roberts wrote: > Just following up on this, has there been any movement? > > I did see another message go into the thread here with no reply: > https://www.postgresql.org/message-id/ZKPLjLjIjwN2lxkg%40paquier.xyz I don't have an environment to

Re: [PATCH] Add native windows on arm64 support

2023-08-17 Thread Anthony Roberts
Hi All, Just following up on this, has there been any movement? I did see another message go into the thread here with no reply: https://www.postgresql.org/message-id/ZKPLjLjIjwN2lxkg%40paquier.xyz Thanks, Anthony On 14/06/2023 13:25, Niyas Sait wrote: Hello, Just wanted to give a heads

Re: [PATCH] Add native windows on arm64 support

2023-07-04 Thread Michael Paquier
On Thu, May 11, 2023 at 01:19:54PM +0900, Michael Paquier wrote: > On Thu, May 11, 2023 at 12:17:25PM +1200, Thomas Munro wrote: >> Azure does have an image "Microsoft Windows 11 Preview arm64" to run >> on Ampere CPUs, which says it's a pre-release version intended for >> validation, which sounds

Re: [PATCH] Add native windows on arm64 support

2023-06-14 Thread Niyas Sait
Hello, Just wanted to give a heads up that I am moving to a new role outside Linaro and as a result wouldn't be able to continue contributing. Anthony Roberts from Linaro is going to support the enablement work. -- Niyas

Re: [PATCH] Add native windows on arm64 support

2023-05-11 Thread Niyas Sait
On 11/05/2023 00:34, Michael Paquier wrote: On Wed, May 10, 2023 at 09:24:39AM -0400, Andrew Dunstan wrote: We will definitely want buildfarm support. I don't have such a machine and am not likely to have one any time soon. I do run drongo and fairywren on an EC2 instance, but AWS doesn't seem

Re: [PATCH] Add native windows on arm64 support

2023-05-10 Thread Michael Paquier
On Thu, May 11, 2023 at 12:17:25PM +1200, Thomas Munro wrote: > Azure does have an image "Microsoft Windows 11 Preview arm64" to run > on Ampere CPUs, which says it's a pre-release version intended for > validation, which sounds approximately like what we want. I will try > to find out more.

Re: [PATCH] Add native windows on arm64 support

2023-05-10 Thread Thomas Munro
On Thu, May 11, 2023 at 11:34 AM Michael Paquier wrote: > On Wed, May 10, 2023 at 09:24:39AM -0400, Andrew Dunstan wrote: > > We will definitely want buildfarm support. I don't have such a machine and > > am not likely to have one any time soon. I do run drongo and fairywren on an > > EC2

Re: [PATCH] Add native windows on arm64 support

2023-05-10 Thread Michael Paquier
On Wed, May 10, 2023 at 09:24:39AM -0400, Andrew Dunstan wrote: > We will definitely want buildfarm support. I don't have such a machine and > am not likely to have one any time soon. I do run drongo and fairywren on an > EC2 instance, but AWS doesn't seem to have support for Windows on ARM. Maybe

Re: [PATCH] Add native windows on arm64 support

2023-05-10 Thread Andrew Dunstan
On 2023-05-08 Mo 15:58, Tom Lane wrote: Andres Freund writes: I don't really have feelings either way - but haven't we gone further and even backpatched things like spinlock support for new arches in the past? Mmmm ... don't really think those cases were comparable. We weren't adding

Re: [PATCH] Add native windows on arm64 support

2023-05-08 Thread Tom Lane
Andres Freund writes: > I don't really have feelings either way - but haven't we gone further and even > backpatched things like spinlock support for new arches in the past? Mmmm ... don't really think those cases were comparable. We weren't adding support for a whole new OS. Now, you might

Re: [PATCH] Add native windows on arm64 support

2023-05-08 Thread Andres Freund
Hi, On 2023-05-06 00:35:40 -0400, Tom Lane wrote: > Michael Paquier writes: > > Seeing how simple this has become, I would be really tempted to get > > that applied, especially if there's a buildfarm machine able to follow > > up.. On the one hand, we are in a stability period for v16, so it

Re: [PATCH] Add native windows on arm64 support

2023-05-06 Thread Michael Paquier
On Sat, May 06, 2023 at 12:35:40AM -0400, Tom Lane wrote: > Indeed, there's not much in this patch ... but it's impossible to see > how "run on an entirely new platform" isn't a new feature. Moreover, > it's a platform that very few of us will have any ability to support > or debug for. I can't

Re: [PATCH] Add native windows on arm64 support

2023-05-05 Thread Tom Lane
Michael Paquier writes: > Seeing how simple this has become, I would be really tempted to get > that applied, especially if there's a buildfarm machine able to follow > up.. On the one hand, we are in a stability period for v16, so it may > not be the best moment ever. On the other hand,

Re: [PATCH] Add native windows on arm64 support

2023-05-05 Thread Michael Paquier
On Tue, May 02, 2023 at 08:51:09AM +0100, Niyas Sait wrote: > I've attached a new version (v8) to fix the above indentation issue. > > Could someone please help with the review ? Seeing how simple this has become, I would be really tempted to get that applied, especially if there's a buildfarm

Re: [PATCH] Add native windows on arm64 support

2023-05-02 Thread Niyas Sait
On 19/01/2023 10:09, Niyas Sait wrote: On 17/01/2023 22:51, Andres Freund wrote:   int main(void) @@ -1960,18 +1966,19 @@ int main(void)   }   ''' -  if cc.links(prog, name: '__crc32cb, __crc32ch, __crc32cw, and __crc32cd without -march=armv8-a+crc', -  args: test_c_args) -    # Use

Re: [PATCH] Add native windows on arm64 support

2023-01-19 Thread Niyas Sait
On 17/01/2023 22:51, Andres Freund wrote: Hi, On 2022-12-16 10:52:23 +, Niyas Sait wrote: Subject: [PATCH v7] Enable postgres native build for windows-arm64 platform elif host_cpu == 'arm' or host_cpu == 'aarch64' - prog = ''' + if cc.get_id() == 'msvc' +

Re: [PATCH] Add native windows on arm64 support

2023-01-17 Thread Andres Freund
Hi, On 2022-12-16 10:52:23 +, Niyas Sait wrote: > Subject: [PATCH v7] Enable postgres native build for windows-arm64 platform > elif host_cpu == 'arm' or host_cpu == 'aarch64' > > - prog = ''' > + if cc.get_id() == 'msvc' > +cdata.set('USE_ARMV8_CRC32C', false) > +

Re: [PATCH] Add native windows on arm64 support

2023-01-17 Thread Niyas Sait
On 16/12/2022 10:52, Niyas Sait wrote: On 12/12/2022 23:56, Michael Paquier wrote: On Mon, Dec 12, 2022 at 01:38:37PM +, Niyas Sait wrote: On 05/12/2022 18:14, Andres Freund wrote: I think the old build system specific part is really minimal in the patch. I can strip out those if

Re: [PATCH] Add native windows on arm64 support

2022-12-16 Thread Niyas Sait
On 12/12/2022 23:56, Michael Paquier wrote: On Mon, Dec 12, 2022 at 01:38:37PM +, Niyas Sait wrote: On 05/12/2022 18:14, Andres Freund wrote: I think the old build system specific part is really minimal in the patch. I can strip out those if that's preferred. Removing all the changes from

Re: [PATCH] Add native windows on arm64 support

2022-12-12 Thread Michael Paquier
On Mon, Dec 12, 2022 at 01:38:37PM +, Niyas Sait wrote: > On 05/12/2022 18:14, Andres Freund wrote: > I think the old build system specific part is really minimal in the patch. I > can strip out those if that's preferred. Removing all the changes from src/tools/msvc/ is an approach that works

Re: [PATCH] Add native windows on arm64 support

2022-12-12 Thread Niyas Sait
Hi, On 05/12/2022 18:14, Andres Freund wrote: With meson gaining in maturity, perhaps that's not the most urgent thing as we will likely remove src/tools/msvc/ soon but I'd rather do that right anyway as much as I can to avoid an incorrect state in the tree at any time in its history. I'd

Re: [PATCH] Add native windows on arm64 support

2022-12-05 Thread Michael Paquier
On Mon, Dec 05, 2022 at 03:48:45PM -0800, Andres Freund wrote: > Yes, that's a typo. I meant that we shouldn't add arm64 support to > src/tools/msvc/. Okay, thanks. > I do think we should rip out src/tools/msvc/ soon-ish, but we need > buildfarm support first. Sure, let's see where it goes. --

Re: [PATCH] Add native windows on arm64 support

2022-12-05 Thread Andres Freund
Hi, On 2022-12-06 08:31:16 +0900, Michael Paquier wrote: > On Mon, Dec 05, 2022 at 10:14:49AM -0800, Andres Freund wrote: > > On 2022-12-05 14:12:41 +0900, Michael Paquier wrote: > >> With meson gaining in maturity, perhaps that's not the most urgent > >> thing as we will likely remove

Re: [PATCH] Add native windows on arm64 support

2022-12-05 Thread Michael Paquier
On Mon, Dec 05, 2022 at 10:14:49AM -0800, Andres Freund wrote: > On 2022-12-05 14:12:41 +0900, Michael Paquier wrote: >> With meson gaining in maturity, perhaps that's not the most urgent >> thing as we will likely remove src/tools/msvc/ soon but I'd rather do >> that right anyway as much as I can

Re: [PATCH] Add native windows on arm64 support

2022-12-05 Thread Andres Freund
Hi, On 2022-12-05 14:12:41 +0900, Michael Paquier wrote: > With meson gaining in maturity, perhaps that's not the most urgent > thing as we will likely remove src/tools/msvc/ soon but I'd rather do > that right anyway as much as I can to avoid an incorrect state in the > tree at any time in its

Re: [PATCH] Add native windows on arm64 support

2022-12-05 Thread Niyas Sait
On 05/12/2022 05:12, Michael Paquier wrote: - Last comes OpenSSL, that supports amd64_arm64 as build target (see NOTES-WINDOWS.md), and the library names are libssl.lib and libcrypto.lib. Looking at https://slproweb.com/products/Win32OpenSSL.html, there are experimental builds for arm64 with

Re: [PATCH] Add native windows on arm64 support

2022-12-04 Thread Michael Paquier
On Fri, Dec 02, 2022 at 11:09:15AM +, Niyas Sait wrote: > I've attached a new revision of the patch (v5) and includes following > changes, > > 1. Add support for meson build system > 2. Extend MSVC scripts to handle ARM64 platform. > 3. Add arm64 definition of spin_delay function. > 4.

Re: [PATCH] Add native windows on arm64 support

2022-12-02 Thread Niyas Sait
Hello, I've attached a new revision of the patch (v5) and includes following changes, 1. Add support for meson build system 2. Extend MSVC scripts to handle ARM64 platform. 3. Add arm64 definition of spin_delay function. 4. Exclude arm_acle.h import with MSVC compiler. V4->V5: * Added

Re: [PATCH] Add native windows on arm64 support

2022-12-02 Thread Niyas Sait
On 02/12/2022 05:41, John Naylor wrote: I couldn't find something more official for the sse2neon library part. Not quite sure what this is referring to, but it seems we can just point to the __aarch64__ section in the same file, which uses the same instruction: spin_delay(void) { __asm__

Re: [PATCH] Add native windows on arm64 support

2022-12-02 Thread Niyas Sait
On 02/12/2022 05:02, Michael Paquier wrote: Thanks for the updated version. I have been looking at it closely and it looks like it should be able to do the job (no arm64 machine for Windows here, sigh). I have one tiny comment about this part: - USE_ARMV8_CRC32C_WITH_RUNTIME_CHECK =>

Re: [PATCH] Add native windows on arm64 support

2022-12-01 Thread John Naylor
On Fri, Dec 2, 2022 at 12:20 AM Niyas Sait wrote: > > > On 07/11/2022 06:58, Michael Paquier wrote: > > Seems so. Hmm, where does _ARM64_BARRIER_SY come from? Perhaps it > > would be better to have a comment referring to it from a different > > place than the forums of arm, like some actual

Re: [PATCH] Add native windows on arm64 support

2022-12-01 Thread Michael Paquier
On Thu, Dec 01, 2022 at 05:53:47PM +, Niyas Sait wrote: > I've attached a new revision of the patch (v4) and includes following > changes, > > 1. Add support for meson build system > 2. Extend MSVC scripts to handle ARM64 platform. > 3. Add arm64 definition of spin_delay function. > 4.

  1   2   >