Re: [PATCH] Add section headings to index types doc

2020-11-25 Thread Tom Lane
=?UTF-8?Q?J=c3=bcrgen_Purtz?= writes: > Attached are two patches: a) summary against master and b) standalone of > my current changes. This was a bit confused ... as submitted, the patch wanted to commit a couple of patchfiles. I sorted it out I believe, and pushed with a little additional

Re: [PATCH] Add section headings to index types doc

2020-10-25 Thread Jürgen Purtz
On 23.10.20 18:08, David G. Johnston wrote: On Fri, Oct 23, 2020 at 3:18 AM Jürgen Purtz > wrote: and add a link to the "CREATE INDEX" command from the chapter preamble. is the link necessary? I suppose it would make more sense to add it to the previous

Re: [PATCH] Add section headings to index types doc

2020-10-23 Thread David G. Johnston
On Fri, Oct 23, 2020 at 3:18 AM Jürgen Purtz wrote: > and add a link to the "CREATE INDEX" command from the chapter preamble. > > is the link necessary? > I suppose it would make more sense to add it to the previous section - the introduction page. I do think having a link (or more than one)

Re: [PATCH] Add section headings to index types doc

2020-10-23 Thread Jürgen Purtz
On 21.10.20 23:12, David G. Johnston wrote: On Wed, Sep 30, 2020 at 4:25 AM Dagfinn Ilmari Mannsåker mailto:ilm...@ilmari.org>> wrote: Michael Paquier mailto:mich...@paquier.xyz>> writes: > On Mon, Aug 10, 2020 at 12:52:17PM +, Jürgen Purtz wrote: >> The new status of this

Re: [PATCH] Add section headings to index types doc

2020-10-21 Thread David G. Johnston
On Wed, Sep 30, 2020 at 4:25 AM Dagfinn Ilmari Mannsåker wrote: > Michael Paquier writes: > > > On Mon, Aug 10, 2020 at 12:52:17PM +, Jürgen Purtz wrote: > >> The new status of this patch is: Waiting on Author > > > > This has not been answered yet, so I have marked the patch as returned >

Re: [PATCH] Add section headings to index types doc

2020-10-02 Thread Jürgen Purtz
On 30.09.20 14:53, Heikki Linnakangas wrote: On 30/09/2020 14:25, Dagfinn Ilmari Mannsåker wrote: Michael Paquier writes: On Mon, Aug 10, 2020 at 12:52:17PM +, Jürgen Purtz wrote: The new status of this patch is: Waiting on Author This has not been answered yet, so I have marked the

Re: [PATCH] Add section headings to index types doc

2020-09-30 Thread Heikki Linnakangas
On 30/09/2020 14:25, Dagfinn Ilmari Mannsåker wrote: Michael Paquier writes: On Mon, Aug 10, 2020 at 12:52:17PM +, Jürgen Purtz wrote: The new status of this patch is: Waiting on Author This has not been answered yet, so I have marked the patch as returned with feedback. Updated

Re: [PATCH] Add section headings to index types doc

2020-09-30 Thread Dagfinn Ilmari Mannsåker
Michael Paquier writes: > On Mon, Aug 10, 2020 at 12:52:17PM +, Jürgen Purtz wrote: >> The new status of this patch is: Waiting on Author > > This has not been answered yet, so I have marked the patch as returned > with feedback. Updated patch attached, wich reformats the operator lists as

Re: [PATCH] Add section headings to index types doc

2020-09-30 Thread Michael Paquier
On Mon, Aug 10, 2020 at 12:52:17PM +, Jürgen Purtz wrote: > The new status of this patch is: Waiting on Author This has not been answered yet, so I have marked the patch as returned with feedback. -- Michael signature.asc Description: PGP signature

Re: [PATCH] Add section headings to index types doc

2020-08-10 Thread Jürgen Purtz
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:tested, passed a) I'm wondering if we should apply one more change to this page. The

Re: [PATCH] Add section headings to index types doc

2020-08-03 Thread Tom Lane
ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > Also, for easier review, here's the `git diff -w` output, since the > tags caused most of the page to have to be renidented. TBH, I'd suggest just not being anal about whether the indentation nesting is perfect ;-). There

Re: [PATCH] Add section headings to index types doc

2020-08-03 Thread Magnus Hagander
On Mon, Aug 3, 2020 at 1:32 PM Dagfinn Ilmari Mannsåker wrote: > ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > > > Hi hackers, > > > > Every time I have to look up what kinds of operations each index type is > > suitable for, I get annoyed by the index types page being virtually > >

Re: [PATCH] Add section headings to index types doc

2020-08-03 Thread Dagfinn Ilmari Mannsåker
ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > Hi hackers, > > Every time I have to look up what kinds of operations each index type is > suitable for, I get annoyed by the index types page being virtually > unskimmable due to not having headings for each index type. > > Attached is a

[PATCH] Add section headings to index types doc

2020-07-31 Thread Dagfinn Ilmari Mannsåker
Hi hackers, Every time I have to look up what kinds of operations each index type is suitable for, I get annoyed by the index types page being virtually unskimmable due to not having headings for each index type. Attached is a patch that adds tags for each index type to make it easier to see