Re: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2020-01-31 Thread Amit Kapila
On Mon, Nov 25, 2019 at 1:17 PM Michael Paquier wrote: > > On Mon, Sep 09, 2019 at 05:34:43PM +0530, Amit Kapila wrote: > > The only difference is in the last line where for me it gives > > assertion failure when trying to do ReleaseAuxProcessResources. Below > > is the callstack: > > No need

Re: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2019-11-24 Thread Michael Paquier
On Mon, Sep 09, 2019 at 05:34:43PM +0530, Amit Kapila wrote: > The only difference is in the last line where for me it gives > assertion failure when trying to do ReleaseAuxProcessResources. Below > is the callstack: No need for Windows on this one and I have reproduced easily the same trace as

Re: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2019-09-09 Thread Amit Kapila
On Sat, Jul 27, 2019 at 6:22 AM Chengchao Yu wrote: > > Thus, I have updated the patch v3 according to your suggestions. Could you > help to review again? > Please let me know should you have more suggestions or feedbacks. > I have tried to look into this patch and I don't think it fixes the

RE: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2019-07-26 Thread Chengchao Yu
Hi Kyotaro, Thank you so much for your valued feedback and suggestions! > I assume that we are in a consensus about the problem we are to fix here. > > > 0a 0004`8080cc30 0004`80dcf917 postgres!PGSemaphoreLock+0x65 > > [d:\orcasqlagsea10\14\s\src\backend\port\win32_sema.c @ 158] 0b >

RE: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2019-07-24 Thread Kyotaro Horiguchi
Sorry in advance for link-breaking message force by gmail.. https://www.postgresql.org/message-id/flat/cy4pr2101mb0804ce9836e582c0702214e8aa...@cy4pr2101mb0804.namprd21.prod.outlook.com I assume that we are in a consensus about the problem we are to fix here. > 0a 0004`8080cc30

RE: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2019-03-03 Thread Chengchao Yu
Sent: Monday, February 18, 2019 6:08 PM To: Amit Kapila Cc: Thomas Munro ; Pg Hackers ; Prabhat Tripathi ; Sunil Kamath ; Michal Primke ; TEJA Mupparti Subject: RE: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs Thank you so much Amit! I have created the patch

RE: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2019-02-18 Thread Chengchao Yu
/services/postgresql/ -Original Message- From: Amit Kapila Sent: Friday, February 1, 2019 6:58 PM To: Chengchao Yu Cc: Thomas Munro ; Pg Hackers ; Prabhat Tripathi ; Sunil Kamath ; Michal Primke ; TEJA Mupparti Subject: Re: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO

Re: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2019-02-01 Thread Amit Kapila
On Sat, Feb 2, 2019 at 4:42 AM Chengchao Yu wrote: > > Hi Amit, Thomas, > > Thank you very much for your feedbacks! Apologizes but I just saw both > messages. > > > We generally reserve the space in a relation before attempting to write, so > > not sure how you are able to hit the disk full

RE: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2019-02-01 Thread Chengchao Yu
l/ -Original Message- From: Thomas Munro Sent: Thursday, January 24, 2019 2:32 PM To: Amit Kapila Cc: Chengchao Yu ; Pg Hackers ; Prabhat Tripathi ; Sunil Kamath ; Michal Primke Subject: Re: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs On Sun, Jan 2

Re: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2019-01-24 Thread Thomas Munro
On Sun, Jan 20, 2019 at 4:45 PM Amit Kapila wrote: > On Sat, Dec 1, 2018 at 2:30 AM Chengchao Yu wrote: > > Recently, we hit a few occurrences of deadlock when IO failure (including > > disk full, random remote disk IO failures) happens in single user mode. We > > found the issue exists on

Re: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2019-01-19 Thread Amit Kapila
On Sat, Dec 1, 2018 at 2:30 AM Chengchao Yu wrote: > > > Recently, we hit a few occurrences of deadlock when IO failure (including > disk full, random remote disk IO failures) happens in single user mode. We > found the issue exists on both Linux and Windows in multiple postgres > versions. >

RE: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2019-01-02 Thread Chengchao Yu
: Prabhat Tripathi mailto:pt...@microsoft.com>>; Sunil Kamath mailto:sunil.kam...@microsoft.com>>; Michal Primke mailto:mpri...@microsoft.com>> Subject: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs Greetings, Recently, we hit a few occ

RE: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2018-12-19 Thread Chengchao Yu
Engineer | Microsoft | Azure Database for PostgreSQL https://azure.microsoft.com/en-us/services/postgresql/ From: Chengchao Yu Sent: Friday, November 30, 2018 1:00 PM To: 'Pg Hackers' Cc: Prabhat Tripathi ; Sunil Kamath ; Michal Primke Subject: [PATCH] Fix Proposal - Deadlock Issue in Single

Re: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2018-12-01 Thread Jesse Zhang
Hey Chengyu, How did you set up your GDB to get "p" to pretty-print a Postgres list? Cheers, Jesse On Fri, Nov 30, 2018 at 1:00 PM Chengchao Yu wrote: > Greetings, > > > > Recently, we hit a few occurrences of deadlock when IO failure (including > disk full, random remote disk IO failures)

[PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

2018-11-30 Thread Chengchao Yu
Greetings, Recently, we hit a few occurrences of deadlock when IO failure (including disk full, random remote disk IO failures) happens in single user mode. We found the issue exists on both Linux and Windows in multiple postgres versions. Here are the steps to repro on Linux (as Windows