Re: [PATCH] Implement motd for PostgreSQL

2021-04-05 Thread Joel Jacobson
On Sun, Apr 4, 2021, at 20:42, Dagfinn Ilmari Mannsåker wrote: > Fabien COELHO mailto:coelho%40cri.ensmp.fr>> writes: > > >>> The actual source looks pretty straightforward. I'm wondering whether pg > >>> style would suggest to write motd != NULL instead of just motd. > >> > >> That's what I had

Re: [PATCH] Implement motd for PostgreSQL

2021-04-04 Thread Dagfinn Ilmari Mannsåker
Fabien COELHO writes: >>> The actual source looks pretty straightforward. I'm wondering whether pg >>> style would suggest to write motd != NULL instead of just motd. >> >> That's what I had originally, but when reviewing my code verifying code >> style, >> I noticed the other case it more

Re: [PATCH] Implement motd for PostgreSQL

2021-04-04 Thread Joel Jacobson
On Sun, Apr 4, 2021, at 09:16, Fabien COELHO wrote: > If other cases are indeed pointers. For pgbench, all direct "if (xxx &&" > cases are simple booleans or integers, pointers seem to have "!= NULL". > While looking quickly at the grep output, ISTM that most obvious pointers > have "!= NULL"

Re: [PATCH] Implement motd for PostgreSQL

2021-04-04 Thread Fabien COELHO
Hello Joel, My 0.02€: If such a feature gets considered, I'm not sure I'd like to actually edit pg configuration file to change the message. For the ALTER SYSTEM case, the value would be written to postgresql.auto.conf, and that file we shouldn't edit manually anyway, right? Sure. I meant

Re: [PATCH] Implement motd for PostgreSQL

2021-04-04 Thread Joel Jacobson
On Sun, Apr 4, 2021, at 07:55, Joel Jacobson wrote: > On Sat, Apr 3, 2021, at 17:50, Fabien COELHO wrote: >> I'm wondering whether it should be possible to designate (1) a file the >> content of which would be shown, or (2) a command, the output of which >> would be shown [ok, there might be

Re: [PATCH] Implement motd for PostgreSQL

2021-04-03 Thread Joel Jacobson
On Sat, Apr 3, 2021, at 17:50, Fabien COELHO wrote: > > Perhaps the configuration-file parser has been fixed since to support > > embedded newlines? If so, then maybe it would actually be an idea to > > support newlines by escaping them? > > Dunno. > > If such a feature gets considered, I'm

Re: [PATCH] Implement motd for PostgreSQL

2021-04-03 Thread Alvaro Herrera
On 2021-Apr-03, Joel Jacobson wrote: > I'm actually using it myself in production for something, to display > instructions to users when they login. Yeah, such as "If your CREATE sentences don't work, please run CREATE SCHEMA AUTHORIZATION CURRENT_USER" for systems where the PUBLIC schema has

Re: [PATCH] Implement motd for PostgreSQL

2021-04-03 Thread Chapman Flack
On 04/03/21 14:24, Joel Jacobson wrote: > Thanks for noticing. > I've updated the ascii art now using the version from swisspug.org, > does it look correct now to you? > > $ psql -U brad -h pit.org motd > > NOTICE: > __ ___ > /)/ \/ \ > ( / ___\) > \(/ o)

Re: [PATCH] Implement motd for PostgreSQL

2021-04-03 Thread Joel Jacobson
On Sat, Apr 3, 2021, at 15:43, Chapman Flack wrote: > Now there's some kind of Max Headroom thing going on with the second row, > and this time I'm not sure how to explain it. (I knew the backslashes were > because they weren't doubled.) > > I have done 'view source' in my mail client to make

Re: [PATCH] Implement motd for PostgreSQL

2021-04-03 Thread Fabien COELHO
Perhaps the configuration-file parser has been fixed since to support embedded newlines? If so, then maybe it would actually be an idea to support newlines by escaping them? Dunno. If such a feature gets considered, I'm not sure I'd like to actually edit pg configuration file to change

Re: [PATCH] Implement motd for PostgreSQL

2021-04-03 Thread Chapman Flack
On 04/03/21 01:20, Joel Jacobson wrote: > I've deployed the fix to production: > > $ psql -U brad -h pit.org motd > > NOTICE: > __ ___ > /)/ \/ \ > ( / ___\) > \(/ o) ( o) ) >\_ (_ ) \ ) / > \ /\_/\)_/ > \/ //| |\\ >

Re: [PATCH] Implement motd for PostgreSQL

2021-04-03 Thread Joel Jacobson
On Sat, Apr 3, 2021, at 10:14, Fabien COELHO wrote: > > Hello Joel, > > > This patch is one day late, my apologies for missing the deadline this year. > > > > PostgreSQL has since long been suffering from the lack of a proper UNIX > > style motd (message of the day). > > My 0.02€: apart from

Re: [PATCH] Implement motd for PostgreSQL

2021-04-03 Thread Fabien COELHO
Hello Joel, This patch is one day late, my apologies for missing the deadline this year. PostgreSQL has since long been suffering from the lack of a proper UNIX style motd (message of the day). My 0.02€: apart from the Fool's day joke dimension, I'd admit that I would not mind actually

Re: [PATCH] Implement motd for PostgreSQL

2021-04-03 Thread Charles Clavadetscher
Hi On 2021-04-03 07:16, Joel Jacobson wrote: On Sat, Apr 3, 2021, at 04:47, Michael Paquier wrote: On Fri, Apr 02, 2021 at 10:46:16PM +0200, Joel Jacobson wrote: Ascii elephant in example by Michael Paquier [1], with ANSI colors added by me. [1]

Re: [PATCH] Implement motd for PostgreSQL

2021-04-03 Thread Joel Jacobson
On Fri, Apr 2, 2021, at 23:09, Marko Tiikkaja wrote: > Hi Joel > > On Fri, Apr 2, 2021 at 11:47 PM Joel Jacobson wrote: >> PostgreSQL has since long been suffering from the lack of a proper UNIX >> style motd (message of the day). > > First of all, thanks for your work on this! I think this

Re: [PATCH] Implement motd for PostgreSQL

2021-04-02 Thread Joel Jacobson
On Fri, Apr 2, 2021, at 22:59, Chapman Flack wrote: > Slonik's backslashes are falling off. Eww. > > Regards, > -Chap Thanks for the bug report. Fixed by properly escaping backslackes: ALTER SYSTEM SET motd TO E'\u001B[94m' '\n __ ___ ' '\n /)/ \\/ \\ ' '\n ( / __

Re: [PATCH] Implement motd for PostgreSQL

2021-04-02 Thread Joel Jacobson
On Sat, Apr 3, 2021, at 04:47, Michael Paquier wrote: > On Fri, Apr 02, 2021 at 10:46:16PM +0200, Joel Jacobson wrote: > > Ascii elephant in example by Michael Paquier [1], with ANSI colors added by > > me. > > > > [1] > >

Re: [PATCH] Implement motd for PostgreSQL

2021-04-02 Thread Joel Jacobson
On Fri, Apr 2, 2021, at 22:51, Bruce Momjian wrote: > On Fri, Apr 2, 2021 at 10:46:16PM +0200, Joel Jacobson wrote: > > Dear fellow hackers, > > > > This patch is one day late, my apologies for missing the deadline this year. > > Uh, the deadline for the last commitfest was March 1, 2021, not

Re: [PATCH] Implement motd for PostgreSQL

2021-04-02 Thread Michael Paquier
On Fri, Apr 02, 2021 at 10:46:16PM +0200, Joel Jacobson wrote: > Ascii elephant in example by Michael Paquier [1], with ANSI colors added by > me. > > [1] > https://www.postgresql.org/message-id/CAB7nPqRaacwcaANOYY3Hxd3T0No5RdZXyqM5HB6fta%2BCoDLOEg%40mail.gmail.com The credit here goes to

Re: [PATCH] Implement motd for PostgreSQL

2021-04-02 Thread Bruce Momjian
On Fri, Apr 2, 2021 at 10:46:16PM +0200, Joel Jacobson wrote: > Dear fellow hackers, > > This patch is one day late, my apologies for missing the deadline this year. Uh, the deadline for the last commitfest was March 1, 2021, not April 1. -- Bruce Momjian https://momjian.us EDB

Re: [PATCH] Implement motd for PostgreSQL

2021-04-02 Thread Marko Tiikkaja
Hi Joel On Fri, Apr 2, 2021 at 11:47 PM Joel Jacobson wrote: > PostgreSQL has since long been suffering from the lack of a proper UNIX > style motd (message of the day). > First of all, thanks for your work on this! I think this is an important feature to have, but I would love to see a way

Re: [PATCH] Implement motd for PostgreSQL

2021-04-02 Thread Chapman Flack
On 04/02/21 16:46, Joel Jacobson wrote: > __ ___ > /)/ / > ( / ___) > (/ o) ( o) ) >_ (_ )) / >/_/)_/ > / //| |\ > v | | v > __/ Slonik's backslashes are falling off. Eww. Regards, -Chap

[PATCH] Implement motd for PostgreSQL

2021-04-02 Thread Joel Jacobson
Dear fellow hackers, This patch is one day late, my apologies for missing the deadline this year. PostgreSQL has since long been suffering from the lack of a proper UNIX style motd (message of the day). DBAs have no ways of conveying important information to users, having to rely on external