Re: [PATCH] Improvements to "Getting started" tutorial for Google Code-in task

On Sat, Jan 05, 2019 at 04:21:23PM +0100, Peter Eisentraut wrote: > On 04/01/2019 00:05, Alvaro Herrera wrote: >> Besides that, I have a hard time considering this patch committable. >> There are some good additions, but they are mixed with some wording >> changes that seem to be there just

Re: [PATCH] Improvements to "Getting started" tutorial for Google Code-in task

On 04/01/2019 00:05, Alvaro Herrera wrote: > Besides that, I have a hard time considering this patch committable. > There are some good additions, but they are mixed with some wording > changes that seem to be there just because the author doesn't like the > original, not because they're actual

Re: [PATCH] Improvements to "Getting started" tutorial for Google Code-in task

On 2018-Nov-06, LAM JUN RONG wrote: > Hi, > > I must have forgotten to change the diff. I noticed that you edited the diff by hand -- the line count in the last hunk doesn't match. This causes both "path" and "git apply" to reject the patch saying it's corrupted. I suggest not to do that. I

Re: [PATCH] Improvements to "Getting started" tutorial for Google Code-in task

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested This is a documentation update, no code changes. The initial idea came from

RE: [PATCH] Improvements to "Getting started" tutorial for Google Code-in task

Hi, I must have forgotten to change the diff. A revised diff is attached. Jun Rong From: Andreas 'ads' Scherbaum Sent: Tuesday, November 6, 2018 8:41:15 AM To: LAM JUN RONG; pgsql-hack...@postgresql.org Subject: Re: [PATCH] Improvements to "Getting started"

Re: [PATCH] Improvements to "Getting started" tutorial for Google Code-in task

On 05.11.18 09:22, LAM JUN RONG wrote: New diff is attached. This still has the "hard" in it. Everything else looks fine. Once you changed that, please register the new patch in the Commitfest application. Regards, -- Andreas 'ads' Scherbaum German

RE: [PATCH] Improvements to "Getting started" tutorial for Google Code-in task

Hi, > If you are not sure whether PostgreSQL > -is already available or whether you can use it for your > -experimentation then you can install it yourself. Doing so is not > +is already available for your experimentation, > +you can install it yourself. Doing so is not >

Re: [PATCH] Improvements to "Getting started" tutorial for Google Code-in task

On 04.11.18 02:53, LAM JUN RONG wrote: Hi, I have made some changes based on Andreas’ suggestions. > +    then one or more of the packages PostgreSQL requires is not installed. > +    See for the required packages. > > How about: > then packages which are required to build >

RE: [PATCH] Improvements to "Getting started" tutorial for Google Code-in task

Hi, I have made some changes based on Andreas’ suggestions. > +then one or more of the packages PostgreSQL > requires is not installed. > +See for the required packages. > > How about: > then packages which are required to build > PostgreSQL are missing. > See for a list of

Re: [PATCH] Improvements to "Getting started" tutorial for Google Code-in task

Thanks for your feedback. I'll make some changes based on your suggestions and send a new diff. Thanks! From: Andreas 'ads' Scherbaum Sent: Saturday, November 3, 2018 9:17:54 PM To: LAM JUN RONG; pgsql-hack...@postgresql.org Subject: Re: [PATCH] Improvements to "Getting started" tutorial for

Re: [PATCH] Improvements to "Getting started" tutorial for Google Code-in task

Hello, On 02.11.18 14:07, LAM JUN RONG wrote: I’m a student taking part in Google Code-in 2018. The task I am currently working on, https://codein.withgoogle.com/dashboard/task-instances/6406170207059968/, requires that I review and improve the “Getting Started”

[PATCH] Improvements to "Getting started" tutorial for Google Code-in task

Hi, I’m a student taking part in Google Code-in 2018. The task I am currently working on, https://codein.withgoogle.com/dashboard/task-instances/6406170207059968/, requires that I review and improve the “Getting Started” tutorial in the PostgreSQL docs, and submit