Re: [PATCH] Simple progress reporting for COPY command

2021-01-08 Thread Bharath Rupireddy
On Fri, Jan 8, 2021 at 7:00 PM Matthias van de Meent wrote: > On Thu, 7 Jan 2021 at 23:00, Josef Šimánek wrote: > > > > čt 7. 1. 2021 v 22:37 odesílatel Tomas Vondra > > napsal: > > > > > > I'm not particularly attached to the "lines" naming, it just seemed OK > > > to me. So if there's

Re: [PATCH] Simple progress reporting for COPY command

2021-01-08 Thread Matthias van de Meent
On Thu, 7 Jan 2021 at 23:00, Josef Šimánek wrote: > > čt 7. 1. 2021 v 22:37 odesílatel Tomas Vondra > napsal: > > > > I'm not particularly attached to the "lines" naming, it just seemed OK > > to me. So if there's consensus to rename this somehow, I'm OK with it. > > The problem I do see here is

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Amit Kapila
On Fri, Jan 8, 2021 at 9:45 AM Josef Šimánek wrote: > > pá 8. 1. 2021 v 5:03 odesílatel Amit Kapila napsal: > > > > On Fri, Jan 8, 2021 at 8:42 AM Josef Šimánek > > wrote: > > > > > > pá 8. 1. 2021 v 3:55 odesílatel Amit Kapila > > > napsal: > > > > > > > > > > > > Can't we display the

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Josef Šimánek
pá 8. 1. 2021 v 5:03 odesílatel Amit Kapila napsal: > > On Fri, Jan 8, 2021 at 8:42 AM Josef Šimánek wrote: > > > > pá 8. 1. 2021 v 3:55 odesílatel Amit Kapila > > napsal: > > > > > > > > > Can't we display the entire COPY command? I checked that > > > pg_stat_statements display the query so

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Amit Kapila
On Fri, Jan 8, 2021 at 8:42 AM Josef Šimánek wrote: > > pá 8. 1. 2021 v 3:55 odesílatel Amit Kapila napsal: > > > > > > Can't we display the entire COPY command? I checked that > > pg_stat_statements display the query so there shouldn't be a problem > > to display the entire command. > > In

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Josef Šimánek
pá 8. 1. 2021 v 3:55 odesílatel Amit Kapila napsal: > > On Thu, Jan 7, 2021 at 7:02 PM Josef Šimánek wrote: > > > > čt 7. 1. 2021 v 14:08 odesílatel Amit Kapila > > napsal: > > > > > > On Thu, Jan 7, 2021 at 3:15 AM Tomas Vondra > > > wrote: > > > > > > > > On 1/5/21 11:02 AM, Josef Šimánek

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Amit Kapila
On Thu, Jan 7, 2021 at 7:02 PM Josef Šimánek wrote: > > čt 7. 1. 2021 v 14:08 odesílatel Amit Kapila napsal: > > > > On Thu, Jan 7, 2021 at 3:15 AM Tomas Vondra > > wrote: > > > > > > On 1/5/21 11:02 AM, Josef Šimánek wrote: > > > > I'm attaching the whole patch since commitfest failed to

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Josef Šimánek
čt 7. 1. 2021 v 22:37 odesílatel Tomas Vondra napsal: > > > > On 1/7/21 7:56 PM, Josef Šimánek wrote: > > čt 7. 1. 2021 v 19:51 odesílatel Matthias van de Meent > > napsal: > >> > >> On Wed, 6 Jan 2021 at 22:45, Tomas Vondra > >> wrote: > >>> > >>> On 1/5/21 11:02 AM, Josef Šimánek wrote: >

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Tomas Vondra
On 1/7/21 7:56 PM, Josef Šimánek wrote: čt 7. 1. 2021 v 19:51 odesílatel Matthias van de Meent napsal: On Wed, 6 Jan 2021 at 22:45, Tomas Vondra wrote: On 1/5/21 11:02 AM, Josef Šimánek wrote: I'm attaching the whole patch since commitfest failed to ingest the last incremental on CI.

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Josef Šimánek
čt 7. 1. 2021 v 19:51 odesílatel Matthias van de Meent napsal: > > On Wed, 6 Jan 2021 at 22:45, Tomas Vondra > wrote: > > > > On 1/5/21 11:02 AM, Josef Šimánek wrote: > > > I'm attaching the whole patch since commitfest failed to ingest the > > > last incremental on CI. > > > > > > > Yeah, the

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Matthias van de Meent
On Wed, 6 Jan 2021 at 22:45, Tomas Vondra wrote: > > On 1/5/21 11:02 AM, Josef Šimánek wrote: > > I'm attaching the whole patch since commitfest failed to ingest the > > last incremental on CI. > > > > Yeah, the whole patch needs to be attached for the commitfest tester to > work correctly - it

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Tomas Vondra
On 1/7/21 2:17 AM, Justin Pryzby wrote: On Wed, Jan 06, 2021 at 10:44:49PM +0100, Tomas Vondra wrote: On 1/5/21 11:02 AM, Josef Šimánek wrote: I'm attaching the whole patch since commitfest failed to ingest the last incremental on CI. Yeah, the whole patch needs to be attached for the

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Josef Šimánek
čt 7. 1. 2021 v 16:54 odesílatel Tomas Vondra napsal: > > > > On 1/7/21 12:06 PM, Josef Šimánek wrote: > > st 6. 1. 2021 v 22:44 odesílatel Tomas Vondra > > napsal: > >> > >> On 1/5/21 11:02 AM, Josef Šimánek wrote: > >>> I'm attaching the whole patch since commitfest failed to ingest the > >>>

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Tomas Vondra
On 1/7/21 12:06 PM, Josef Šimánek wrote: st 6. 1. 2021 v 22:44 odesílatel Tomas Vondra napsal: On 1/5/21 11:02 AM, Josef Šimánek wrote: I'm attaching the whole patch since commitfest failed to ingest the last incremental on CI. Yeah, the whole patch needs to be attached for the

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Josef Šimánek
čt 7. 1. 2021 v 14:08 odesílatel Amit Kapila napsal: > > On Thu, Jan 7, 2021 at 3:15 AM Tomas Vondra > wrote: > > > > On 1/5/21 11:02 AM, Josef Šimánek wrote: > > > I'm attaching the whole patch since commitfest failed to ingest the > > > last incremental on CI. > > > > > > > Yeah, the whole

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Amit Kapila
On Thu, Jan 7, 2021 at 3:15 AM Tomas Vondra wrote: > > On 1/5/21 11:02 AM, Josef Šimánek wrote: > > I'm attaching the whole patch since commitfest failed to ingest the > > last incremental on CI. > > > > Yeah, the whole patch needs to be attached for the commitfest tester to > work correctly - it

Re: [PATCH] Simple progress reporting for COPY command

2021-01-07 Thread Josef Šimánek
st 6. 1. 2021 v 22:44 odesílatel Tomas Vondra napsal: > > On 1/5/21 11:02 AM, Josef Šimánek wrote: > > I'm attaching the whole patch since commitfest failed to ingest the > > last incremental on CI. > > > > Yeah, the whole patch needs to be attached for the commitfest tester to > work correctly -

Re: [PATCH] Simple progress reporting for COPY command

2021-01-06 Thread Justin Pryzby
On Wed, Jan 06, 2021 at 10:44:49PM +0100, Tomas Vondra wrote: > On 1/5/21 11:02 AM, Josef Šimánek wrote: > > I'm attaching the whole patch since commitfest failed to ingest the > > last incremental on CI. > > > > Yeah, the whole patch needs to be attached for the commitfest tester to work >

Re: [PATCH] Simple progress reporting for COPY command

2021-01-06 Thread Tomas Vondra
On 1/5/21 11:02 AM, Josef Šimánek wrote: I'm attaching the whole patch since commitfest failed to ingest the last incremental on CI. Yeah, the whole patch needs to be attached for the commitfest tester to work correctly - it can't apply pieces from multiple messages, etc. Anyway, I pushed

Re: [PATCH] Simple progress reporting for COPY command

2021-01-05 Thread Matthias van de Meent
On Fri, 1 Jan 2021 at 02:25, Josef Šimánek wrote: > > Hello, > > finally I had some time to revisit patch and all comments from > https://www.postgresql.org/message-id/CAFp7QwqMGEi4OyyaLEK9DR0%2BE%2BoK3UtA4bEjDVCa4bNkwUY2PQ%40mail.gmail.com > and I have prepared simple version of COPY command

Re: [PATCH] Simple progress reporting for COPY command

2021-01-05 Thread Josef Šimánek
I'm attaching the whole patch since commitfest failed to ingest the last incremental on CI. út 5. 1. 2021 v 2:32 odesílatel Josef Šimánek napsal: > > út 5. 1. 2021 v 0:46 odesílatel Tomas Vondra > napsal: > > > > Hi, > > > > I did take a quick look today, and I have a couple minor comments: >

Re: [PATCH] Simple progress reporting for COPY command

2021-01-04 Thread Josef Šimánek
út 5. 1. 2021 v 0:46 odesílatel Tomas Vondra napsal: > > Hi, > > I did take a quick look today, and I have a couple minor comments: Hi! Thanks for your time. > 1) The catalog sgml docs seem to mention bytes_processed twice (one of > that should be bytes_total), and line_processed (should be

Re: [PATCH] Simple progress reporting for COPY command

2021-01-04 Thread Tomas Vondra
Hi, I did take a quick look today, and I have a couple minor comments: 1) The catalog sgml docs seem to mention bytes_processed twice (one of that should be bytes_total), and line_processed (should be "lines_"). 2) I'm not quite sure about not including any info about the command. For

Re: [PATCH] Simple progress reporting for COPY command

2021-01-01 Thread Josef Šimánek
pá 1. 1. 2021 v 11:16 odesílatel Bharath Rupireddy napsal: > > On Fri, Jan 1, 2021 at 6:55 AM Josef Šimánek wrote: > > finally I had some time to revisit patch and all comments from > > https://www.postgresql.org/message-id/CAFp7QwqMGEi4OyyaLEK9DR0%2BE%2BoK3UtA4bEjDVCa4bNkwUY2PQ%40mail.gmail.com

Re: [PATCH] Simple progress reporting for COPY command

2021-01-01 Thread Bharath Rupireddy
On Fri, Jan 1, 2021 at 6:55 AM Josef Šimánek wrote: > finally I had some time to revisit patch and all comments from > https://www.postgresql.org/message-id/CAFp7QwqMGEi4OyyaLEK9DR0%2BE%2BoK3UtA4bEjDVCa4bNkwUY2PQ%40mail.gmail.com > and I have prepared simple version of COPY command progress

[PATCH] Simple progress reporting for COPY command

2020-12-31 Thread Josef Šimánek
Hello, finally I had some time to revisit patch and all comments from https://www.postgresql.org/message-id/CAFp7QwqMGEi4OyyaLEK9DR0%2BE%2BoK3UtA4bEjDVCa4bNkwUY2PQ%40mail.gmail.com and I have prepared simple version of COPY command progress reporting. To keep the patch small as possible, I have