Re: [Patch] Add a reset_computed_values function in pg_stat_statements

2019-11-30 Thread Michael Paquier
On Tue, Nov 05, 2019 at 11:03:58AM +1300, Thomas Munro wrote: > In contrib/pg_stat_statements/pg_stat_statements.c, you need to > declare or define entry_reset_computed() before you use it. I suppose > your compiler must be warning about that. I personally put > "COPT=-Wall -Werror" into

Re: [Patch] Add a reset_computed_values function in pg_stat_statements

2019-11-04 Thread Thomas Munro
On Thu, Sep 26, 2019 at 8:05 AM Alvaro Herrera wrote: > This patch seems to be failing the contrib build. Please fix. Hi Pierre, In contrib/pg_stat_statements/pg_stat_statements.c, you need to declare or define entry_reset_computed() before you use it. I suppose your compiler must be warning

Re: [Patch] Add a reset_computed_values function in pg_stat_statements

2019-09-25 Thread Alvaro Herrera
This patch seems to be failing the contrib build. Please fix. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [Patch] Add a reset_computed_values function in pg_stat_statements

2019-09-03 Thread Pierre Ducroquet
On Monday, September 2, 2019 3:25:00 AM CEST Euler Taveira wrote: > Em dom, 1 de set de 2019 às 06:04, Pierre Ducroquet > > escreveu: > > Hello > > > > pg_stat_statements is a great tool to track performance issue in live > > databases, especially when adding interfaces like PoWA on top of it.

Re: [Patch] Add a reset_computed_values function in pg_stat_statements

2019-09-01 Thread Euler Taveira
Em dom, 1 de set de 2019 às 06:04, Pierre Ducroquet escreveu: > > Hello > > pg_stat_statements is a great tool to track performance issue in live > databases, especially when adding interfaces like PoWA on top of it. > But so far, tools like PoWA can not track the min_time, max_time, mean_time >

[Patch] Add a reset_computed_values function in pg_stat_statements

2019-09-01 Thread Pierre Ducroquet
Hello pg_stat_statements is a great tool to track performance issue in live databases, especially when adding interfaces like PoWA on top of it. But so far, tools like PoWA can not track the min_time, max_time, mean_time and sum_var_time of queries : these statistics are cumulated over time,