Re: A small tweak to some comments for PartitionKeyData

2018-11-20 Thread David Rowley
On Fri, 16 Nov 2018 at 11:23, Peter Eisentraut wrote: > committed Thank you. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: A small tweak to some comments for PartitionKeyData

2018-11-15 Thread Peter Eisentraut
On 25/10/2018 05:43, David Rowley wrote: > While doing a bit of work on a partitioning patch I noticed that it's > not really that obvious that there's meant to be exactly 1 item in the > partexprs List for each zero-valued partattrs element. Some incorrect > code using these fields was the cause

Re: A small tweak to some comments for PartitionKeyData

2018-10-24 Thread Amit Langote
On 2018/10/25 13:13, David Rowley wrote: > On 25 October 2018 at 17:05, Amit Langote > wrote: >> On 2018/10/25 12:54, David Rowley wrote: >>> On 25 October 2018 at 16:46, Amit Langote >>> wrote: +* key, one for each

Re: A small tweak to some comments for PartitionKeyData

2018-10-24 Thread David Rowley
On 25 October 2018 at 17:05, Amit Langote wrote: > On 2018/10/25 12:54, David Rowley wrote: >> On 25 October 2018 at 16:46, Amit Langote >> wrote: >>> +* key, one >>> for each zero-valued partattrs */ >>> >>> How about: for each

Re: A small tweak to some comments for PartitionKeyData

2018-10-24 Thread Amit Langote
On 2018/10/25 12:54, David Rowley wrote: > On 25 October 2018 at 16:46, Amit Langote > wrote: >> +* key, one >> for each zero-valued partattrs */ >> >> How about: for each zero-valued member of partattrs? > > Aren't arrays made up

Re: A small tweak to some comments for PartitionKeyData

2018-10-24 Thread David Rowley
On 25 October 2018 at 16:46, Amit Langote wrote: > +* key, one > for each zero-valued partattrs */ > > How about: for each zero-valued member of partattrs? Aren't arrays made up of elements? I did have "element" on the end, but I

Re: A small tweak to some comments for PartitionKeyData

2018-10-24 Thread Amit Langote
On 2018/10/25 12:43, David Rowley wrote: > While doing a bit of work on a partitioning patch I noticed that it's > not really that obvious that there's meant to be exactly 1 item in the > partexprs List for each zero-valued partattrs element. Some incorrect > code using these fields was the cause

A small tweak to some comments for PartitionKeyData

2018-10-24 Thread David Rowley
While doing a bit of work on a partitioning patch I noticed that it's not really that obvious that there's meant to be exactly 1 item in the partexprs List for each zero-valued partattrs element. Some incorrect code using these fields was the cause of CVE-2018-1052, so I think it's worthwhile to